From nobody Wed Dec 17 21:46:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585661297; cv=none; d=zohomail.com; s=zohoarc; b=bSMqIeoRnUx0Zm0kup9fJut/kgHlGLQ4KR44Hp5Er34IeMazNlHjnSSm9yPkbx7GWsGU+uiUB8ppl9/kc1zCOzdC4kRDCX2ExieL7hOqhtcsQQTLFzu1efiEwLBK4HgqZ7kN6AoAaxGQyCODa6VWjrmREEWxLjbkj+wQPGHcbuA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585661297; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Vr+3UYJLFSKZG8ktFtie/vjm4Z4gRJhmEP9NL974v7c=; b=Cva6NOpWnDDM8Glw2eimaQurThMogNiWQQrPEF0MrPPXCkZwLcSuJi4t1nExB+oTeari51/9WSM2Xt238Cr4Ji0qtzIYy3KcBtiLQH77jAFVGCvwbSpeFoGHPJNiySMp/Flc8dr8yFsMiKBanACFAPPyJENgArs0bUPee/Faj1U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585661297273794.1572942697453; Tue, 31 Mar 2020 06:28:17 -0700 (PDT) Received: from localhost ([::1]:38032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJGwC-0001s4-2Y for importer@patchew.org; Tue, 31 Mar 2020 09:28:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41993) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJGqG-0000KQ-55 for qemu-devel@nongnu.org; Tue, 31 Mar 2020 09:22:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJGqF-0005mA-1h for qemu-devel@nongnu.org; Tue, 31 Mar 2020 09:22:08 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:24236 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJGqE-0005lY-Ag for qemu-devel@nongnu.org; Tue, 31 Mar 2020 09:22:07 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-lj0_-5pLPJuguTByGOWBaA-1; Tue, 31 Mar 2020 09:22:04 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F353801E74; Tue, 31 Mar 2020 13:22:03 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-118.pek2.redhat.com [10.72.12.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FBE210002B5; Tue, 31 Mar 2020 13:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585660926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vr+3UYJLFSKZG8ktFtie/vjm4Z4gRJhmEP9NL974v7c=; b=Jh+rhCaVHTsOCbfYiBo3eNbwpj6DqeMaV/TjNL5P7odqLret2Gmuu1RRkmzyyUtiPg0V4x nJe5fuhQRBahyoCe90+jHFlywhY+XbA2JzVLbsmESEqiqGtvGyhwgTWNFq4MXcJ7nZYFIo okflmnUtZK7AnZ9QTAF8CsyrAe0lsHY= X-MC-Unique: lj0_-5pLPJuguTByGOWBaA-1 From: Jason Wang To: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PULL V2 06/14] hw/net/rtl8139: Simplify if/else statement Date: Tue, 31 Mar 2020 21:21:31 +0800 Message-Id: <1585660899-11228-7-git-send-email-jasowang@redhat.com> In-Reply-To: <1585660899-11228-1-git-send-email-jasowang@redhat.com> References: <1585660899-11228-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 Rewrite: if (E) { return A; } else { return B; } /* EOF */ } as: if (E) { return A; } return B; } Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Jason Wang --- hw/net/rtl8139.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index ae4739b..ef32115 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -808,11 +808,11 @@ static int rtl8139_can_receive(NetClientState *nc) /* ??? Flow control not implemented in c+ mode. This is a hack to work around slirp deficiencies anyway. */ return 1; - } else { - avail =3D MOD2(s->RxBufferSize + s->RxBufPtr - s->RxBufAddr, - s->RxBufferSize); - return (avail =3D=3D 0 || avail >=3D 1514 || (s->IntrMask & RxOver= flow)); } + + avail =3D MOD2(s->RxBufferSize + s->RxBufPtr - s->RxBufAddr, + s->RxBufferSize); + return avail =3D=3D 0 || avail >=3D 1514 || (s->IntrMask & RxOverflow); } =20 static ssize_t rtl8139_do_receive(NetClientState *nc, const uint8_t *buf, = size_t size_, int do_interrupt) --=20 2.5.0