From nobody Fri Apr 11 20:28:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585307980; cv=none; d=zohomail.com; s=zohoarc; b=mECTFVaX0ZjKFByYDKTNc1qjQjwVtG4Uq1DoWF6UsuBRRPsX4D6s/U2ZYgA68KfDpDyEBYGEPOxWqgnBSGE6fzgZ2pSfzvZEyv7lh/at4F7+sGxkI8FYv9iz+GBCdxI2LmYzNMJ9aYDq3Q5WzasX8JHjcEZsEaEeJsIBXlMKFDo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585307980; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=n8HmSTm9WnCU4dZKskIiwKW5MV+WGIgJj9Ow7s72VtQ=; b=DplfX2akMQQsQDHesbDDkJdmWAmCGl4domJpW8B/wMnE5Y/7LxRKHVyXiSqdfjwKqte3OfOVBaiSz30ljxyM815jFzV2I78/hlZtL9P6SXSa+Nigy5h4Aw7ajESoZwUs2q8gIbShjFoxVk/SrNr3b7hz8A4IPSmFhR8u6oDXhS4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585307980150714.1401448028354; Fri, 27 Mar 2020 04:19:40 -0700 (PDT) Received: from localhost ([::1]:40370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHn1W-0000Yd-NH for importer@patchew.org; Fri, 27 Mar 2020 07:19:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHmwU-0000nI-OQ for qemu-devel@nongnu.org; Fri, 27 Mar 2020 07:14:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHmwT-0001je-Mc for qemu-devel@nongnu.org; Fri, 27 Mar 2020 07:14:26 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:34078) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHmwT-0001ij-IB for qemu-devel@nongnu.org; Fri, 27 Mar 2020 07:14:25 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-6lD9y5vkOu2ncYo-OELmaA-1; Fri, 27 Mar 2020 07:14:23 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2642F100550E; Fri, 27 Mar 2020 11:14:22 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-77.pek2.redhat.com [10.72.12.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 756A25E016; Fri, 27 Mar 2020 11:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585307665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n8HmSTm9WnCU4dZKskIiwKW5MV+WGIgJj9Ow7s72VtQ=; b=LM2jyzFrGEG7RpxnJGvxvNJ4jpGpbpq0ii1iHnOMUt2KxXxn85LECl9cLzizj2x6biF1JS QyFw2S02Q/AatIp35b5iRL8kl8wtrsOA6rvNBphDbLaHUfG5TOTiYHn/DwbpabM8lg2foJ QPHfbb1khSQJmp9mpidNpQ2JMLiRWng= X-MC-Unique: 6lD9y5vkOu2ncYo-OELmaA-1 From: Jason Wang To: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PULL 05/13] hw/net/smc91c111: Let smc91c111_can_receive() return a boolean Date: Fri, 27 Mar 2020 19:13:59 +0800 Message-Id: <1585307647-24456-6-git-send-email-jasowang@redhat.com> In-Reply-To: <1585307647-24456-1-git-send-email-jasowang@redhat.com> References: <1585307647-24456-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 The smc91c111_can_receive() function simply returns a boolean value. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Jason Wang --- hw/net/smc91c111.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index e9eb6f6..02be60c 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c @@ -130,16 +130,16 @@ static void smc91c111_update(smc91c111_state *s) qemu_set_irq(s->irq, level); } =20 -static int smc91c111_can_receive(smc91c111_state *s) +static bool smc91c111_can_receive(smc91c111_state *s) { if ((s->rcr & RCR_RXEN) =3D=3D 0 || (s->rcr & RCR_SOFT_RST)) { - return 1; + return true; } if (s->allocated =3D=3D (1 << NUM_PACKETS) - 1 || s->rx_fifo_len =3D=3D NUM_PACKETS) { - return 0; + return false; } - return 1; + return true; } =20 static inline void smc91c111_flush_queued_packets(smc91c111_state *s) --=20 2.5.0