From nobody Tue Feb 10 02:46:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583230613; cv=none; d=zohomail.com; s=zohoarc; b=GMb71DfLtBsTWcmwplvWvXJHHq0zegqStbXYf+SlWEnkXZRoHYRefRrxvmGHIt1qccFoAUS6ZpTSSd04OyX6/YcqteAxv7prDyqrNMpmBI4C45J2WNuTo/kYlKR6yI9YsLJKqRfVWFdP8uCuvSXB3VadslEK1bPxWJCiI3VDFfc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583230613; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S9wXbDIJbh+XQKrN8+dstIByeULUyHMNTV2YYVdc9pc=; b=Gv3GMU+giqdsCLczCUaAtg1qQfDGDjMX3HXpHkL+ogIlRVyah0IBLVix1lRxr54Re2NgMehOqXGjdL0Wh40TOflMnOaUUgA+2RdvB5xROIEfVDy5z5JiayZpVFv7TPTcB/HPKpZ+m2FLAe70oWmCIotRNZDjJubcnOWabyXxiMU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15832306135969.868366025373575; Tue, 3 Mar 2020 02:16:53 -0800 (PST) Received: from localhost ([::1]:44754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j94bc-0003VS-6o for importer@patchew.org; Tue, 03 Mar 2020 05:16:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52533) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j94W6-0007go-EF for qemu-devel@nongnu.org; Tue, 03 Mar 2020 05:11:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j94W5-0006Bg-E8 for qemu-devel@nongnu.org; Tue, 03 Mar 2020 05:11:10 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:45008 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j94W4-0006B4-2X for qemu-devel@nongnu.org; Tue, 03 Mar 2020 05:11:08 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-7doRSl5ON7qOyU0SLYej5A-1; Tue, 03 Mar 2020 05:11:05 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9142D1005F66; Tue, 3 Mar 2020 10:11:04 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-98.pek2.redhat.com [10.72.12.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF0BD8B745; Tue, 3 Mar 2020 10:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583230267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S9wXbDIJbh+XQKrN8+dstIByeULUyHMNTV2YYVdc9pc=; b=NBO9UXaalCQfTJvMO0Ju1Mnpf09AgTzZvIg1h19rD2WRXgNntjShMuhYRJLhmiFMVW2+mb WM/4m4kRyWgQ88iO55RDfg+eTkDtUTUnpYBB/LHx8Un6efSX69lvbuSXYp6xnJrUOkliGc zhKRrTaa3UWpCXskJrbHtEcRZue1ngM= X-MC-Unique: 7doRSl5ON7qOyU0SLYej5A-1 From: Jason Wang To: peter.maydell@linaro.org Subject: [PULL V2 08/23] dp8393x: Don't clobber packet checksum Date: Tue, 3 Mar 2020 18:10:27 +0800 Message-Id: <1583230242-14597-9-git-send-email-jasowang@redhat.com> In-Reply-To: <1583230242-14597-1-git-send-email-jasowang@redhat.com> References: <1583230242-14597-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , qemu-devel@nongnu.org, Finn Thain Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Finn Thain A received packet consumes pkt_size bytes in the buffer and the frame checksum that's appended to it consumes another 4 bytes. The Receive Buffer Address register takes the former quantity into account but not the latter. So the next packet written to the buffer overwrites the frame checksum. Fix this. Signed-off-by: Finn Thain Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/dp8393x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 911f59e..6329341 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -818,6 +818,7 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, address +=3D rx_len; address_space_write(&s->as, address, MEMTXATTRS_UNSPECIFIED, &checksum, 4); + address +=3D 4; rx_len +=3D 4; s->regs[SONIC_CRBA1] =3D address >> 16; s->regs[SONIC_CRBA0] =3D address & 0xffff; --=20 2.5.0