From nobody Sat Feb 7 07:31:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583135312; cv=none; d=zohomail.com; s=zohoarc; b=M5i1ZZRSaX8t4nh8ZflDFT1oupZm1pQTt/+mhHoYiKtptE8kT2JL5TNXgyvT3Dddye79sQxYp/fYKCMsfgwqGr9g6IR1DShXyj507vTGkcHlpFaYOL/EqsH5l9Kw8acq+L6bOhq1HklNPa/fkrHlONhJGl+9R1BW1ai7UC0qB5A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583135312; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fq233vp5w5aZrfj8fLdkUXIRg6LJGgiJqm59yH0KHgM=; b=AZPXYwKBdetY+rgm31XFzApaiU7anqAWKBoqD9/7jOfaXE9ufB0JkVzfkhu9KzzCHTHW6H6DLYynxlXN9G0ISqVL6hCER1RxM192nMClkPcImgDZ2fvww0fBtcc06RbHOznhcpnnPu7Mg0oRmvFz3vqJabRQVBr1xjOHgLoR4Hc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583135312733255.91176966909586; Sun, 1 Mar 2020 23:48:32 -0800 (PST) Received: from localhost ([::1]:56078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8foV-00005N-8G for importer@patchew.org; Mon, 02 Mar 2020 02:48:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60080) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8fhF-0003rq-Ue for qemu-devel@nongnu.org; Mon, 02 Mar 2020 02:41:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8fhE-0003Ue-Vw for qemu-devel@nongnu.org; Mon, 02 Mar 2020 02:41:01 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:41216 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8fhE-0003US-S7 for qemu-devel@nongnu.org; Mon, 02 Mar 2020 02:41:00 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-PrPTAb6AOUORCHCBz_6wGg-1; Mon, 02 Mar 2020 02:40:56 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4515F18FE861; Mon, 2 Mar 2020 07:40:55 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-58.pek2.redhat.com [10.72.12.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id B197060BF3; Mon, 2 Mar 2020 07:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583134860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fq233vp5w5aZrfj8fLdkUXIRg6LJGgiJqm59yH0KHgM=; b=cFujHfCz7pSVeDWlsr4MZzNYWtEOJ/RgZcFUjdNyRhTZc+UO/RgQfPvnL84AgnWW6InMtb ubLA8LTy4VUBBV9wqJFtijb9dYS7DBX2jmj14XnsIByRP6HylpOyPBBJNcZEnAMQSJkzvk /lnwctuaWot68sM/FLL8QHbJEoyJkIM= X-MC-Unique: PrPTAb6AOUORCHCBz_6wGg-1 From: Jason Wang To: peter.maydell@linaro.org Subject: [PULL 06/23] dp8393x: Clear RRRA command register bit only when appropriate Date: Mon, 2 Mar 2020 15:40:19 +0800 Message-Id: <1583134836-23991-7-git-send-email-jasowang@redhat.com> In-Reply-To: <1583134836-23991-1-git-send-email-jasowang@redhat.com> References: <1583134836-23991-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , qemu-devel@nongnu.org, Finn Thain Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Finn Thain It doesn't make sense to clear the command register bit unless the command was actually issued. Signed-off-by: Finn Thain Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/dp8393x.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 9604623..b5a9c6a 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -352,9 +352,6 @@ static void dp8393x_do_read_rra(dp8393xState *s) s->regs[SONIC_ISR] |=3D SONIC_ISR_RBE; dp8393x_update_irq(s); } - - /* Done */ - s->regs[SONIC_CR] &=3D ~SONIC_CR_RRRA; } =20 static void dp8393x_do_software_reset(dp8393xState *s) @@ -565,8 +562,10 @@ static void dp8393x_do_command(dp8393xState *s, uint16= _t command) dp8393x_do_start_timer(s); if (command & SONIC_CR_RST) dp8393x_do_software_reset(s); - if (command & SONIC_CR_RRRA) + if (command & SONIC_CR_RRRA) { dp8393x_do_read_rra(s); + s->regs[SONIC_CR] &=3D ~SONIC_CR_RRRA; + } if (command & SONIC_CR_LCAM) dp8393x_do_load_cam(s); } --=20 2.5.0