From nobody Thu Dec 18 17:56:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583135305; cv=none; d=zohomail.com; s=zohoarc; b=i4Q8GfT3j4OxB89Py8BRk1uGKseiJ/sO38E/mj/LgVBEljFAXYCWOFtKM+leWt9eCMrTc11s3kj2bRk2Ou/k7dxmsT1yDH9qOokDMMDjjfHkhVR9fEOZIUPUGZvR3gfj7B8qwZBPK7RFb9Xtj63yDSoebAaokgMsHAMFdci5Rko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583135305; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=BlE0x2fR9K2mXTXTBNzBYeg25MEh6hC6Sfj3IF0JJq8=; b=D9PD5+TGzDKqwLS6rP4wMBsIQiqRbbHPJCot5d1PwTb/TUYguGdzz80dOCm7esMP9xbvU36Xr42nfQGhe2cSoWfBl7fT9ePCXyWQu5Hdu6b5x7cTf2KFDh1kRP6pIXnMhDuYErHOqnp+nR6qK7rqQeXOJA6hHvd0OHCHhIk7K1E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583135305753577.7121283258136; Sun, 1 Mar 2020 23:48:25 -0800 (PST) Received: from localhost ([::1]:56074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8foO-0008GQ-Fx for importer@patchew.org; Mon, 02 Mar 2020 02:48:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60169) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8fhP-0004DH-L1 for qemu-devel@nongnu.org; Mon, 02 Mar 2020 02:41:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8fhO-0003cM-Hr for qemu-devel@nongnu.org; Mon, 02 Mar 2020 02:41:11 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34332 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8fhO-0003c6-Dw for qemu-devel@nongnu.org; Mon, 02 Mar 2020 02:41:10 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-920iXU6NOdCayOD-QaRAfw-1; Mon, 02 Mar 2020 02:41:07 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 13B3618FE860; Mon, 2 Mar 2020 07:41:06 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-58.pek2.redhat.com [10.72.12.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D60460BF3; Mon, 2 Mar 2020 07:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583134870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BlE0x2fR9K2mXTXTBNzBYeg25MEh6hC6Sfj3IF0JJq8=; b=buzsa9kb7NFgzHquk6sKXMweUiaYpDHcbtTlWgbWyX+ZVnCLmNuYsgNU6d1ruNE8EQUvt6 JaQwFiWXMMs2qFCRS3ciEsiwgh6XmKCdRgjF3vfjLmiEiOLYjFvAdyxsHUArqNh97oxHwA 2Bi1kznmt4cFC1z5r0WmZ2FZwxiOlZ0= X-MC-Unique: 920iXU6NOdCayOD-QaRAfw-1 From: Jason Wang To: peter.maydell@linaro.org Subject: [PULL 11/23] dp8393x: Clear descriptor in_use field to release packet Date: Mon, 2 Mar 2020 15:40:24 +0800 Message-Id: <1583134836-23991-12-git-send-email-jasowang@redhat.com> In-Reply-To: <1583134836-23991-1-git-send-email-jasowang@redhat.com> References: <1583134836-23991-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , qemu-devel@nongnu.org, Finn Thain Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Finn Thain When the SONIC receives a packet into the last available descriptor, it retains ownership of that descriptor for as long as necessary. Section 3.4.7 of the datasheet says, When the system appends more descriptors, the SONIC releases ownership of the descriptor after writing 0000h to the RXpkt.in_use field. The packet can now be processed by the host, so raise a PKTRX interrupt, just like the normal case. Signed-off-by: Finn Thain Tested-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/dp8393x.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 22b4d36..08194a4 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -811,7 +811,17 @@ static ssize_t dp8393x_receive(NetClientState *nc, con= st uint8_t * buf, return -1; } /* Link has been updated by host */ + + /* Clear in_use */ + size =3D sizeof(uint16_t) * width; + address =3D dp8393x_crda(s) + sizeof(uint16_t) * 6 * width; + dp8393x_put(s, width, 0, 0); + address_space_rw(&s->as, address, MEMTXATTRS_UNSPECIFIED, + (uint8_t *)s->data, size, 1); + + /* Move to next descriptor */ s->regs[SONIC_CRDA] =3D s->regs[SONIC_LLFA]; + s->regs[SONIC_ISR] |=3D SONIC_ISR_PKTRX; } =20 /* Save current position */ --=20 2.5.0