From nobody Thu Dec 18 17:55:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583135106; cv=none; d=zohomail.com; s=zohoarc; b=jIgxrp+gqvzi5aJ84HMdrEzX9DaLVDniQfTrvOGXJX9L4zIERbD8yD+iSGILknpFiVWVoI9vCRkE/0WUuswb24WaIxn4fO68poYHZ3ndxenH8+U+cXiCGAugrlm93gLeuRV1hmmrhQdeQ/ujFoKb2eTWzKgrD3yDq2olCOnIPfE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583135106; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cb4ZfAWCO9mcSOBb5FJvhksNequRo3224EqHsve4XNM=; b=feoWqZ9Suy9jox1vq6ssGGnul4BK+dNmnmZ/hDQ0Ae2uENR8c10uuTZhxKcgOOaXxA2hO353OcyZFQJX6gmioYh+Y3Af0nw+1A+YZGwg3TH16NQVOzzKYuvtaxMqxNwt4o10PM2mf/mQh/uiYbT7zajR48KB6ZjJaDkH4KHBBxo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583135106856886.0531453217501; Sun, 1 Mar 2020 23:45:06 -0800 (PST) Received: from localhost ([::1]:56026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8flA-0003jz-Fa for importer@patchew.org; Mon, 02 Mar 2020 02:45:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60144) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8fhM-00045f-QI for qemu-devel@nongnu.org; Mon, 02 Mar 2020 02:41:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8fhL-0003Zc-PP for qemu-devel@nongnu.org; Mon, 02 Mar 2020 02:41:08 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:31273 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8fhL-0003ZO-Lw for qemu-devel@nongnu.org; Mon, 02 Mar 2020 02:41:07 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-1-ym7SSIZqMLScoX7yKc17gg-1; Mon, 02 Mar 2020 02:41:03 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C02C7800D5A; Mon, 2 Mar 2020 07:41:01 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-58.pek2.redhat.com [10.72.12.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id 20C2060BF3; Mon, 2 Mar 2020 07:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583134867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cb4ZfAWCO9mcSOBb5FJvhksNequRo3224EqHsve4XNM=; b=QfSoL2S/ztrmIc+NHfW1v74itjduNLNHGfiXgw7+V5i1tYwJ4oSFW+HD0VLqyWzqOncevD 8lqfAYILKJdcC8SMN/6pwXxHHMG0i6DkEU+69BHsK2ZOBG3rO6h9zhuLNPQ0yWLdL3zouJ Gw5nC2KV7mcv1CqLLCV/r+pKZL+EOPo= X-MC-Unique: ym7SSIZqMLScoX7yKc17gg-1 From: Jason Wang To: peter.maydell@linaro.org Subject: [PULL 09/23] dp8393x: Use long-word-aligned RRA pointers in 32-bit mode Date: Mon, 2 Mar 2020 15:40:22 +0800 Message-Id: <1583134836-23991-10-git-send-email-jasowang@redhat.com> In-Reply-To: <1583134836-23991-1-git-send-email-jasowang@redhat.com> References: <1583134836-23991-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , qemu-devel@nongnu.org, Finn Thain Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Finn Thain Section 3.4.1 of the datasheet says, The alignment of the RRA is confined to either word or long word boundaries, depending upon the data width mode. In 16-bit mode, the RRA must be aligned to a word boundary (A0 is always zero) and in 32-bit mode, the RRA is aligned to a long word boundary (A0 and A1 are always zero). This constraint has been implemented for 16-bit mode; implement it for 32-bit mode too. Signed-off-by: Finn Thain Tested-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Jason Wang --- hw/net/dp8393x.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 6329341..d8bf248 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -665,12 +665,16 @@ static void dp8393x_write(void *opaque, hwaddr addr, = uint64_t data, qemu_flush_queued_packets(qemu_get_queue(s->nic)); } break; - /* Ignore least significant bit */ + /* The guest is required to store aligned pointers here */ case SONIC_RSA: case SONIC_REA: case SONIC_RRP: case SONIC_RWP: - s->regs[reg] =3D val & 0xfffe; + if (s->regs[SONIC_DCR] & SONIC_DCR_DW) { + s->regs[reg] =3D val & 0xfffc; + } else { + s->regs[reg] =3D val & 0xfffe; + } break; /* Invert written value for some registers */ case SONIC_CRCT: --=20 2.5.0