From nobody Mon Oct 13 23:42:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1582358864; cv=none; d=zohomail.com; s=zohoarc; b=TkjuJw+OV2nrAoJ5w/T2USOP0jKCz3ZKPHws7ZLVUdjmeX4oO8iXP3pbcwrb+DGgts0fjpqkLGcSLsU2YxrhVacJ01RrAhntmV9Esf6WlMolvoXEFBxDS4HT7sBUSrNvxrtOygYubcgjPF4FA1lxszaP20tRwOKJGcDjWBJCojw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582358864; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=89ajzbcGBHKl4tekXs1JPVSwTNo6eY7DxN592EoRQ3c=; b=V15+dN1pw9bjfsfGLoBQJTnfGH3/FWveRYm10hWMkBSrPi/gOTBYMbGXENrrivxODLv91T3LkrxHZ4UBlOoq6XjtPbZ4s/2/XrBM/Houbt103hGMmLqMWSixVeY1ObveEcPSM2tIZQwQUqkGtzFTdMI6YE035/Y8BTQY8/MPFq4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582358864099850.0641904967708; Sat, 22 Feb 2020 00:07:44 -0800 (PST) Received: from localhost ([::1]:39971 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5Pp9-0002ZN-2e for importer@patchew.org; Sat, 22 Feb 2020 03:07:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57534) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5Pjm-0002Bg-Jr for qemu-devel@nongnu.org; Sat, 22 Feb 2020 03:02:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5Pjj-00082w-DT for qemu-devel@nongnu.org; Sat, 22 Feb 2020 03:02:10 -0500 Received: from mga12.intel.com ([192.55.52.136]:36223) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j5Pjj-0007tv-1a for qemu-devel@nongnu.org; Sat, 22 Feb 2020 03:02:07 -0500 Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2020 00:01:57 -0800 Received: from jacob-builder.jf.intel.com ([10.7.199.155]) by orsmga006.jf.intel.com with ESMTP; 22 Feb 2020 00:01:56 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,471,1574150400"; d="scan'208";a="240547671" From: Liu Yi L To: qemu-devel@nongnu.org, alex.williamson@redhat.com, peterx@redhat.com Subject: [RFC v3.1 07/22] vfio: get nesting iommu cap info from Kernel Date: Sat, 22 Feb 2020 00:07:08 -0800 Message-Id: <1582358843-51931-8-git-send-email-yi.l.liu@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1582358843-51931-1-git-send-email-yi.l.liu@intel.com> References: <1582358843-51931-1-git-send-email-yi.l.liu@intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.136 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kevin.tian@intel.com, yi.l.liu@intel.com, Yi Sun , kvm@vger.kernel.org, mst@redhat.com, jun.j.tian@intel.com, eric.auger@redhat.com, yi.y.sun@intel.com, Jacob Pan , pbonzini@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" VFIO exposes host IOMMU dual-stage DMA translation programming capability to userspace by VFIO_TYPE1_NESTING_IOMMU type. However, userspace needs more info on the nesting type. e.g. the supported stage 1 format and PASID alloc/free request availability. This patch gets the iommu nesting cap info from kernel by using IOCTL VFIO_IOMMU_GET_INFO. This patch referred some code from Shameer Kolothum. https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg03759.html Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Eric Auger Cc: Yi Sun Cc: David Gibson Cc: Alex Williamson Signed-off-by: Shameer Kolothum Signed-off-by: Liu Yi L --- hw/iommu/host_iommu_context.c | 5 +- hw/vfio/common.c | 97 +++++++++++++++++++++++++++++++= +++- include/hw/iommu/host_iommu_context.h | 10 +++- 3 files changed, 108 insertions(+), 4 deletions(-) diff --git a/hw/iommu/host_iommu_context.c b/hw/iommu/host_iommu_context.c index 11b092f..689a087 100644 --- a/hw/iommu/host_iommu_context.c +++ b/hw/iommu/host_iommu_context.c @@ -42,10 +42,13 @@ int host_iommu_ctx_pasid_free(HostIOMMUContext *host_ic= x, uint32_t pasid) } =20 void host_iommu_ctx_init(HostIOMMUContext *host_icx, - uint64_t flags, HostIOMMUOps *ops) + uint64_t flags, HostIOMMUOps *ops, + HostIOMMUInfo *uinfo) { host_icx->flags =3D flags; host_icx->ops =3D ops; + + host_icx->uinfo.stage1_format =3D uinfo->stage1_format; } =20 void host_iommu_ctx_destroy(HostIOMMUContext *host_icx) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 9ab62a6..f9be68d 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -1183,6 +1183,84 @@ static struct HostIOMMUOps vfio_host_icx_ops =3D { /* To be added later */ }; =20 +/** + * Get iommu info from host. Caller of this funcion should free + * the memory pointed by the returned pointer stored in @info + * after a successful calling when finished its usage. + */ +static int vfio_get_iommu_info(VFIOContainer *container, + struct vfio_iommu_type1_info **info) +{ + + size_t argsz =3D sizeof(struct vfio_iommu_type1_info); + + *info =3D g_malloc0(argsz); + +retry: + (*info)->argsz =3D argsz; + + if (ioctl(container->fd, VFIO_IOMMU_GET_INFO, *info)) { + g_free(*info); + *info =3D NULL; + return -errno; + } + + if (((*info)->argsz > argsz)) { + argsz =3D (*info)->argsz; + *info =3D g_realloc(*info, argsz); + goto retry; + } + + return 0; +} + +static struct vfio_info_cap_header * +vfio_get_iommu_info_cap(struct vfio_iommu_type1_info *info, uint16_t id) +{ + struct vfio_info_cap_header *hdr; + void *ptr =3D info; + + if (!(info->flags & VFIO_IOMMU_INFO_CAPS)) { + return NULL; + } + + for (hdr =3D ptr + info->cap_offset; hdr !=3D ptr; hdr =3D ptr + hdr->= next) { + if (hdr->id =3D=3D id) { + return hdr; + } + } + + return NULL; +} + +static int vfio_get_nesting_iommu_cap(VFIOContainer *container, + struct vfio_iommu_type1_info_cap_nesting *cap_nesting) +{ + struct vfio_iommu_type1_info *info; + struct vfio_info_cap_header *hdr; + struct vfio_iommu_type1_info_cap_nesting *cap; + int ret; + + ret =3D vfio_get_iommu_info(container, &info); + if (ret) { + return ret; + } + + hdr =3D vfio_get_iommu_info_cap(info, + VFIO_IOMMU_TYPE1_INFO_CAP_NESTING); + if (!hdr) { + g_free(info); + return -errno; + } + + cap =3D container_of(hdr, + struct vfio_iommu_type1_info_cap_nesting, header); + *cap_nesting =3D *cap; + + g_free(info); + return 0; +} + static int vfio_init_container(VFIOContainer *container, int group_fd, Error **errp) { @@ -1216,8 +1294,23 @@ static int vfio_init_container(VFIOContainer *contai= ner, int group_fd, } =20 if (iommu_type =3D=3D VFIO_TYPE1_NESTING_IOMMU) { - host_iommu_ctx_init(&container->host_icx, - flags, &vfio_host_icx_ops); + struct vfio_iommu_type1_info_cap_nesting nesting =3D { + .nesting_capabilities =3D 0x0, + .stage1_format =3D 0, }; + HostIOMMUInfo uinfo; + + ret =3D vfio_get_nesting_iommu_cap(container, &nesting); + if (ret) { + error_setg_errno(errp, -ret, + "Failed to get nesting iommu cap"); + return ret; + } + + uinfo.stage1_format =3D nesting.stage1_format; + flags |=3D (nesting.nesting_capabilities & VFIO_IOMMU_PASID_REQS) ? + HOST_IOMMU_PASID_REQUEST : 0; + host_iommu_ctx_init(&container->host_icx, flags, + &vfio_host_icx_ops, &uinfo); } =20 container->iommu_type =3D iommu_type; diff --git a/include/hw/iommu/host_iommu_context.h b/include/hw/iommu/host_= iommu_context.h index f4d811a..6797f6d 100644 --- a/include/hw/iommu/host_iommu_context.h +++ b/include/hw/iommu/host_iommu_context.h @@ -23,12 +23,14 @@ #define HW_IOMMU_CONTEXT_H =20 #include "qemu/queue.h" +#include #ifndef CONFIG_USER_ONLY #include "exec/hwaddr.h" #endif =20 typedef struct HostIOMMUContext HostIOMMUContext; typedef struct HostIOMMUOps HostIOMMUOps; +typedef struct HostIOMMUInfo HostIOMMUInfo; =20 struct HostIOMMUOps { /* Allocate pasid from HostIOMMUContext (a.k.a. host software) */ @@ -41,6 +43,10 @@ struct HostIOMMUOps { uint32_t pasid); }; =20 +struct HostIOMMUInfo { + uint32_t stage1_format; +}; + /* * This is an abstraction of host IOMMU with dual-stage capability */ @@ -48,6 +54,7 @@ struct HostIOMMUContext { #define HOST_IOMMU_PASID_REQUEST (1ULL << 0) uint64_t flags; HostIOMMUOps *ops; + HostIOMMUInfo uinfo; }; =20 int host_iommu_ctx_pasid_alloc(HostIOMMUContext *host_icx, uint32_t min, @@ -55,7 +62,8 @@ int host_iommu_ctx_pasid_alloc(HostIOMMUContext *host_icx= , uint32_t min, int host_iommu_ctx_pasid_free(HostIOMMUContext *host_icx, uint32_t pasid); =20 void host_iommu_ctx_init(HostIOMMUContext *host_icx, - uint64_t flags, HostIOMMUOps *ops); + uint64_t flags, HostIOMMUOps *ops, + HostIOMMUInfo *uinfo); void host_iommu_ctx_destroy(HostIOMMUContext *host_icx); =20 #endif --=20 2.7.4