From nobody Thu Nov 13 14:57:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581521058127148.674816997903; Wed, 12 Feb 2020 07:24:18 -0800 (PST) Received: from localhost ([::1]:39330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1ts7-0004zP-HQ for importer@patchew.org; Wed, 12 Feb 2020 10:24:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54156) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1trT-0004ao-Hm for qemu-devel@nongnu.org; Wed, 12 Feb 2020 10:23:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1trS-0004Qx-KR for qemu-devel@nongnu.org; Wed, 12 Feb 2020 10:23:35 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:34863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1trS-0004QS-FG for qemu-devel@nongnu.org; Wed, 12 Feb 2020 10:23:34 -0500 Received: by mail-wr1-x444.google.com with SMTP id w12so2867718wrt.2 for ; Wed, 12 Feb 2020 07:23:34 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id x6sm1003102wmi.44.2020.02.12.07.23.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Feb 2020 07:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=0KVa8dFcX9dZEaPZuajWt7yQlRiUOO7AefwWyVC4W9M=; b=Olp/L0E9Qt7y4qIWW2aPPYhUF7w0RMF8ilksW73I9DLShLHIKJcHs16ITtlRxhoKLE nIoKHp9gxhdQ5SNc6+jdjxLHkM/RUNNK3CZIvhGtVqJw7WD6KoCUPLgd4avXNSmJXP0z 5lrdM39pmP6RhZkFUDH2L1RWzORazkLCOpYdWM3zx6fGgThkJXwqg7W0031tolf0pfqZ JiKQd+gDjLtXQeubycyPC7usoZUsvoU1VzlLT9VMBMJ0XpsLMlFwkocUsOMmPf5Nw+kR Qr7mMNOoIprBLQ5i9getxw9MWCyOSwrYd/mfYJRPWUHlkceAx5UdNB0X33qjA3ed3Af6 KL4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=0KVa8dFcX9dZEaPZuajWt7yQlRiUOO7AefwWyVC4W9M=; b=JZp9jFERakUjfvu436zhjfW74HX2lN6iV8rKz4P52Whbn3Pf4KU1/kUI+Fj4YhVFH6 /TOpmTISaLpl7Y/gtL/9DW1JiK6N1wEAeOvSrltwZX9f8hHEiUX49ylccyQuktrU2sqh cs8ipbFOX6x1IB/Nzyg3H566zpAiYptGg0ASDQlyiZ0SW53wJPYr2q/O/uMttB+AWh9n HtxblBZLdcdJUzw0JaUf5VD3G4ARexX/3oYkILPHZg8GtbX+yPaJBfc3PfzLQAZOv/8R +esN7kgAUkftE14WMhOJIkqqAfnQPpI5szmrWIyjuVBHfOY804tI8wyh6BLWWwMgDMmw ONTg== X-Gm-Message-State: APjAAAVHBuxVMppOWOyczbZje0Q9kNBf6a7H0wbKc4xzeFhurL38bona myv7rbSk70mgVkxK7Yru6lyT8yDO X-Google-Smtp-Source: APXvYqz0nGDgu3rewB2yf5p3BVPTu2zjxi8mz818peVme+0KFU/venTGzJv7TNmIY8AbCq+4sGY6Sg== X-Received: by 2002:adf:b352:: with SMTP id k18mr15437207wrd.242.1581521012925; Wed, 12 Feb 2020 07:23:32 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH] target/i386: enable monitor and ucode revision with -cpu max Date: Wed, 12 Feb 2020 16:23:29 +0100 Message-Id: <1581521009-44121-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" These two features were incorrectly tied to host_cpuid_required rather than cpu->max_features. As a result, -cpu max was not enabling either MONITOR features or ucode revision. Signed-off-by: Paolo Bonzini Reviewed-by: Eduardo Habkost --- target/i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 32efa46..92fafa2 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6414,7 +6414,9 @@ static void x86_cpu_realizefn(DeviceState *dev, Error= **errp) error_setg(&local_err, "CPU model '%s' requires KVM", name); goto out; } + } =20 + if (cpu->max_features && accel_uses_host_cpuid()) { if (enable_cpu_pm) { host_cpuid(5, 0, &cpu->mwait.eax, &cpu->mwait.ebx, &cpu->mwait.ecx, &cpu->mwait.edx); --=20 1.8.3.1