From nobody Thu Nov 13 12:01:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579798614; cv=none; d=zohomail.com; s=zohoarc; b=oJjxs/56L8Obzb8jKXPnLPg4cRsARiZjEbO2PZWd5kxNX6lKZ08Hv8rIJ1WP3SkvfaV2krO+qsmIEBVG2WlJje6g5jpuhuSXVqnpDE7f6QpLDarW++mxOk9/NUR2LABB1Lcvv30jrM4XITLRw0EAqHsp84ifjfwUcYBVDRt/wK0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579798614; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4lOpQAex6+ed7KVCCMGrJwZB+MBzXKa8ZFG++CEMgy0=; b=NwSpVZdDH57WgQilKcmhcw+2ng+xMIuuGCKeOQj2k4om003XMarntSATcq5aCvmF8mEVwMHhslx44urNIOngzifNLWWaVZy1HB31PIxUUdyZZclcRSTEhiUSaevApKQS3GNo5pyCaInNp+mATNgNp8ix+X3+Ezj0qSvXthM1RlU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579798614805550.8368061121206; Thu, 23 Jan 2020 08:56:54 -0800 (PST) Received: from localhost ([::1]:32848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iufmn-0005Py-DV for importer@patchew.org; Thu, 23 Jan 2020 11:56:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52257) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuct5-0007g0-9r for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuct3-0006qz-3d for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:11 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:35320 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuct3-0006qm-1F for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:09 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-Zr24jV69O3WX4hGRw8HDGg-1; Thu, 23 Jan 2020 08:51:07 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 878AF100551A for ; Thu, 23 Jan 2020 13:51:06 +0000 (UTC) Received: from 640k.localdomain.com (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83DBA84DBD; Thu, 23 Jan 2020 13:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579787468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4lOpQAex6+ed7KVCCMGrJwZB+MBzXKa8ZFG++CEMgy0=; b=dVa+nPPteywISCVHHNjlNm9sd1sfHbiaS9pEhPpakTZZlsAGLhrtXjKeFxifAwTu0FNK4C bKBpX1dAa7uGsKI/uK4QGIkX98kKES6ROqNyLXCycfp+A86KCYLCBdp8evVNjX44iaAxJA SahCEM+/795bQNmrwB3IU7MENzhjPGc= From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 07/59] hw/display/tcx: Add missing fall through comments Date: Thu, 23 Jan 2020 14:49:57 +0100 Message-Id: <1579787449-27599-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> References: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: Zr24jV69O3WX4hGRw8HDGg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 When building with GCC9 using CFLAG -Wimplicit-fallthrough=3D2 we get: hw/display/tcx.c: In function =E2=80=98tcx_dac_writel=E2=80=99: hw/display/tcx.c:453:26: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 453 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index = autoincrement */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:454:9: note: here 454 | default: | ^~~~~~~ hw/display/tcx.c: In function =E2=80=98tcx_dac_readl=E2=80=99: hw/display/tcx.c:412:22: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 412 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index auto= increment */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:413:5: note: here 413 | default: | ^~~~~~~ cc1: all warnings being treated as errors Give a hint to GCC by adding the missing fall through comments. Fixes: 55d7bfe22 Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aleksandar Markovic Reviewed-by: Mark Cave-Ayland Message-Id: <20191218192526.13845-3-philmd@redhat.com> Signed-off-by: Paolo Bonzini --- hw/display/tcx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 14e829d..abbeb30 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -410,6 +410,7 @@ static uint64_t tcx_dac_readl(void *opaque, hwaddr addr, case 2: val =3D s->b[s->dac_index] << 24; s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincrement= */ + /* fall through */ default: s->dac_state =3D 0; break; @@ -451,6 +452,7 @@ static void tcx_dac_writel(void *opaque, hwaddr addr, u= int64_t val, s->b[index] =3D val >> 24; update_palette_entries(s, index, index + 1); s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincre= ment */ + /* fall through */ default: s->dac_state =3D 0; break; --=20 1.8.3.1