From nobody Thu Nov 13 12:01:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579798775; cv=none; d=zohomail.com; s=zohoarc; b=i2oNOdbMBokBzw5ANggVqn11gdkGRM3fsiyEePkVUaVBnEsrRL26GMXfA4QAGi3BoihoDgIfWLhCmMYkbXVn+lWAr3kzmhXkrRhfzn+qwqHd9RF85jrj96QA4pw6yZS/IcYUrquWAzt9Je8SABqcB3wdjUD4+Fk7Q2afYAHCZhE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579798775; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=E2MlMz4cN9CaACYckxJtaBM6X0v8cyJc+aK+uqDTqvw=; b=Yl+KqQ4cO+cZIJZIvHmzJ7eQb/dHOEWHh73k747KTwhkfF27P/cs/KBIP+d59mjdGMM//WfoWk7VuDQg/Qz2G6FmvcfXf1F/xgQXEL6ISDrGlhYuIK3tiuzL0P5jFVdPSIMLLJ5gSzp0+EagAh7S7TGqRnSTNyzEZyXOlja8pJI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579798775424120.52169111680064; Thu, 23 Jan 2020 08:59:35 -0800 (PST) Received: from localhost ([::1]:32876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iufpN-00008a-WB for importer@patchew.org; Thu, 23 Jan 2020 11:59:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52252) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuct5-0007fJ-0r for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuct2-0006qi-Sg for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:10 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:21369 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuct2-0006qI-QJ for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:08 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-81-EVTXLLaOPCq7nCvxtYs2Ag-1; Thu, 23 Jan 2020 08:51:07 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 119528017CC for ; Thu, 23 Jan 2020 13:51:05 +0000 (UTC) Received: from 640k.localdomain.com (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E29085780; Thu, 23 Jan 2020 13:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579787468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2MlMz4cN9CaACYckxJtaBM6X0v8cyJc+aK+uqDTqvw=; b=Z9GZvQXALPYVeyywn1t7epdA9xEXChs8zyKTbbZTP3W/l9lN81cKicAriR9Zbsd0JNxlBW CTG+YxS5aeVqyq1XtC7EG15E4Lg7rz8DjSP9BlA1ohsCCvzJc8OBafoi2nbgsTiWXMQ5bX /xGaOp4C3Via+l6GEP8jxulSxoNJYJc= From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 06/59] audio/audio: Add missing fall through comment Date: Thu, 23 Jan 2020 14:49:56 +0100 Message-Id: <1579787449-27599-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> References: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: EVTXLLaOPCq7nCvxtYs2Ag-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 When building with GCC9 using CFLAG -Wimplicit-fallthrough=3D2 we get: audio/audio.c: In function =E2=80=98audio_pcm_init_info=E2=80=99: audio/audio.c:306:14: error: this statement may fall through [-Werror=3Di= mplicit-fallthrough=3D] 306 | sign =3D 1; | ~~~~~^~~ audio/audio.c:307:5: note: here 307 | case AUDIO_FORMAT_U8: | ^~~~ cc1: all warnings being treated as errors Similarly to e46349414, add the missing fall through comment to hint GCC. Fixes: 2b9cce8c8c Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aleksandar Markovic Reviewed-by: Gerd Hoffmann Message-Id: <20191218192526.13845-2-philmd@redhat.com> Signed-off-by: Paolo Bonzini --- audio/audio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/audio/audio.c b/audio/audio.c index abea027..f63f397 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -304,6 +304,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, = struct audsettings *as) switch (as->fmt) { case AUDIO_FORMAT_S8: sign =3D 1; + /* fall through */ case AUDIO_FORMAT_U8: mul =3D 1; break; --=20 1.8.3.1