From nobody Thu Nov 13 12:02:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579798758; cv=none; d=zohomail.com; s=zohoarc; b=K/rzoUnQPlzhVVFVgHT/znHzLy0B0CwF/5uv1sn2xbqVC869ndqBVZbmXv45US3pBrOcGU601Vg40zydUZqxUEkYJnuYdsLB4X684iQqx3Da+IxMtVqe5d4V8S3+c7O1GCd/NADiD2+q4Fw8HjOfGzYOHhHtEKc05Guud8Grto8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579798758; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Z5XFGQqk7sa0oFK95YMlOz0cT3ZBKnoL8H8zBBcszCI=; b=mYA8jTPq0ytWtpNO+Zm+bQaSuxCxvLIzGM1pE0Uu3aMGopXmcP3kNo3vtec3XOh5LOk1jysd4UQWRPbFRF8f4m9w8sQLLaQRbig0zcsdNQEz+LoInEIaTxevk6+Quh85qjXre/VTcaeT/RSyNFBbbbHhcvcgy+oynlLI4ZAlxVU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579798758130335.30668672001923; Thu, 23 Jan 2020 08:59:18 -0800 (PST) Received: from localhost ([::1]:32866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iufp5-000855-V8 for importer@patchew.org; Thu, 23 Jan 2020 11:59:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52859) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iucu4-0000rV-G0 for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:52:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iucu3-0000uv-EJ for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:52:12 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:59449 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iucu3-0000uh-Bn for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:52:11 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-71-rTLGWIa7Mk20VPn43uRbaQ-1; Thu, 23 Jan 2020 08:52:09 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 87F5063AD9 for ; Thu, 23 Jan 2020 13:52:08 +0000 (UTC) Received: from 640k.localdomain.com (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80C4884DBD; Thu, 23 Jan 2020 13:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579787531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z5XFGQqk7sa0oFK95YMlOz0cT3ZBKnoL8H8zBBcszCI=; b=GJVXT4Akb7TdkbIoyv/GmCipGErG76ieJDOPAGGZnttSTEE8aK+AC5LUt4v7PhI8afd0MG crdZrSqsrwyA8rbPXYkEaQKBUrKzu9145VsMPol4ClkJ6x26NOkh1f5gs95opjFlP1I/rr 981HGOXYf3tSh5/yizsutqOmr4tHZHQ= From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 35/59] object: avoid extra class property key duplication Date: Thu, 23 Jan 2020 14:50:25 +0100 Message-Id: <1579787449-27599-36-git-send-email-pbonzini@redhat.com> In-Reply-To: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> References: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: rTLGWIa7Mk20VPn43uRbaQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau Like object properties, no need to duplicate property name, as it is owned already by ObjectProperty value. Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20200110153039.1379601-6-marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini --- qom/object.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index dcb6863..e921363 100644 --- a/qom/object.c +++ b/qom/object.c @@ -311,7 +311,7 @@ static void type_initialize(TypeImpl *ti) memcpy(ti->class, parent->class, parent->class_size); ti->class->interfaces =3D NULL; ti->class->properties =3D g_hash_table_new_full( - g_str_hash, g_str_equal, g_free, object_property_free); + g_str_hash, g_str_equal, NULL, object_property_free); =20 for (e =3D parent->class->interfaces; e; e =3D e->next) { InterfaceClass *iface =3D e->data; @@ -343,7 +343,7 @@ static void type_initialize(TypeImpl *ti) } } else { ti->class->properties =3D g_hash_table_new_full( - g_str_hash, g_str_equal, g_free, object_property_free); + g_str_hash, g_str_equal, NULL, object_property_free); } =20 ti->class->type =3D ti; @@ -1187,7 +1187,7 @@ object_class_property_add(ObjectClass *klass, prop->release =3D release; prop->opaque =3D opaque; =20 - g_hash_table_insert(klass->properties, g_strdup(name), prop); + g_hash_table_insert(klass->properties, prop->name, prop); =20 return prop; } --=20 1.8.3.1