From nobody Thu Nov 13 12:02:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579795893; cv=none; d=zohomail.com; s=zohoarc; b=KZ6dieeFcyDjO48Wk6v1GfDjLXnGQEnmDxpX4WyJGj7V3UtPI+dz7s8HZ5rNVOmHg57Eh7ne8Nq9cjU64csCqU00CDzre+z2vomF8B5CMbBtpdHAFRYzd3YKDR3dL2TuT7vSxlz6S2RrAHVrgXfPJjMag0oZY2tbgGo77TslHJ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579795893; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G8REenve+H9csiL1HWpoRTGpQ4KzlPih8bhh6X75GFo=; b=Igb4RLO0O8q6mjISUxNWhuytR14i82wc3WGtJdtBnOCVkzsyf0du7ZNjzU9FgaYP1faqt64lgyNFFcDpTL3P6h28j/PVOaeoLUDMNb6AU1vm00q4xUzpqaMR9XUW8kQj3VmHxGnxn7rnwyG/1G6on6x1+i1ooUVYqJFd219ca3s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579795893570415.9885770863077; Thu, 23 Jan 2020 08:11:33 -0800 (PST) Received: from localhost ([::1]:60096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuf4t-0005Tz-QH for importer@patchew.org; Thu, 23 Jan 2020 11:11:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52664) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuctm-0000Lc-1s for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuctk-0000EO-UQ for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:53 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:43025 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuctk-0000Ds-RO for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:52 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-idDYgpXRNXuOoE8XF_ngyA-1; Thu, 23 Jan 2020 08:51:51 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B246802CA2 for ; Thu, 23 Jan 2020 13:51:50 +0000 (UTC) Received: from 640k.localdomain.com (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F4B48575A; Thu, 23 Jan 2020 13:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579787512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G8REenve+H9csiL1HWpoRTGpQ4KzlPih8bhh6X75GFo=; b=jOhETPpjGEDDjxj5lTyPdiVhBgUbK8dTRHhP7w2oYajeDI4qjLjM/aEyEOeTgzez7DDR4k MQy4lu7qTa6+RAK0rM55tnHke3jDuclm+lxO3WitztZcTcvDn3YK6vLzeH+j+IcA7Vtus7 1lXai9D60gCZnADoaOi7pijJGx2YuHw= From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 27/59] qom/object: Display more helpful message when a parent is missing Date: Thu, 23 Jan 2020 14:50:17 +0100 Message-Id: <1579787449-27599-28-git-send-email-pbonzini@redhat.com> In-Reply-To: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> References: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: idDYgpXRNXuOoE8XF_ngyA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 QEMU object model is scarse in documentation. Some calls are recursive, and it might be hard to figure out even trivial issues. We can avoid developers to waste time in a debugging session by displaying a simple error message. This commit is also similar to e02bdf1cecd2 ("Display more helpful message when an object type is missing"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Cornelia Huck Message-Id: <20200121110349.25842-7-philmd@redhat.com> Signed-off-by: Paolo Bonzini --- qom/object.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 36123fb..90155fa 100644 --- a/qom/object.c +++ b/qom/object.c @@ -173,7 +173,11 @@ static TypeImpl *type_get_parent(TypeImpl *type) { if (!type->parent_type && type->parent) { type->parent_type =3D type_get_by_name(type->parent); - g_assert(type->parent_type !=3D NULL); + if (!type->parent_type) { + fprintf(stderr, "Type '%s' is missing its parent '%s'\n", + type->name, type->parent); + abort(); + } } =20 return type->parent_type; --=20 1.8.3.1