From nobody Thu Nov 13 12:01:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579795227; cv=none; d=zohomail.com; s=zohoarc; b=jxpVSjbp03W+/53Rb3VlpK3h/vktTjGGiz58iVJzd8QxV1XPAJUuAwiFDfjL9/Hu+M1r3X/WGtlSEQKBcA/DN9OIq6IllbQjp3I+MWqH9EGi7F4hO3r2F/op5hSC/FTgridDLBktkw87HGn+y0W+8ABxtG88365WSI8XwWTiLTU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579795227; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=V2G8YV9XujUycNNX3FwBpPbZJXJwPTP/v5pJ9UnyklM=; b=UK8tPVjI02zzchScVt61jSUNbJgqTTJMqXS0mMSfzE0aRRlt7/Eoju7QfAeOc6pZLpXJzp65ykKpNtbNDDIpRPcVhDFQVW3JUk+k/og8ciNz8B4VpsfSwaoTJKVjIeTKVIC1hiTWnqah8sEiU+yM70GpmasakQgb+0MceZ/bwcY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579795227604949.0450747743862; Thu, 23 Jan 2020 08:00:27 -0800 (PST) Received: from localhost ([::1]:59916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iueu9-0005vt-Ka for importer@patchew.org; Thu, 23 Jan 2020 11:00:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52328) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuct8-0007lM-Jb for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuct7-0006zQ-Ik for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:14 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:22894 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuct7-0006y5-Fy for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:51:13 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-373-bb6jBSu6M8SXJqpy01H5tg-1; Thu, 23 Jan 2020 08:51:11 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 02E408017CC for ; Thu, 23 Jan 2020 13:51:11 +0000 (UTC) Received: from 640k.localdomain.com (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id F35D61CB; Thu, 23 Jan 2020 13:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579787473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V2G8YV9XujUycNNX3FwBpPbZJXJwPTP/v5pJ9UnyklM=; b=ECC2d0Npy0Oh8FqgUyn9T5FvYaErf4MjcTO0C7BK45wfRUl1/Fe3c/G5OK+RUNTg9G9/Yv QOmFaRVD6zqhZLwThHXd8slrlZWacGQT1ec4iyWw9YJdqzArBTOHrlbEGT2coOTN5hdIef iNHrx95LxPeGUwnv1vzK/7zmIAG6bkI= From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 10/59] hw/net/imx_fec: Remove unuseful FALLTHROUGH comments Date: Thu, 23 Jan 2020 14:50:00 +0100 Message-Id: <1579787449-27599-11-git-send-email-pbonzini@redhat.com> In-Reply-To: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> References: <1579787449-27599-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: bb6jBSu6M8SXJqpy01H5tg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 We don't need to explicit these obvious switch fall through comments. Stay consistent with the rest of the codebase. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aleksandar Markovic Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-Id: <20191218192526.13845-6-philmd@redhat.com> Signed-off-by: Paolo Bonzini --- hw/net/imx_fec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index c01ce4f..5a83678 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -901,8 +901,8 @@ static void imx_eth_write(void *opaque, hwaddr offset, = uint64_t value, s->regs[index] =3D 0; } break; - case ENET_TDAR1: /* FALLTHROUGH */ - case ENET_TDAR2: /* FALLTHROUGH */ + case ENET_TDAR1: + case ENET_TDAR2: if (unlikely(single_tx_ring)) { qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: trying to access TDAR2 or TDAR1\n", --=20 1.8.3.1