hw/alpha/alpha_sys.h | 2 +- include/exec/cpu-common.h | 2 + include/hw/boards.h | 51 ++++---------- include/hw/misc/aspeed_sdmc.h | 2 + include/hw/ppc/ppc4xx.h | 9 ++- include/sysemu/hostmem.h | 20 +++++- include/sysemu/numa.h | 5 +- include/sysemu/sysemu.h | 2 - backends/hostmem-file.c | 8 --- backends/hostmem-memfd.c | 1 - backends/hostmem-ram.c | 2 - backends/hostmem.c | 53 ++++++++++---- exec.c | 66 ++--------------- hw/alpha/dp264.c | 2 +- hw/alpha/typhoon.c | 8 +-- hw/arm/aspeed.c | 13 +--- hw/arm/collie.c | 15 ++-- hw/arm/cubieboard.c | 25 +++---- hw/arm/digic_boards.c | 35 +++++---- hw/arm/highbank.c | 10 ++- hw/arm/imx25_pdk.c | 13 ++-- hw/arm/integratorcp.c | 9 ++- hw/arm/kzm.c | 13 ++-- hw/arm/mcimx6ul-evk.c | 25 +++---- hw/arm/mcimx7d-sabre.c | 25 +++---- hw/arm/mps2-tz.c | 13 ++-- hw/arm/mps2.c | 13 ++-- hw/arm/musicpal.c | 16 +++-- hw/arm/nseries.c | 31 ++++---- hw/arm/omap_sx1.c | 18 +++-- hw/arm/palm.c | 18 +++-- hw/arm/raspi.c | 32 +++------ hw/arm/sabrelite.c | 23 +++--- hw/arm/sbsa-ref.c | 7 +- hw/arm/versatilepb.c | 7 +- hw/arm/vexpress.c | 14 ++-- hw/arm/virt.c | 9 ++- hw/arm/xilinx_zynq.c | 20 +++--- hw/arm/xlnx-versal-virt.c | 7 +- hw/arm/xlnx-zcu102.c | 7 +- hw/core/machine.c | 37 ++++++++-- hw/core/null-machine.c | 7 +- hw/core/numa.c | 160 +++++++++--------------------------------- hw/cris/axis_dev88.c | 8 +-- hw/hppa/machine.c | 18 ++--- hw/i386/microvm.c | 12 ++-- hw/i386/pc.c | 20 +++--- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c | 2 +- hw/lm32/lm32_boards.c | 36 ++++++---- hw/lm32/milkymist.c | 19 +++-- hw/m68k/an5206.c | 5 +- hw/m68k/mcf5208.c | 5 +- hw/m68k/next-cube.c | 5 +- hw/mips/boston.c | 11 ++- hw/mips/mips_fulong2e.c | 15 ++-- hw/mips/mips_jazz.c | 7 +- hw/mips/mips_malta.c | 10 ++- hw/mips/mips_mipssim.c | 9 +-- hw/mips/mips_r4k.c | 12 ++-- hw/misc/aspeed_sdmc.c | 112 +++++++++++------------------ hw/ppc/e500.c | 17 +++-- hw/ppc/e500plat.c | 1 + hw/ppc/mac_newworld.c | 6 +- hw/ppc/mac_oldworld.c | 6 +- hw/ppc/mpc8544ds.c | 1 + hw/ppc/pnv.c | 8 +-- hw/ppc/ppc405_boards.c | 45 +++++++----- hw/ppc/ppc440_bamboo.c | 12 ++-- hw/ppc/ppc4xx_devs.c | 59 ++++++++-------- hw/ppc/prep.c | 15 ++-- hw/ppc/sam460ex.c | 6 +- hw/ppc/spapr.c | 17 ++--- hw/ppc/virtex_ml507.c | 18 ++--- hw/s390x/s390-virtio-ccw.c | 7 +- hw/sparc/leon3.c | 6 +- hw/sparc/sun4m.c | 73 ++++++++++--------- hw/sparc64/niagara.c | 7 +- qemu-deprecated.texi | 33 --------- qemu-options.hx | 20 +++--- tests/qtest/numa-test.c | 90 ++++++++++++++---------- vl.c | 37 +++++++++- 82 files changed, 727 insertions(+), 920 deletions(-)
v2: - fix compile errors on mingw32 host by introducing RAM_ADDR_UFMT [11/86] - replace "[PATCH 43/86] hppa: drop RAM size fixup" with alternative patches made by Philippe (which effectively do the same thing but other way around) - ppc440: fix crash and add suggested valid RAM size in error output. s/ppc4xx_sdram_adjust/ppc4xx_sdram_prep/ and simplify it by removing not necessary nested loop - rebase on current master due to new conflicts Series removes ad hoc RAM allocation API (memory_region_allocate_system_memory) and consolidates it around hostmem backend. It allows to * resolve conflicts between global -mem-prealloc and hostmem's "policy" option fixing premature allocation before binding policy is applied * simplify complicated memory allocation routines which had to deal with 2 ways to allocate RAM. * it allows to reuse hostmem backends of a choice for main RAM without adding extra CLI options to duplicate hostmem features. Recent case was -mem-shared, to enable vhost-user on targets that don't support hostmem backends [1] (ex: s390) * move RAM allocation from individual boards into generic machine code and provide them with prepared MemoryRegion. * clean up deprecated NUMA features which were tied to the old API (see patches) - "numa: remove deprecated -mem-path fallback to anonymous RAM" - "numa: remove deprecated implicit RAM distribution between nodes" - "forbid '-numa node,mem' for 5.0 and newer machine types" Conversion introduces a new machine.ram-memdev property and wrapper code that aliases global -mem-path and -mem-alloc into automatically created hostmem backend properties (provided ram-memdev was not set explicitly given by user). And then follows bulk of trivial patches that incrementally convert individual boards to using machine.ram-memdev provided MemoryRegion. Board conversion typically involves: * providing MachineClass::default_ram_size and MachineClass::default_ram_id so generic code could create default backend if user didn't explicitly provide ram-memdev or -m options * dropping memory_region_allocate_system_memory() call * using convenience MachineState::ram MemoryRegion, which points to MemoryRegion allocated by ram-memdev On top of that for some boards: * added missing ram_size checks (typically it were boards with fixed ram size) * ram_size fixups were replaced by checks and hard errors, forcing user to provide correct "-m" values instead of ignoring it and continuing running. After all boards are converted the old API is removed and memory allocation routines are cleaned up. git tree for testing: https://github.com/imammedo/qemu convert_main_ram_to_memdev_v2 previous rev: https://github.com/imammedo/qemu convert_main_ram_to_memdev_v2 https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05409.html Igor Mammedov (83): numa: remove deprecated -mem-path fallback to anonymous RAM machine: introduce ram-memdev property machine: alias -mem-path and -mem-prealloc into memory-foo backend machine: introduce convenience MachineState::ram initialize MachineState::ram in NUMA case alpha:dp264: use memdev for RAM arm:aspeed: convert valid RAM sizes to data arm:aspeed: actually check RAM size hw:aspeed: drop warning and bogus ram_size fixup arm:aspeed: use memdev for RAM arm:collie: use memdev for RAM arm:cubieboard: use memdev for RAM arm:digic_boards: use memdev for RAM arm:highbank: use memdev for RAM arm:imx25_pdk: drop RAM size fixup arm:imx25_pdk: use memdev for RAM arm:integratorcp: use memdev for RAM arm:kzm: drop RAM size fixup arm:kzm: use memdev for RAM arm:mcimx6ul-evk: use memdev for RAM arm:mcimx7d-sabre: use memdev for RAM arm:mps2-tz: use memdev for RAM arm:mps2: use memdev for RAM arm:musicpal: use memdev for RAM arm:nseries: use memdev for RAM arm:omap_sx1: use memdev for RAM arm:palm: use memdev for RAM arm:raspi: use memdev for RAM arm:sabrelite: use memdev for RAM arm:sbsa-ref: use memdev for RAM arm:versatilepb: use memdev for RAM arm:vexpress: use memdev for RAM arm:virt: use memdev for RAM arm:xilinx_zynq: drop RAM size fixup arm:xilinx_zynq: use memdev for RAM arm:xlnx-versal-virt: use memdev for RAM arm:xlnx-zcu102: use memdev for RAM s390x:s390-virtio-ccw: use memdev for RAM null-machine: use memdev for RAM cris:axis_dev88: use memdev for RAM hppa: use memdev for RAM x86:microvm: use memdev for RAM x86:pc: use memdev for RAM lm32:lm32_boards: use memdev for RAM lm32:milkymist: use memdev for RAM m68k:an5206: use memdev for RAM m68k:mcf5208: use memdev for RAM m68k:next-cube: use memdev for RAM mips:boston-cube: use memdev for RAM mips:mips_fulong2e: drop RAM size fixup mips:mips_fulong2e: use memdev for RAM mips:mips_jazz: use memdev for RAM mips:mips_malta: use memdev for RAM mips:mips_mipssim: use memdev for RAM mips:mips_r4k: use memdev for RAM ppc:e500: drop RAM size fixup ppc:e500: use memdev for RAM ppc:mac_newworld: use memdev for RAM ppc:mac_oldworld: use memdev for RAM ppc:pnv: use memdev for RAM ppc:ppc405_boards: add RAM size checks ppc:ppc405_boards: use memdev for RAM ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup ppc:ppc440_bamboo/sam460ex: use memdev for RAM ppc:prep: use memdev for RAM ppc:spapr: use memdev for RAM ppc:virtex_ml507: remove unused arguments ppc:virtex_ml507: use memdev for RAM sparc:leon3: use memdev for RAM sparc:sun4m: use memdev for RAM sparc:niagara: use memdev for RAM remove no longer used memory_region_allocate_system_memory() post conversion default_ram_id cleanup exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize() exec: drop bogus mem_path from qemu_ram_alloc_from_fd() make mem_path local variable hostmem: introduce "prealloc-threads" property hostmem: fix strict bind policy numa: forbid '-numa node,mem' for 5.0 and newer machine types tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups tests:numa-test: use explicit memdev to specify node RAM numa: make exit() usage consistent numa: remove deprecated implicit RAM distribution between nodes Philippe Mathieu-Daudé (3): hw/hppa/machine: Correctly check the firmware is in PDC range hw/hppa/machine: Restrict the total memory size to 3GB hw/hppa/machine: Map the PDC memory region with higher priority hw/alpha/alpha_sys.h | 2 +- include/exec/cpu-common.h | 2 + include/hw/boards.h | 51 ++++---------- include/hw/misc/aspeed_sdmc.h | 2 + include/hw/ppc/ppc4xx.h | 9 ++- include/sysemu/hostmem.h | 20 +++++- include/sysemu/numa.h | 5 +- include/sysemu/sysemu.h | 2 - backends/hostmem-file.c | 8 --- backends/hostmem-memfd.c | 1 - backends/hostmem-ram.c | 2 - backends/hostmem.c | 53 ++++++++++---- exec.c | 66 ++--------------- hw/alpha/dp264.c | 2 +- hw/alpha/typhoon.c | 8 +-- hw/arm/aspeed.c | 13 +--- hw/arm/collie.c | 15 ++-- hw/arm/cubieboard.c | 25 +++---- hw/arm/digic_boards.c | 35 +++++---- hw/arm/highbank.c | 10 ++- hw/arm/imx25_pdk.c | 13 ++-- hw/arm/integratorcp.c | 9 ++- hw/arm/kzm.c | 13 ++-- hw/arm/mcimx6ul-evk.c | 25 +++---- hw/arm/mcimx7d-sabre.c | 25 +++---- hw/arm/mps2-tz.c | 13 ++-- hw/arm/mps2.c | 13 ++-- hw/arm/musicpal.c | 16 +++-- hw/arm/nseries.c | 31 ++++---- hw/arm/omap_sx1.c | 18 +++-- hw/arm/palm.c | 18 +++-- hw/arm/raspi.c | 32 +++------ hw/arm/sabrelite.c | 23 +++--- hw/arm/sbsa-ref.c | 7 +- hw/arm/versatilepb.c | 7 +- hw/arm/vexpress.c | 14 ++-- hw/arm/virt.c | 9 ++- hw/arm/xilinx_zynq.c | 20 +++--- hw/arm/xlnx-versal-virt.c | 7 +- hw/arm/xlnx-zcu102.c | 7 +- hw/core/machine.c | 37 ++++++++-- hw/core/null-machine.c | 7 +- hw/core/numa.c | 160 +++++++++--------------------------------- hw/cris/axis_dev88.c | 8 +-- hw/hppa/machine.c | 18 ++--- hw/i386/microvm.c | 12 ++-- hw/i386/pc.c | 20 +++--- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c | 2 +- hw/lm32/lm32_boards.c | 36 ++++++---- hw/lm32/milkymist.c | 19 +++-- hw/m68k/an5206.c | 5 +- hw/m68k/mcf5208.c | 5 +- hw/m68k/next-cube.c | 5 +- hw/mips/boston.c | 11 ++- hw/mips/mips_fulong2e.c | 15 ++-- hw/mips/mips_jazz.c | 7 +- hw/mips/mips_malta.c | 10 ++- hw/mips/mips_mipssim.c | 9 +-- hw/mips/mips_r4k.c | 12 ++-- hw/misc/aspeed_sdmc.c | 112 +++++++++++------------------ hw/ppc/e500.c | 17 +++-- hw/ppc/e500plat.c | 1 + hw/ppc/mac_newworld.c | 6 +- hw/ppc/mac_oldworld.c | 6 +- hw/ppc/mpc8544ds.c | 1 + hw/ppc/pnv.c | 8 +-- hw/ppc/ppc405_boards.c | 45 +++++++----- hw/ppc/ppc440_bamboo.c | 12 ++-- hw/ppc/ppc4xx_devs.c | 59 ++++++++-------- hw/ppc/prep.c | 15 ++-- hw/ppc/sam460ex.c | 6 +- hw/ppc/spapr.c | 17 ++--- hw/ppc/virtex_ml507.c | 18 ++--- hw/s390x/s390-virtio-ccw.c | 7 +- hw/sparc/leon3.c | 6 +- hw/sparc/sun4m.c | 73 ++++++++++--------- hw/sparc64/niagara.c | 7 +- qemu-deprecated.texi | 33 --------- qemu-options.hx | 20 +++--- tests/qtest/numa-test.c | 90 ++++++++++++++---------- vl.c | 37 +++++++++- 82 files changed, 727 insertions(+), 920 deletions(-) -- 2.7.4
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend Type: series Message-id: 1579100861-73692-1-git-send-email-imammedo@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 2d14010 numa: remove deprecated implicit RAM distribution between nodes bac70b8 numa: make exit() usage consistent 53861b0 tests:numa-test: use explicit memdev to specify node RAM 56297b3 tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups 3e6445f numa: forbid '-numa node, mem' for 5.0 and newer machine types d70a9f2 hostmem: fix strict bind policy 92d7974 hostmem: introduce "prealloc-threads" property 4fd9cfe make mem_path local variable 74d0083 exec: drop bogus mem_path from qemu_ram_alloc_from_fd() afb329b exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize() 7dfb5ed post conversion default_ram_id cleanup f7cb074 remove no longer used memory_region_allocate_system_memory() 738f1a3 sparc:niagara: use memdev for RAM e120e67 sparc:sun4m: use memdev for RAM 24b259e sparc:leon3: use memdev for RAM 4904e75 ppc:virtex_ml507: use memdev for RAM 65dbc2c ppc:virtex_ml507: remove unused arguments ab63a98 ppc:spapr: use memdev for RAM b4d5ea5 ppc:prep: use memdev for RAM 036f996 ppc:ppc440_bamboo/sam460ex: use memdev for RAM 73d3d69 ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup 4525782 ppc:ppc405_boards: use memdev for RAM 53365b4 ppc:ppc405_boards: add RAM size checks f025b4f ppc:pnv: use memdev for RAM 0329900 ppc:mac_oldworld: use memdev for RAM 92fb2bc ppc:mac_newworld: use memdev for RAM eaab307 ppc:e500: use memdev for RAM 5bc78d1 ppc:e500: drop RAM size fixup b959a8d mips:mips_r4k: use memdev for RAM 4fa91f4 mips:mips_mipssim: use memdev for RAM f726ba3 mips:mips_malta: use memdev for RAM e50c092 mips:mips_jazz: use memdev for RAM d9a07ca mips:mips_fulong2e: use memdev for RAM 05d6a5e mips:mips_fulong2e: drop RAM size fixup 73027e0 mips:boston-cube: use memdev for RAM eb6e93f m68k:next-cube: use memdev for RAM 3ad54a8 m68k:mcf5208: use memdev for RAM 31b4fbd m68k:an5206: use memdev for RAM 17a90ad lm32:milkymist: use memdev for RAM 934be97 lm32:lm32_boards: use memdev for RAM debb3a4 x86:pc: use memdev for RAM 64a0031 x86:microvm: use memdev for RAM c14b753 hppa: use memdev for RAM 9838169 hw/hppa/machine: Map the PDC memory region with higher priority 329d37d hw/hppa/machine: Restrict the total memory size to 3GB 82196f2 hw/hppa/machine: Correctly check the firmware is in PDC range 18f08804 cris:axis_dev88: use memdev for RAM 420420e null-machine: use memdev for RAM fab1efc s390x:s390-virtio-ccw: use memdev for RAM cb1a184 arm:xlnx-zcu102: use memdev for RAM dafc5fe arm:xlnx-versal-virt: use memdev for RAM 8939184 arm:xilinx_zynq: use memdev for RAM 64008ac arm:xilinx_zynq: drop RAM size fixup edc3824 arm:virt: use memdev for RAM 9c8ff93 arm:vexpress: use memdev for RAM 9f032bc arm:versatilepb: use memdev for RAM 03de308 arm:sbsa-ref: use memdev for RAM bc94738 arm:sabrelite: use memdev for RAM af2175c arm:raspi: use memdev for RAM 1943756 arm:palm: use memdev for RAM b329f68 arm:omap_sx1: use memdev for RAM 04a9490 arm:nseries: use memdev for RAM 7769298 arm:musicpal: use memdev for RAM 6d13cec arm:mps2: use memdev for RAM e0e52ec arm:mps2-tz: use memdev for RAM d9daba7 arm:mcimx7d-sabre: use memdev for RAM a701677 arm:mcimx6ul-evk: use memdev for RAM b3879f1 arm:kzm: use memdev for RAM 91d718e arm:kzm: drop RAM size fixup 18d4ce5 arm:integratorcp: use memdev for RAM a396753 arm:imx25_pdk: use memdev for RAM 77e06e0 arm:imx25_pdk: drop RAM size fixup f404c60 arm:highbank: use memdev for RAM c60b4f9 arm:digic_boards: use memdev for RAM deb657f arm:cubieboard: use memdev for RAM be1ddd2 arm:collie: use memdev for RAM fca3baa arm:aspeed: use memdev for RAM 99a74b3 hw:aspeed: drop warning and bogus ram_size fixup f2ccbf8 arm:aspeed: actually check RAM size 0fd04a9 arm:aspeed: convert valid RAM sizes to data 06f609f alpha:dp264: use memdev for RAM 40a1eec initialize MachineState::ram in NUMA case 9ef003b machine: introduce convenience MachineState::ram 16ac6d5 machine: alias -mem-path and -mem-prealloc into memory-foo backend 3026057 machine: introduce ram-memdev property 58ea704 numa: remove deprecated -mem-path fallback to anonymous RAM === OUTPUT BEGIN === 1/86 Checking commit 58ea704ecde0 (numa: remove deprecated -mem-path fallback to anonymous RAM) 2/86 Checking commit 3026057508a7 (machine: introduce ram-memdev property) 3/86 Checking commit 16ac6d5dfca0 (machine: alias -mem-path and -mem-prealloc into memory-foo backend) 4/86 Checking commit 9ef003bf86b0 (machine: introduce convenience MachineState::ram) 5/86 Checking commit 40a1eec31617 (initialize MachineState::ram in NUMA case) 6/86 Checking commit 06f609f99e7f (alpha:dp264: use memdev for RAM) ERROR: spaces required around that '*' (ctx:WxV) #30: FILE: hw/alpha/alpha_sys.h:14: +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4], ^ total: 1 errors, 0 warnings, 49 lines checked Patch 6/86 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/86 Checking commit 0fd04a92fedc (arm:aspeed: convert valid RAM sizes to data) 8/86 Checking commit f2ccbf8db44d (arm:aspeed: actually check RAM size) 9/86 Checking commit 99a74b3ee938 (hw:aspeed: drop warning and bogus ram_size fixup) 10/86 Checking commit fca3baaab72b (arm:aspeed: use memdev for RAM) 11/86 Checking commit be1ddd2cd5f5 (arm:collie: use memdev for RAM) 12/86 Checking commit deb657fd5ee9 (arm:cubieboard: use memdev for RAM) 13/86 Checking commit c60b4f9d6cd2 (arm:digic_boards: use memdev for RAM) 14/86 Checking commit f404c60b1167 (arm:highbank: use memdev for RAM) 15/86 Checking commit 77e06e009693 (arm:imx25_pdk: drop RAM size fixup) 16/86 Checking commit a396753185ed (arm:imx25_pdk: use memdev for RAM) 17/86 Checking commit 18d4ce56967b (arm:integratorcp: use memdev for RAM) 18/86 Checking commit 91d718e5a482 (arm:kzm: drop RAM size fixup) 19/86 Checking commit b3879f1c1c31 (arm:kzm: use memdev for RAM) 20/86 Checking commit a701677008f3 (arm:mcimx6ul-evk: use memdev for RAM) 21/86 Checking commit d9daba789ed4 (arm:mcimx7d-sabre: use memdev for RAM) 22/86 Checking commit e0e52ecc43a7 (arm:mps2-tz: use memdev for RAM) 23/86 Checking commit 6d13cec0d94c (arm:mps2: use memdev for RAM) 24/86 Checking commit 77692988c319 (arm:musicpal: use memdev for RAM) 25/86 Checking commit 04a94904d1c1 (arm:nseries: use memdev for RAM) 26/86 Checking commit b329f683db50 (arm:omap_sx1: use memdev for RAM) 27/86 Checking commit 19437567583f (arm:palm: use memdev for RAM) 28/86 Checking commit af2175c080a5 (arm:raspi: use memdev for RAM) 29/86 Checking commit bc947389baf6 (arm:sabrelite: use memdev for RAM) 30/86 Checking commit 03de30800363 (arm:sbsa-ref: use memdev for RAM) 31/86 Checking commit 9f032bcc0136 (arm:versatilepb: use memdev for RAM) 32/86 Checking commit 9c8ff937f348 (arm:vexpress: use memdev for RAM) 33/86 Checking commit edc382449643 (arm:virt: use memdev for RAM) 34/86 Checking commit 64008acd6753 (arm:xilinx_zynq: drop RAM size fixup) 35/86 Checking commit 8939184e5a43 (arm:xilinx_zynq: use memdev for RAM) 36/86 Checking commit dafc5feec590 (arm:xlnx-versal-virt: use memdev for RAM) 37/86 Checking commit cb1a184d0d59 (arm:xlnx-zcu102: use memdev for RAM) 38/86 Checking commit fab1efc6394f (s390x:s390-virtio-ccw: use memdev for RAM) 39/86 Checking commit 420420e49f1c (null-machine: use memdev for RAM) 40/86 Checking commit 18f08804dee9 (cris:axis_dev88: use memdev for RAM) 41/86 Checking commit 82196f232d2f (hw/hppa/machine: Correctly check the firmware is in PDC range) 42/86 Checking commit 329d37dd2228 (hw/hppa/machine: Restrict the total memory size to 3GB) 43/86 Checking commit 98381695ee75 (hw/hppa/machine: Map the PDC memory region with higher priority) 44/86 Checking commit c14b75322640 (hppa: use memdev for RAM) 45/86 Checking commit 64a0031a7bad (x86:microvm: use memdev for RAM) 46/86 Checking commit debb3a43be01 (x86:pc: use memdev for RAM) 47/86 Checking commit 934be970aa9a (lm32:lm32_boards: use memdev for RAM) 48/86 Checking commit 17a90ad29627 (lm32:milkymist: use memdev for RAM) 49/86 Checking commit 31b4fbd90a84 (m68k:an5206: use memdev for RAM) 50/86 Checking commit 3ad54a87de75 (m68k:mcf5208: use memdev for RAM) 51/86 Checking commit eb6e93f3e88b (m68k:next-cube: use memdev for RAM) 52/86 Checking commit 73027e0d5845 (mips:boston-cube: use memdev for RAM) 53/86 Checking commit 05d6a5e8846c (mips:mips_fulong2e: drop RAM size fixup) 54/86 Checking commit d9a07ca1579d (mips:mips_fulong2e: use memdev for RAM) 55/86 Checking commit e50c092c974f (mips:mips_jazz: use memdev for RAM) 56/86 Checking commit f726ba38fe1f (mips:mips_malta: use memdev for RAM) 57/86 Checking commit 4fa91f449f97 (mips:mips_mipssim: use memdev for RAM) 58/86 Checking commit b959a8d62bde (mips:mips_r4k: use memdev for RAM) 59/86 Checking commit 5bc78d153004 (ppc:e500: drop RAM size fixup) 60/86 Checking commit eaab307ef25b (ppc:e500: use memdev for RAM) 61/86 Checking commit 92fb2bc7ec58 (ppc:mac_newworld: use memdev for RAM) 62/86 Checking commit 03299009858f (ppc:mac_oldworld: use memdev for RAM) 63/86 Checking commit f025b4fa1ed0 (ppc:pnv: use memdev for RAM) 64/86 Checking commit 53365b477d95 (ppc:ppc405_boards: add RAM size checks) 65/86 Checking commit 452578232871 (ppc:ppc405_boards: use memdev for RAM) 66/86 Checking commit 73d3d6916582 (ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup) 67/86 Checking commit 036f996aa26f (ppc:ppc440_bamboo/sam460ex: use memdev for RAM) 68/86 Checking commit b4d5ea58deba (ppc:prep: use memdev for RAM) 69/86 Checking commit ab63a98c1459 (ppc:spapr: use memdev for RAM) 70/86 Checking commit 65dbc2c76e20 (ppc:virtex_ml507: remove unused arguments) 71/86 Checking commit 4904e75da051 (ppc:virtex_ml507: use memdev for RAM) 72/86 Checking commit 24b259e879cf (sparc:leon3: use memdev for RAM) 73/86 Checking commit e120e6728b65 (sparc:sun4m: use memdev for RAM) 74/86 Checking commit 738f1a334ba2 (sparc:niagara: use memdev for RAM) 75/86 Checking commit f7cb0749de91 (remove no longer used memory_region_allocate_system_memory()) 76/86 Checking commit 7dfb5ede2cbe (post conversion default_ram_id cleanup) 77/86 Checking commit afb329be6ce1 (exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()) 78/86 Checking commit 74d0083098a9 (exec: drop bogus mem_path from qemu_ram_alloc_from_fd()) 79/86 Checking commit 4fd9cfe4fef6 (make mem_path local variable) 80/86 Checking commit 92d79746afa0 (hostmem: introduce "prealloc-threads" property) 81/86 Checking commit d70a9f290f8b (hostmem: fix strict bind policy) 82/86 Checking commit 3e6445f81e47 (numa: forbid '-numa node, mem' for 5.0 and newer machine types) 83/86 Checking commit 56297b3d07ef (tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups) 84/86 Checking commit 53861b0c262a (tests:numa-test: use explicit memdev to specify node RAM) 85/86 Checking commit bac70b89e82c (numa: make exit() usage consistent) 86/86 Checking commit 2d14010cf86c (numa: remove deprecated implicit RAM distribution between nodes) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END === TEST iotest-qcow2: 217 socket_accept failed: Resource temporarily unavailable ** ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) /tmp/qemu-test/src/tests/qtest/libqtest.c:140: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) make: *** [check-qtest-x86_64] Error 1 make: *** Waiting for unfinished jobs.... TEST check-qtest-aarch64: tests/qtest/test-hmp TEST iotest-qcow2: 220 --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=12c9dd935934490eafad943ba0236226', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-r7by0ks3/src/docker-src.2020-01-15-11.30.32.23980:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=12c9dd935934490eafad943ba0236226 make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-r7by0ks3/src' make: *** [docker-run-test-quick@centos7] Error 2 real 12m1.521s user 0m8.822s The full log is available at http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END === TEST iotest-qcow2: 217 socket_accept failed: Resource temporarily unavailable ** ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) /tmp/qemu-test/src/tests/qtest/libqtest.c:140: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) make: *** [check-qtest-x86_64] Error 1 make: *** Waiting for unfinished jobs.... TEST check-qtest-aarch64: tests/qtest/test-hmp TEST check-qtest-aarch64: tests/qtest/qos-test --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=aa025f08c88c41f3b0736fd7ac33b1a2', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-jbjm9w29/src/docker-src.2020-01-15-13.02.21.6647:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=aa025f08c88c41f3b0736fd7ac33b1a2 make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-jbjm9w29/src' make: *** [docker-run-test-quick@centos7] Error 2 real 11m57.320s user 0m8.844s The full log is available at http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend Type: series Message-id: 1579100861-73692-1-git-send-email-imammedo@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 0b4d672 numa: remove deprecated implicit RAM distribution between nodes 1098011 numa: make exit() usage consistent 02b386f tests:numa-test: use explicit memdev to specify node RAM 66a2225 tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups b20b2ff numa: forbid '-numa node, mem' for 5.0 and newer machine types a13aa68 hostmem: fix strict bind policy 83a7d87 hostmem: introduce "prealloc-threads" property 7257d12 make mem_path local variable 04d4c6f exec: drop bogus mem_path from qemu_ram_alloc_from_fd() eb6daec exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize() 07bfbd9 post conversion default_ram_id cleanup c0bf61f remove no longer used memory_region_allocate_system_memory() a912f8b sparc:niagara: use memdev for RAM b744bcd sparc:sun4m: use memdev for RAM 49ea0ec sparc:leon3: use memdev for RAM 0c356f0 ppc:virtex_ml507: use memdev for RAM f361e08 ppc:virtex_ml507: remove unused arguments 3523e7b ppc:spapr: use memdev for RAM 7df88ce ppc:prep: use memdev for RAM 3158bcf ppc:ppc440_bamboo/sam460ex: use memdev for RAM c05ab6d ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup 71deb34 ppc:ppc405_boards: use memdev for RAM 04b505db ppc:ppc405_boards: add RAM size checks dffbdde ppc:pnv: use memdev for RAM 02936f7 ppc:mac_oldworld: use memdev for RAM 181345a ppc:mac_newworld: use memdev for RAM 5810983 ppc:e500: use memdev for RAM 2753e72 ppc:e500: drop RAM size fixup b2ec371 mips:mips_r4k: use memdev for RAM beb034d mips:mips_mipssim: use memdev for RAM 608d78b mips:mips_malta: use memdev for RAM b823794 mips:mips_jazz: use memdev for RAM 8916374 mips:mips_fulong2e: use memdev for RAM d4a34dc mips:mips_fulong2e: drop RAM size fixup 151530e mips:boston-cube: use memdev for RAM 6e84bad m68k:next-cube: use memdev for RAM 00daf85 m68k:mcf5208: use memdev for RAM 61d3597 m68k:an5206: use memdev for RAM ff9accd lm32:milkymist: use memdev for RAM 4d05cc4 lm32:lm32_boards: use memdev for RAM 96ef68d x86:pc: use memdev for RAM ccb281c x86:microvm: use memdev for RAM de745ce hppa: use memdev for RAM 81d7bb5 hw/hppa/machine: Map the PDC memory region with higher priority 0172fe7 hw/hppa/machine: Restrict the total memory size to 3GB ec0c2c2 hw/hppa/machine: Correctly check the firmware is in PDC range 79d6742 cris:axis_dev88: use memdev for RAM 4a1b6a3 null-machine: use memdev for RAM df8c7b3 s390x:s390-virtio-ccw: use memdev for RAM 8b28fb8 arm:xlnx-zcu102: use memdev for RAM bcf19b6 arm:xlnx-versal-virt: use memdev for RAM a0e14c0 arm:xilinx_zynq: use memdev for RAM 7aacf46 arm:xilinx_zynq: drop RAM size fixup 58602f5 arm:virt: use memdev for RAM 6fb0d33 arm:vexpress: use memdev for RAM 9a6e064 arm:versatilepb: use memdev for RAM d365f71 arm:sbsa-ref: use memdev for RAM 623e61c arm:sabrelite: use memdev for RAM 3382b3b arm:raspi: use memdev for RAM 46a5bef arm:palm: use memdev for RAM 50bef2a arm:omap_sx1: use memdev for RAM edba4fc arm:nseries: use memdev for RAM 1e880cb arm:musicpal: use memdev for RAM 500bdb0 arm:mps2: use memdev for RAM 26f6109 arm:mps2-tz: use memdev for RAM 3115479 arm:mcimx7d-sabre: use memdev for RAM 5ae9d66 arm:mcimx6ul-evk: use memdev for RAM f60a931 arm:kzm: use memdev for RAM 5caf28a arm:kzm: drop RAM size fixup bbce546 arm:integratorcp: use memdev for RAM f6cd712 arm:imx25_pdk: use memdev for RAM 31d092e arm:imx25_pdk: drop RAM size fixup 2c1e1fc arm:highbank: use memdev for RAM 21c0ab0 arm:digic_boards: use memdev for RAM e1e35dd arm:cubieboard: use memdev for RAM c218c33 arm:collie: use memdev for RAM f07ceb1 arm:aspeed: use memdev for RAM bdb5ad7 hw:aspeed: drop warning and bogus ram_size fixup 667a1a9 arm:aspeed: actually check RAM size ff498af arm:aspeed: convert valid RAM sizes to data ab2a965 alpha:dp264: use memdev for RAM 4836a67 initialize MachineState::ram in NUMA case e3fce82 machine: introduce convenience MachineState::ram f29549f machine: alias -mem-path and -mem-prealloc into memory-foo backend 78d829c machine: introduce ram-memdev property aa1fc16 numa: remove deprecated -mem-path fallback to anonymous RAM === OUTPUT BEGIN === 1/86 Checking commit aa1fc16b0c38 (numa: remove deprecated -mem-path fallback to anonymous RAM) 2/86 Checking commit 78d829c16792 (machine: introduce ram-memdev property) 3/86 Checking commit f29549fc3446 (machine: alias -mem-path and -mem-prealloc into memory-foo backend) 4/86 Checking commit e3fce82f8b0a (machine: introduce convenience MachineState::ram) 5/86 Checking commit 4836a67b492c (initialize MachineState::ram in NUMA case) 6/86 Checking commit ab2a965aecf2 (alpha:dp264: use memdev for RAM) ERROR: spaces required around that '*' (ctx:WxV) #30: FILE: hw/alpha/alpha_sys.h:14: +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4], ^ total: 1 errors, 0 warnings, 49 lines checked Patch 6/86 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/86 Checking commit ff498afe2397 (arm:aspeed: convert valid RAM sizes to data) 8/86 Checking commit 667a1a9689eb (arm:aspeed: actually check RAM size) 9/86 Checking commit bdb5ad7c6690 (hw:aspeed: drop warning and bogus ram_size fixup) 10/86 Checking commit f07ceb15e3d0 (arm:aspeed: use memdev for RAM) 11/86 Checking commit c218c33c2c1d (arm:collie: use memdev for RAM) 12/86 Checking commit e1e35dddfd68 (arm:cubieboard: use memdev for RAM) 13/86 Checking commit 21c0ab02cca0 (arm:digic_boards: use memdev for RAM) 14/86 Checking commit 2c1e1fc73e44 (arm:highbank: use memdev for RAM) 15/86 Checking commit 31d092e263da (arm:imx25_pdk: drop RAM size fixup) 16/86 Checking commit f6cd7125515e (arm:imx25_pdk: use memdev for RAM) 17/86 Checking commit bbce54683de4 (arm:integratorcp: use memdev for RAM) 18/86 Checking commit 5caf28a157a9 (arm:kzm: drop RAM size fixup) 19/86 Checking commit f60a9311a03d (arm:kzm: use memdev for RAM) 20/86 Checking commit 5ae9d66de2cd (arm:mcimx6ul-evk: use memdev for RAM) 21/86 Checking commit 3115479701b8 (arm:mcimx7d-sabre: use memdev for RAM) 22/86 Checking commit 26f610919991 (arm:mps2-tz: use memdev for RAM) 23/86 Checking commit 500bdb012a0c (arm:mps2: use memdev for RAM) 24/86 Checking commit 1e880cb6ed27 (arm:musicpal: use memdev for RAM) 25/86 Checking commit edba4fc51907 (arm:nseries: use memdev for RAM) 26/86 Checking commit 50bef2a1ff8b (arm:omap_sx1: use memdev for RAM) 27/86 Checking commit 46a5bef0b355 (arm:palm: use memdev for RAM) 28/86 Checking commit 3382b3ba4f8f (arm:raspi: use memdev for RAM) 29/86 Checking commit 623e61c61ef1 (arm:sabrelite: use memdev for RAM) 30/86 Checking commit d365f71e6f61 (arm:sbsa-ref: use memdev for RAM) 31/86 Checking commit 9a6e0641e7de (arm:versatilepb: use memdev for RAM) 32/86 Checking commit 6fb0d331c71f (arm:vexpress: use memdev for RAM) 33/86 Checking commit 58602f5a313d (arm:virt: use memdev for RAM) 34/86 Checking commit 7aacf4698262 (arm:xilinx_zynq: drop RAM size fixup) 35/86 Checking commit a0e14c032a21 (arm:xilinx_zynq: use memdev for RAM) 36/86 Checking commit bcf19b6579a4 (arm:xlnx-versal-virt: use memdev for RAM) 37/86 Checking commit 8b28fb8cdc7c (arm:xlnx-zcu102: use memdev for RAM) 38/86 Checking commit df8c7b3d1caa (s390x:s390-virtio-ccw: use memdev for RAM) 39/86 Checking commit 4a1b6a36ff0b (null-machine: use memdev for RAM) 40/86 Checking commit 79d6742c68f7 (cris:axis_dev88: use memdev for RAM) 41/86 Checking commit ec0c2c299493 (hw/hppa/machine: Correctly check the firmware is in PDC range) 42/86 Checking commit 0172fe7158ea (hw/hppa/machine: Restrict the total memory size to 3GB) 43/86 Checking commit 81d7bb57c125 (hw/hppa/machine: Map the PDC memory region with higher priority) 44/86 Checking commit de745cef12ed (hppa: use memdev for RAM) 45/86 Checking commit ccb281ca428b (x86:microvm: use memdev for RAM) 46/86 Checking commit 96ef68dbcb5d (x86:pc: use memdev for RAM) 47/86 Checking commit 4d05cc4b128a (lm32:lm32_boards: use memdev for RAM) 48/86 Checking commit ff9accd82e74 (lm32:milkymist: use memdev for RAM) 49/86 Checking commit 61d3597a9224 (m68k:an5206: use memdev for RAM) 50/86 Checking commit 00daf85e44af (m68k:mcf5208: use memdev for RAM) 51/86 Checking commit 6e84bad3fba6 (m68k:next-cube: use memdev for RAM) 52/86 Checking commit 151530ecb6a0 (mips:boston-cube: use memdev for RAM) 53/86 Checking commit d4a34dcb1a7f (mips:mips_fulong2e: drop RAM size fixup) 54/86 Checking commit 891637498130 (mips:mips_fulong2e: use memdev for RAM) 55/86 Checking commit b823794fa4db (mips:mips_jazz: use memdev for RAM) 56/86 Checking commit 608d78bdb560 (mips:mips_malta: use memdev for RAM) 57/86 Checking commit beb034d464c7 (mips:mips_mipssim: use memdev for RAM) 58/86 Checking commit b2ec371658a2 (mips:mips_r4k: use memdev for RAM) 59/86 Checking commit 2753e7251dbf (ppc:e500: drop RAM size fixup) 60/86 Checking commit 5810983e05d9 (ppc:e500: use memdev for RAM) 61/86 Checking commit 181345a14032 (ppc:mac_newworld: use memdev for RAM) 62/86 Checking commit 02936f711900 (ppc:mac_oldworld: use memdev for RAM) 63/86 Checking commit dffbddec7484 (ppc:pnv: use memdev for RAM) 64/86 Checking commit 04b505db53c6 (ppc:ppc405_boards: add RAM size checks) 65/86 Checking commit 71deb34da16d (ppc:ppc405_boards: use memdev for RAM) 66/86 Checking commit c05ab6dbc400 (ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup) 67/86 Checking commit 3158bcf2a286 (ppc:ppc440_bamboo/sam460ex: use memdev for RAM) 68/86 Checking commit 7df88cedb210 (ppc:prep: use memdev for RAM) 69/86 Checking commit 3523e7ba15a3 (ppc:spapr: use memdev for RAM) 70/86 Checking commit f361e0899be6 (ppc:virtex_ml507: remove unused arguments) 71/86 Checking commit 0c356f0f4c22 (ppc:virtex_ml507: use memdev for RAM) 72/86 Checking commit 49ea0ecbeecb (sparc:leon3: use memdev for RAM) 73/86 Checking commit b744bcd27695 (sparc:sun4m: use memdev for RAM) 74/86 Checking commit a912f8bc8c61 (sparc:niagara: use memdev for RAM) 75/86 Checking commit c0bf61f45183 (remove no longer used memory_region_allocate_system_memory()) 76/86 Checking commit 07bfbd96c08c (post conversion default_ram_id cleanup) 77/86 Checking commit eb6daec88a8a (exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()) 78/86 Checking commit 04d4c6faaca2 (exec: drop bogus mem_path from qemu_ram_alloc_from_fd()) 79/86 Checking commit 7257d1263a5d (make mem_path local variable) 80/86 Checking commit 83a7d87c1fce (hostmem: introduce "prealloc-threads" property) 81/86 Checking commit a13aa6825527 (hostmem: fix strict bind policy) 82/86 Checking commit b20b2ff4cdac (numa: forbid '-numa node, mem' for 5.0 and newer machine types) 83/86 Checking commit 66a22250b5c1 (tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups) 84/86 Checking commit 02b386f71ab9 (tests:numa-test: use explicit memdev to specify node RAM) 85/86 Checking commit 1098011efcda (numa: make exit() usage consistent) 86/86 Checking commit 0b4d672f1b99 (numa: remove deprecated implicit RAM distribution between nodes) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END === TEST iotest-qcow2: 184 socket_accept failed: Resource temporarily unavailable ** ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) /tmp/qemu-test/src/tests/qtest/libqtest.c:140: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) TEST iotest-qcow2: 186 make: *** [check-qtest-x86_64] Error 1 make: *** Waiting for unfinished jobs.... TEST iotest-qcow2: 187 TEST iotest-qcow2: 190 --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=22666b33f869455386111b839b4d494c', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-2tanos8_/src/docker-src.2020-01-15-14.28.46.4844:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=22666b33f869455386111b839b4d494c make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-2tanos8_/src' make: *** [docker-run-test-quick@centos7] Error 2 real 10m47.563s user 0m8.283s The full log is available at http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend Type: series Message-id: 1579100861-73692-1-git-send-email-imammedo@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 11a20c3 numa: remove deprecated implicit RAM distribution between nodes d86b08b numa: make exit() usage consistent 8646e5e tests:numa-test: use explicit memdev to specify node RAM e73639d tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups 22e8003 numa: forbid '-numa node, mem' for 5.0 and newer machine types 4636732 hostmem: fix strict bind policy 547e119 hostmem: introduce "prealloc-threads" property 37e2c24 make mem_path local variable 3f12da2 exec: drop bogus mem_path from qemu_ram_alloc_from_fd() 82d8312 exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize() fad9d83 post conversion default_ram_id cleanup dba7fdb remove no longer used memory_region_allocate_system_memory() b3cee01 sparc:niagara: use memdev for RAM 193cdb5 sparc:sun4m: use memdev for RAM 7b57adc sparc:leon3: use memdev for RAM 1b43407 ppc:virtex_ml507: use memdev for RAM d151f5a ppc:virtex_ml507: remove unused arguments 9696d27 ppc:spapr: use memdev for RAM 42503a2 ppc:prep: use memdev for RAM 07bab1c ppc:ppc440_bamboo/sam460ex: use memdev for RAM 78dacf7 ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup c946d56 ppc:ppc405_boards: use memdev for RAM 90799d8 ppc:ppc405_boards: add RAM size checks 95965c8 ppc:pnv: use memdev for RAM 8794a61 ppc:mac_oldworld: use memdev for RAM 803a239 ppc:mac_newworld: use memdev for RAM de3715d ppc:e500: use memdev for RAM aa12e5f ppc:e500: drop RAM size fixup 05ef318 mips:mips_r4k: use memdev for RAM 0577baa mips:mips_mipssim: use memdev for RAM a1226bd mips:mips_malta: use memdev for RAM f059e6d mips:mips_jazz: use memdev for RAM 9fde8b0 mips:mips_fulong2e: use memdev for RAM 974b1c0 mips:mips_fulong2e: drop RAM size fixup 6f147f5 mips:boston-cube: use memdev for RAM f97cebd m68k:next-cube: use memdev for RAM aa9050c m68k:mcf5208: use memdev for RAM 2e37399 m68k:an5206: use memdev for RAM 7471a18 lm32:milkymist: use memdev for RAM 06d3b1b lm32:lm32_boards: use memdev for RAM b72206f x86:pc: use memdev for RAM f0ed8ae x86:microvm: use memdev for RAM 56cec52 hppa: use memdev for RAM dad8af3 hw/hppa/machine: Map the PDC memory region with higher priority 14d9db7 hw/hppa/machine: Restrict the total memory size to 3GB 8bb59b8 hw/hppa/machine: Correctly check the firmware is in PDC range f66c661 cris:axis_dev88: use memdev for RAM 30ec2c7 null-machine: use memdev for RAM eca7ad3 s390x:s390-virtio-ccw: use memdev for RAM 9efacaa arm:xlnx-zcu102: use memdev for RAM 6c17f5e arm:xlnx-versal-virt: use memdev for RAM c974680 arm:xilinx_zynq: use memdev for RAM 5214578 arm:xilinx_zynq: drop RAM size fixup 487a287 arm:virt: use memdev for RAM f59a421 arm:vexpress: use memdev for RAM 5f18495 arm:versatilepb: use memdev for RAM 4ef5f91 arm:sbsa-ref: use memdev for RAM e67a909 arm:sabrelite: use memdev for RAM 8b211a1 arm:raspi: use memdev for RAM c2fe517 arm:palm: use memdev for RAM 59fa4ec arm:omap_sx1: use memdev for RAM 54372f1 arm:nseries: use memdev for RAM a460240 arm:musicpal: use memdev for RAM 00a31d8 arm:mps2: use memdev for RAM 6384dde arm:mps2-tz: use memdev for RAM d675a78 arm:mcimx7d-sabre: use memdev for RAM a5d1f43 arm:mcimx6ul-evk: use memdev for RAM e5d7dc1 arm:kzm: use memdev for RAM c3cc180 arm:kzm: drop RAM size fixup f843b3e arm:integratorcp: use memdev for RAM 4dee2dc arm:imx25_pdk: use memdev for RAM c794dcf arm:imx25_pdk: drop RAM size fixup 999f220 arm:highbank: use memdev for RAM 91d80f4 arm:digic_boards: use memdev for RAM aab50b1 arm:cubieboard: use memdev for RAM 8d954fe arm:collie: use memdev for RAM 7b0d326 arm:aspeed: use memdev for RAM 6a7c2af hw:aspeed: drop warning and bogus ram_size fixup 172ef43 arm:aspeed: actually check RAM size 0e55e08 arm:aspeed: convert valid RAM sizes to data ff6444e alpha:dp264: use memdev for RAM b02edb3 initialize MachineState::ram in NUMA case 5d0b636 machine: introduce convenience MachineState::ram 0fc2004 machine: alias -mem-path and -mem-prealloc into memory-foo backend 6d984b5 machine: introduce ram-memdev property 08fae89 numa: remove deprecated -mem-path fallback to anonymous RAM === OUTPUT BEGIN === 1/86 Checking commit 08fae890b67d (numa: remove deprecated -mem-path fallback to anonymous RAM) 2/86 Checking commit 6d984b5dbe35 (machine: introduce ram-memdev property) 3/86 Checking commit 0fc2004b03fa (machine: alias -mem-path and -mem-prealloc into memory-foo backend) 4/86 Checking commit 5d0b6369dddd (machine: introduce convenience MachineState::ram) 5/86 Checking commit b02edb340b79 (initialize MachineState::ram in NUMA case) 6/86 Checking commit ff6444e72906 (alpha:dp264: use memdev for RAM) ERROR: spaces required around that '*' (ctx:WxV) #30: FILE: hw/alpha/alpha_sys.h:14: +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4], ^ total: 1 errors, 0 warnings, 49 lines checked Patch 6/86 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/86 Checking commit 0e55e08f3939 (arm:aspeed: convert valid RAM sizes to data) 8/86 Checking commit 172ef43b9b4c (arm:aspeed: actually check RAM size) 9/86 Checking commit 6a7c2afd4d79 (hw:aspeed: drop warning and bogus ram_size fixup) 10/86 Checking commit 7b0d32621113 (arm:aspeed: use memdev for RAM) 11/86 Checking commit 8d954fe5f96f (arm:collie: use memdev for RAM) 12/86 Checking commit aab50b18bced (arm:cubieboard: use memdev for RAM) 13/86 Checking commit 91d80f466fe8 (arm:digic_boards: use memdev for RAM) 14/86 Checking commit 999f220da883 (arm:highbank: use memdev for RAM) 15/86 Checking commit c794dcf7bf01 (arm:imx25_pdk: drop RAM size fixup) 16/86 Checking commit 4dee2dcc09ca (arm:imx25_pdk: use memdev for RAM) 17/86 Checking commit f843b3e1c9f9 (arm:integratorcp: use memdev for RAM) 18/86 Checking commit c3cc18081f36 (arm:kzm: drop RAM size fixup) 19/86 Checking commit e5d7dc1e5edf (arm:kzm: use memdev for RAM) 20/86 Checking commit a5d1f434a0e5 (arm:mcimx6ul-evk: use memdev for RAM) 21/86 Checking commit d675a780389d (arm:mcimx7d-sabre: use memdev for RAM) 22/86 Checking commit 6384dde578a1 (arm:mps2-tz: use memdev for RAM) 23/86 Checking commit 00a31d86e9a8 (arm:mps2: use memdev for RAM) 24/86 Checking commit a4602403859e (arm:musicpal: use memdev for RAM) 25/86 Checking commit 54372f185c92 (arm:nseries: use memdev for RAM) 26/86 Checking commit 59fa4ec0862b (arm:omap_sx1: use memdev for RAM) 27/86 Checking commit c2fe517abcc9 (arm:palm: use memdev for RAM) 28/86 Checking commit 8b211a1daf3d (arm:raspi: use memdev for RAM) 29/86 Checking commit e67a9091bf3d (arm:sabrelite: use memdev for RAM) 30/86 Checking commit 4ef5f91d1d96 (arm:sbsa-ref: use memdev for RAM) 31/86 Checking commit 5f184952ed5b (arm:versatilepb: use memdev for RAM) 32/86 Checking commit f59a42177faf (arm:vexpress: use memdev for RAM) 33/86 Checking commit 487a287b51b3 (arm:virt: use memdev for RAM) 34/86 Checking commit 521457884d96 (arm:xilinx_zynq: drop RAM size fixup) 35/86 Checking commit c9746806716e (arm:xilinx_zynq: use memdev for RAM) 36/86 Checking commit 6c17f5ec4b48 (arm:xlnx-versal-virt: use memdev for RAM) 37/86 Checking commit 9efacaa92b99 (arm:xlnx-zcu102: use memdev for RAM) 38/86 Checking commit eca7ad3c361e (s390x:s390-virtio-ccw: use memdev for RAM) 39/86 Checking commit 30ec2c7dc4c1 (null-machine: use memdev for RAM) 40/86 Checking commit f66c661dad7f (cris:axis_dev88: use memdev for RAM) 41/86 Checking commit 8bb59b8d7d9b (hw/hppa/machine: Correctly check the firmware is in PDC range) 42/86 Checking commit 14d9db719ee9 (hw/hppa/machine: Restrict the total memory size to 3GB) 43/86 Checking commit dad8af336ab4 (hw/hppa/machine: Map the PDC memory region with higher priority) 44/86 Checking commit 56cec5259b48 (hppa: use memdev for RAM) 45/86 Checking commit f0ed8aea05ec (x86:microvm: use memdev for RAM) 46/86 Checking commit b72206fa355a (x86:pc: use memdev for RAM) 47/86 Checking commit 06d3b1b78666 (lm32:lm32_boards: use memdev for RAM) 48/86 Checking commit 7471a180c3a6 (lm32:milkymist: use memdev for RAM) 49/86 Checking commit 2e3739900bd8 (m68k:an5206: use memdev for RAM) 50/86 Checking commit aa9050cb0d06 (m68k:mcf5208: use memdev for RAM) 51/86 Checking commit f97cebd672df (m68k:next-cube: use memdev for RAM) 52/86 Checking commit 6f147f566f68 (mips:boston-cube: use memdev for RAM) 53/86 Checking commit 974b1c015a30 (mips:mips_fulong2e: drop RAM size fixup) 54/86 Checking commit 9fde8b0b7ebd (mips:mips_fulong2e: use memdev for RAM) 55/86 Checking commit f059e6d82739 (mips:mips_jazz: use memdev for RAM) 56/86 Checking commit a1226bd6ef36 (mips:mips_malta: use memdev for RAM) 57/86 Checking commit 0577baa20231 (mips:mips_mipssim: use memdev for RAM) 58/86 Checking commit 05ef318bd0cc (mips:mips_r4k: use memdev for RAM) 59/86 Checking commit aa12e5f0638e (ppc:e500: drop RAM size fixup) 60/86 Checking commit de3715db85f6 (ppc:e500: use memdev for RAM) 61/86 Checking commit 803a2393fc14 (ppc:mac_newworld: use memdev for RAM) 62/86 Checking commit 8794a61a8dde (ppc:mac_oldworld: use memdev for RAM) 63/86 Checking commit 95965c87139d (ppc:pnv: use memdev for RAM) 64/86 Checking commit 90799d8e395f (ppc:ppc405_boards: add RAM size checks) 65/86 Checking commit c946d56eda0e (ppc:ppc405_boards: use memdev for RAM) 66/86 Checking commit 78dacf71acea (ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup) 67/86 Checking commit 07bab1c01b30 (ppc:ppc440_bamboo/sam460ex: use memdev for RAM) 68/86 Checking commit 42503a255083 (ppc:prep: use memdev for RAM) 69/86 Checking commit 9696d2717401 (ppc:spapr: use memdev for RAM) 70/86 Checking commit d151f5a5742e (ppc:virtex_ml507: remove unused arguments) 71/86 Checking commit 1b434072e43b (ppc:virtex_ml507: use memdev for RAM) 72/86 Checking commit 7b57adc2d77a (sparc:leon3: use memdev for RAM) 73/86 Checking commit 193cdb51d4bf (sparc:sun4m: use memdev for RAM) 74/86 Checking commit b3cee011513d (sparc:niagara: use memdev for RAM) 75/86 Checking commit dba7fdb96a10 (remove no longer used memory_region_allocate_system_memory()) 76/86 Checking commit fad9d8348bef (post conversion default_ram_id cleanup) 77/86 Checking commit 82d8312d1497 (exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()) 78/86 Checking commit 3f12da229964 (exec: drop bogus mem_path from qemu_ram_alloc_from_fd()) 79/86 Checking commit 37e2c242f0f5 (make mem_path local variable) 80/86 Checking commit 547e1199adae (hostmem: introduce "prealloc-threads" property) 81/86 Checking commit 46367323657c (hostmem: fix strict bind policy) 82/86 Checking commit 22e8003d2397 (numa: forbid '-numa node, mem' for 5.0 and newer machine types) 83/86 Checking commit e73639dfcea1 (tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups) 84/86 Checking commit 8646e5e3e3b3 (tests:numa-test: use explicit memdev to specify node RAM) 85/86 Checking commit d86b08b42b99 (numa: make exit() usage consistent) 86/86 Checking commit 11a20c3ae98b (numa: remove deprecated implicit RAM distribution between nodes) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END === TEST iotest-qcow2: 217 socket_accept failed: Resource temporarily unavailable ** ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) /tmp/qemu-test/src/tests/qtest/libqtest.c:140: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) make: *** [check-qtest-x86_64] Error 1 make: *** Waiting for unfinished jobs.... TEST check-qtest-aarch64: tests/qtest/test-hmp TEST iotest-qcow2: 220 --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=755fcbfd171f40b1b16d6aac34e7c09b', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-qd5wtatm/src/docker-src.2020-01-15-15.50.14.28652:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=755fcbfd171f40b1b16d6aac34e7c09b make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-qd5wtatm/src' make: *** [docker-run-test-quick@centos7] Error 2 real 11m0.219s user 0m8.267s The full log is available at http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 1/15/20 10:01 PM, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce it > locally. > > === TEST SCRIPT BEGIN === > #!/bin/bash > make docker-image-centos7 V=1 NETWORK=1 > time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 > === TEST SCRIPT END === > > TEST iotest-qcow2: 217 > socket_accept failed: Resource temporarily unavailable > ** > ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) > /tmp/qemu-test/src/tests/qtest/libqtest.c:140: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) > ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) > make: *** [check-qtest-x86_64] Error 1 Is this something we should care about? > make: *** Waiting for unfinished jobs.... > TEST check-qtest-aarch64: tests/qtest/test-hmp > TEST iotest-qcow2: 220 > --- > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=755fcbfd171f40b1b16d6aac34e7c09b', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-qd5wtatm/src/docker-src.2020-01-15-15.50.14.28652:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. > filter=--filter=label=com.qemu.instance.uuid=755fcbfd171f40b1b16d6aac34e7c09b > make[1]: *** [docker-run] Error 1 > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-qd5wtatm/src' > make: *** [docker-run-test-quick@centos7] Error 2 > > real 11m0.219s > user 0m8.267s > > > The full log is available at > http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.docker-quick@centos7/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com >
On Thu, 16 Jan 2020 16:43:07 +0100 Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > On 1/15/20 10:01 PM, no-reply@patchew.org wrote: > > Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ > > > > > > > > Hi, > > > > This series failed the docker-quick@centos7 build test. Please find the testing commands and > > their output below. If you have Docker installed, you can probably reproduce it > > locally. > > > > === TEST SCRIPT BEGIN === > > #!/bin/bash > > make docker-image-centos7 V=1 NETWORK=1 > > time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 it doesn't work on my host, since it tries to use /tmp for building an image and fails with no space. is there any way to point it to some other place? > > === TEST SCRIPT END === > > > > TEST iotest-qcow2: 217 > > socket_accept failed: Resource temporarily unavailable > > ** > > ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) > > /tmp/qemu-test/src/tests/qtest/libqtest.c:140: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) > > ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:272:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) > > make: *** [check-qtest-x86_64] Error 1 > > Is this something we should care about? #217 passes on my host, albeit it takes time to complete > > > make: *** Waiting for unfinished jobs.... > > TEST check-qtest-aarch64: tests/qtest/test-hmp > > TEST iotest-qcow2: 220 > > --- > > raise CalledProcessError(retcode, cmd) > > subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=755fcbfd171f40b1b16d6aac34e7c09b', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-qd5wtatm/src/docker-src.2020-01-15-15.50.14.28652:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. > > filter=--filter=label=com.qemu.instance.uuid=755fcbfd171f40b1b16d6aac34e7c09b > > make[1]: *** [docker-run] Error 1 > > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-qd5wtatm/src' > > make: *** [docker-run-test-quick@centos7] Error 2 > > > > real 11m0.219s > > user 0m8.267s > > > > > > The full log is available at > > http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.docker-quick@centos7/?type=message. > > --- > > Email generated automatically by Patchew [https://patchew.org/]. > > Please send your feedback to patchew-devel@redhat.com > > > >
On 1/17/20 5:03 PM, Igor Mammedov wrote: > On Thu, 16 Jan 2020 16:43:07 +0100 > Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > >> On 1/15/20 10:01 PM, no-reply@patchew.org wrote: >>> Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ >>> >>> >>> >>> Hi, >>> >>> This series failed the docker-quick@centos7 build test. Please find the testing commands and >>> their output below. If you have Docker installed, you can probably reproduce it >>> locally. >>> >>> === TEST SCRIPT BEGIN === >>> #!/bin/bash >>> make docker-image-centos7 V=1 NETWORK=1 >>> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 > > it doesn't work on my host, since it tries to use /tmp for building an image > and fails with no space. > is there any way to point it to some other place? What is failing? Building the docker image, or building QEMU withing the docker container?
On Fri, 17 Jan 2020 17:19:26 +0100 Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > On 1/17/20 5:03 PM, Igor Mammedov wrote: > > On Thu, 16 Jan 2020 16:43:07 +0100 > > Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > > >> On 1/15/20 10:01 PM, no-reply@patchew.org wrote: > >>> Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ > >>> > >>> > >>> > >>> Hi, > >>> > >>> This series failed the docker-quick@centos7 build test. Please find the testing commands and > >>> their output below. If you have Docker installed, you can probably reproduce it > >>> locally. > >>> > >>> === TEST SCRIPT BEGIN === > >>> #!/bin/bash > >>> make docker-image-centos7 V=1 NETWORK=1 > >>> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 > > > > it doesn't work on my host, since it tries to use /tmp for building an image > > and fails with no space. > > is there any way to point it to some other place? > > What is failing? Building the docker image, or building QEMU withing the > docker container? docker image
On 1/17/20 5:40 PM, Igor Mammedov wrote: > On Fri, 17 Jan 2020 17:19:26 +0100 > Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > >> On 1/17/20 5:03 PM, Igor Mammedov wrote: >>> On Thu, 16 Jan 2020 16:43:07 +0100 >>> Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >>> >>>> On 1/15/20 10:01 PM, no-reply@patchew.org wrote: >>>>> Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ >>>>> >>>>> >>>>> >>>>> Hi, >>>>> >>>>> This series failed the docker-quick@centos7 build test. Please find the testing commands and >>>>> their output below. If you have Docker installed, you can probably reproduce it >>>>> locally. >>>>> >>>>> === TEST SCRIPT BEGIN === >>>>> #!/bin/bash >>>>> make docker-image-centos7 V=1 NETWORK=1 >>>>> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 >>> >>> it doesn't work on my host, since it tries to use /tmp for building an image >>> and fails with no space. >>> is there any way to point it to some other place? >> >> What is failing? Building the docker image, or building QEMU withing the >> docker container? > > docker image Odd. I thought image was built in default storage dir: /var/lib/docker # docker system info | fgrep / Docker Root Dir: /var/lib/docker The default might be distrib dependent, my workstation is on Fedora. Maybe while building a tmpfs is mount as /tmp within the temp container, and your ram is limited so it gets full while downloading packages to install? Sincerely I have no clue. Docker is not your friend :/ Here they say you can change the docker dir with '-g' https://forums.docker.com/t/how-do-i-change-the-docker-image-installation-directory/1169/4 Can you paste the error context?
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend Type: series Message-id: 1579100861-73692-1-git-send-email-imammedo@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 1209a36 numa: remove deprecated implicit RAM distribution between nodes 19d06fb numa: make exit() usage consistent 7f1c3cb tests:numa-test: use explicit memdev to specify node RAM 1f9e2a0 tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups 599a9d5 numa: forbid '-numa node, mem' for 5.0 and newer machine types abc7dcb hostmem: fix strict bind policy f128425 hostmem: introduce "prealloc-threads" property 29a5753 make mem_path local variable 9c8eede exec: drop bogus mem_path from qemu_ram_alloc_from_fd() ae8a358 exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize() bd38eb7 post conversion default_ram_id cleanup 531214b remove no longer used memory_region_allocate_system_memory() 9aa9b21 sparc:niagara: use memdev for RAM 7501234 sparc:sun4m: use memdev for RAM 362d299 sparc:leon3: use memdev for RAM 3d80e73 ppc:virtex_ml507: use memdev for RAM 3f9b614 ppc:virtex_ml507: remove unused arguments 23206b2 ppc:spapr: use memdev for RAM 21d8ec6 ppc:prep: use memdev for RAM b2dfc41 ppc:ppc440_bamboo/sam460ex: use memdev for RAM f7dba1d ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup 6797fc9 ppc:ppc405_boards: use memdev for RAM 6589023 ppc:ppc405_boards: add RAM size checks f4e844d ppc:pnv: use memdev for RAM 7a5c1e0 ppc:mac_oldworld: use memdev for RAM c0070ff ppc:mac_newworld: use memdev for RAM 891c437 ppc:e500: use memdev for RAM e356db0 ppc:e500: drop RAM size fixup d9d748a mips:mips_r4k: use memdev for RAM c3aeedd mips:mips_mipssim: use memdev for RAM f1ae813 mips:mips_malta: use memdev for RAM 8135812 mips:mips_jazz: use memdev for RAM 6bb5173 mips:mips_fulong2e: use memdev for RAM 7918bc6 mips:mips_fulong2e: drop RAM size fixup 03ed964 mips:boston-cube: use memdev for RAM 50de1db m68k:next-cube: use memdev for RAM 11359d6 m68k:mcf5208: use memdev for RAM 0f6e187 m68k:an5206: use memdev for RAM 1dbf590 lm32:milkymist: use memdev for RAM 1ec9f92 lm32:lm32_boards: use memdev for RAM cfda441 x86:pc: use memdev for RAM cf3880a x86:microvm: use memdev for RAM bd518f7 hppa: use memdev for RAM 4fc8795 hw/hppa/machine: Map the PDC memory region with higher priority 8198bbb hw/hppa/machine: Restrict the total memory size to 3GB b734915 hw/hppa/machine: Correctly check the firmware is in PDC range f132881 cris:axis_dev88: use memdev for RAM afed772 null-machine: use memdev for RAM 42efb21 s390x:s390-virtio-ccw: use memdev for RAM e09d9d5 arm:xlnx-zcu102: use memdev for RAM f4cfdc5 arm:xlnx-versal-virt: use memdev for RAM 27cb15f arm:xilinx_zynq: use memdev for RAM c4d7543 arm:xilinx_zynq: drop RAM size fixup 4cee731 arm:virt: use memdev for RAM bc8706f arm:vexpress: use memdev for RAM 8f9a8d5 arm:versatilepb: use memdev for RAM 7534670 arm:sbsa-ref: use memdev for RAM f7a5bd5 arm:sabrelite: use memdev for RAM c543136 arm:raspi: use memdev for RAM 1980a99 arm:palm: use memdev for RAM f2a8a27 arm:omap_sx1: use memdev for RAM 83e43bd arm:nseries: use memdev for RAM ce56f6f arm:musicpal: use memdev for RAM 8d8a3df arm:mps2: use memdev for RAM cde4e5c arm:mps2-tz: use memdev for RAM 496e1ec arm:mcimx7d-sabre: use memdev for RAM 107798d arm:mcimx6ul-evk: use memdev for RAM 2aad52a arm:kzm: use memdev for RAM 931e8ed arm:kzm: drop RAM size fixup 3a6db19 arm:integratorcp: use memdev for RAM 7027643 arm:imx25_pdk: use memdev for RAM 34af242 arm:imx25_pdk: drop RAM size fixup 40d5268 arm:highbank: use memdev for RAM 7b39bf2 arm:digic_boards: use memdev for RAM 4ce882d arm:cubieboard: use memdev for RAM 9e5f1e4 arm:collie: use memdev for RAM 4271c25 arm:aspeed: use memdev for RAM 51eb68b hw:aspeed: drop warning and bogus ram_size fixup d19f874 arm:aspeed: actually check RAM size 5e95ab5 arm:aspeed: convert valid RAM sizes to data b9b1823 alpha:dp264: use memdev for RAM 54d3324 initialize MachineState::ram in NUMA case a905e67 machine: introduce convenience MachineState::ram c4baa19 machine: alias -mem-path and -mem-prealloc into memory-foo backend f4626dd machine: introduce ram-memdev property c37dfff numa: remove deprecated -mem-path fallback to anonymous RAM === OUTPUT BEGIN === 1/86 Checking commit c37dfffa4efd (numa: remove deprecated -mem-path fallback to anonymous RAM) 2/86 Checking commit f4626dd69b26 (machine: introduce ram-memdev property) 3/86 Checking commit c4baa192a911 (machine: alias -mem-path and -mem-prealloc into memory-foo backend) 4/86 Checking commit a905e67b7c6f (machine: introduce convenience MachineState::ram) 5/86 Checking commit 54d3324c4016 (initialize MachineState::ram in NUMA case) 6/86 Checking commit b9b1823833a3 (alpha:dp264: use memdev for RAM) ERROR: spaces required around that '*' (ctx:WxV) #30: FILE: hw/alpha/alpha_sys.h:14: +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4], ^ total: 1 errors, 0 warnings, 49 lines checked Patch 6/86 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/86 Checking commit 5e95ab5c9cbf (arm:aspeed: convert valid RAM sizes to data) 8/86 Checking commit d19f87410bb0 (arm:aspeed: actually check RAM size) 9/86 Checking commit 51eb68b5b6dd (hw:aspeed: drop warning and bogus ram_size fixup) 10/86 Checking commit 4271c257d2dc (arm:aspeed: use memdev for RAM) 11/86 Checking commit 9e5f1e40a8a1 (arm:collie: use memdev for RAM) 12/86 Checking commit 4ce882df0248 (arm:cubieboard: use memdev for RAM) 13/86 Checking commit 7b39bf2154ee (arm:digic_boards: use memdev for RAM) 14/86 Checking commit 40d526890ff2 (arm:highbank: use memdev for RAM) 15/86 Checking commit 34af2429cba4 (arm:imx25_pdk: drop RAM size fixup) 16/86 Checking commit 702764368746 (arm:imx25_pdk: use memdev for RAM) 17/86 Checking commit 3a6db19653b8 (arm:integratorcp: use memdev for RAM) 18/86 Checking commit 931e8edc73be (arm:kzm: drop RAM size fixup) 19/86 Checking commit 2aad52a98a7f (arm:kzm: use memdev for RAM) 20/86 Checking commit 107798df7551 (arm:mcimx6ul-evk: use memdev for RAM) 21/86 Checking commit 496e1ec4c802 (arm:mcimx7d-sabre: use memdev for RAM) 22/86 Checking commit cde4e5c62e6c (arm:mps2-tz: use memdev for RAM) 23/86 Checking commit 8d8a3df592ff (arm:mps2: use memdev for RAM) 24/86 Checking commit ce56f6fa5c27 (arm:musicpal: use memdev for RAM) 25/86 Checking commit 83e43bd9c245 (arm:nseries: use memdev for RAM) 26/86 Checking commit f2a8a2703e2c (arm:omap_sx1: use memdev for RAM) 27/86 Checking commit 1980a9933328 (arm:palm: use memdev for RAM) 28/86 Checking commit c54313643e04 (arm:raspi: use memdev for RAM) 29/86 Checking commit f7a5bd5a1a37 (arm:sabrelite: use memdev for RAM) 30/86 Checking commit 75346700226a (arm:sbsa-ref: use memdev for RAM) 31/86 Checking commit 8f9a8d5832e9 (arm:versatilepb: use memdev for RAM) 32/86 Checking commit bc8706f5e2d5 (arm:vexpress: use memdev for RAM) 33/86 Checking commit 4cee731800bb (arm:virt: use memdev for RAM) 34/86 Checking commit c4d7543f065b (arm:xilinx_zynq: drop RAM size fixup) 35/86 Checking commit 27cb15f0d997 (arm:xilinx_zynq: use memdev for RAM) 36/86 Checking commit f4cfdc5a94bb (arm:xlnx-versal-virt: use memdev for RAM) 37/86 Checking commit e09d9d544217 (arm:xlnx-zcu102: use memdev for RAM) 38/86 Checking commit 42efb216e23c (s390x:s390-virtio-ccw: use memdev for RAM) 39/86 Checking commit afed77250a9e (null-machine: use memdev for RAM) 40/86 Checking commit f132881e85cd (cris:axis_dev88: use memdev for RAM) 41/86 Checking commit b734915b4a79 (hw/hppa/machine: Correctly check the firmware is in PDC range) 42/86 Checking commit 8198bbbb80a8 (hw/hppa/machine: Restrict the total memory size to 3GB) 43/86 Checking commit 4fc879584148 (hw/hppa/machine: Map the PDC memory region with higher priority) 44/86 Checking commit bd518f7b1afe (hppa: use memdev for RAM) 45/86 Checking commit cf3880ae2cde (x86:microvm: use memdev for RAM) 46/86 Checking commit cfda4411481a (x86:pc: use memdev for RAM) 47/86 Checking commit 1ec9f92af351 (lm32:lm32_boards: use memdev for RAM) 48/86 Checking commit 1dbf590a6f2e (lm32:milkymist: use memdev for RAM) 49/86 Checking commit 0f6e18798454 (m68k:an5206: use memdev for RAM) 50/86 Checking commit 11359d6d7fca (m68k:mcf5208: use memdev for RAM) 51/86 Checking commit 50de1db70670 (m68k:next-cube: use memdev for RAM) 52/86 Checking commit 03ed96483838 (mips:boston-cube: use memdev for RAM) 53/86 Checking commit 7918bc615c00 (mips:mips_fulong2e: drop RAM size fixup) 54/86 Checking commit 6bb51739bef8 (mips:mips_fulong2e: use memdev for RAM) 55/86 Checking commit 8135812a7f8f (mips:mips_jazz: use memdev for RAM) 56/86 Checking commit f1ae813bc679 (mips:mips_malta: use memdev for RAM) 57/86 Checking commit c3aeedd1f9e7 (mips:mips_mipssim: use memdev for RAM) 58/86 Checking commit d9d748a3c5c4 (mips:mips_r4k: use memdev for RAM) 59/86 Checking commit e356db0d9dc1 (ppc:e500: drop RAM size fixup) 60/86 Checking commit 891c437f30de (ppc:e500: use memdev for RAM) 61/86 Checking commit c0070fff31f7 (ppc:mac_newworld: use memdev for RAM) 62/86 Checking commit 7a5c1e08eb9a (ppc:mac_oldworld: use memdev for RAM) 63/86 Checking commit f4e844d0b244 (ppc:pnv: use memdev for RAM) 64/86 Checking commit 6589023692a3 (ppc:ppc405_boards: add RAM size checks) 65/86 Checking commit 6797fc946c2f (ppc:ppc405_boards: use memdev for RAM) 66/86 Checking commit f7dba1dc9cee (ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup) 67/86 Checking commit b2dfc417ea25 (ppc:ppc440_bamboo/sam460ex: use memdev for RAM) 68/86 Checking commit 21d8ec68c790 (ppc:prep: use memdev for RAM) 69/86 Checking commit 23206b2a4e7e (ppc:spapr: use memdev for RAM) 70/86 Checking commit 3f9b6144afb3 (ppc:virtex_ml507: remove unused arguments) 71/86 Checking commit 3d80e73f3489 (ppc:virtex_ml507: use memdev for RAM) 72/86 Checking commit 362d2997578e (sparc:leon3: use memdev for RAM) 73/86 Checking commit 7501234325d1 (sparc:sun4m: use memdev for RAM) 74/86 Checking commit 9aa9b2166491 (sparc:niagara: use memdev for RAM) 75/86 Checking commit 531214b20a79 (remove no longer used memory_region_allocate_system_memory()) 76/86 Checking commit bd38eb7acb3b (post conversion default_ram_id cleanup) 77/86 Checking commit ae8a35855f2c (exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()) 78/86 Checking commit 9c8eede386a4 (exec: drop bogus mem_path from qemu_ram_alloc_from_fd()) 79/86 Checking commit 29a5753391ee (make mem_path local variable) 80/86 Checking commit f128425ba191 (hostmem: introduce "prealloc-threads" property) 81/86 Checking commit abc7dcbd0c46 (hostmem: fix strict bind policy) 82/86 Checking commit 599a9d539ae3 (numa: forbid '-numa node, mem' for 5.0 and newer machine types) 83/86 Checking commit 1f9e2a07e397 (tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups) 84/86 Checking commit 7f1c3cb94728 (tests:numa-test: use explicit memdev to specify node RAM) 85/86 Checking commit 19d06fb502bb (numa: make exit() usage consistent) 86/86 Checking commit 1209a3623bcc (numa: remove deprecated implicit RAM distribution between nodes) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1579100861-73692-1-git-send-email-imammedo@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Wed, 15 Jan 2020 08:43:33 -0800 (PST) no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: [...] > 6/86 Checking commit b9b1823833a3 (alpha:dp264: use memdev for RAM) > ERROR: spaces required around that '*' (ctx:WxV) > #30: FILE: hw/alpha/alpha_sys.h:14: > +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4], patch keeps the same style that was used in original code I can rewrite it on the next respin to mach current codestyle [...]
On 1/15/20 6:09 PM, Igor Mammedov wrote: > On Wed, 15 Jan 2020 08:43:33 -0800 (PST) > no-reply@patchew.org wrote: > >> Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ >> >> >> >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: > [...] > >> 6/86 Checking commit b9b1823833a3 (alpha:dp264: use memdev for RAM) >> ERROR: spaces required around that '*' (ctx:WxV) >> #30: FILE: hw/alpha/alpha_sys.h:14: >> +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4], > > patch keeps the same style that was used in original code > I can rewrite it on the next respin to mach current codestyle False positive I think.
On 1/15/20 7:09 AM, Igor Mammedov wrote: > On Wed, 15 Jan 2020 08:43:33 -0800 (PST) > no-reply@patchew.org wrote: > >> Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imammedo@redhat.com/ >> >> >> >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: > [...] > >> 6/86 Checking commit b9b1823833a3 (alpha:dp264: use memdev for RAM) >> ERROR: spaces required around that '*' (ctx:WxV) >> #30: FILE: hw/alpha/alpha_sys.h:14: >> +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4], > > patch keeps the same style that was used in original code > I can rewrite it on the next respin to mach current codestyle False positive. The script doesn't understand pointers well, and it's triggering the rule for multiplication. r~
© 2016 - 2024 Red Hat, Inc.