From nobody Mon Feb 9 04:46:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576155017; cv=none; d=zohomail.com; s=zohoarc; b=kKJwFnG38Tlz7ROxcBKJ5mtOhbYilqe88P2czlWAMfK7o+87hkdbzQ09RlxEGgNARberbqR/wxhKicfWpotoeWWy24RRpAU0cP8UTPoJ0mJqP6+l8qWx92vSbXqIH9j6aILEZarl4zuamV0uqj/WQEiYUtUJTP/iVO4tY3/cr1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576155017; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=quY/CuROmNruxW1DGcY5ylIdglxJ30C+FEQEjGEZBzw=; b=l3kELbrfae/eCeXMmRf3QMwuMjxFd4mKLRS3eMXPvjV+Kjz5PXuMxvIshj1ULg8s1lHbYumgxDMk+UHbwUxvXG7u7ZCIOQWdaz+8HlDVOdXa7zQefI4nt5zL4MkxF1ka5sn9XinW19gsCtH/EDurVqH6Ip9QrVEWnMGD6tLJB1k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576155017735736.5246614133248; Thu, 12 Dec 2019 04:50:17 -0800 (PST) Received: from localhost ([::1]:58770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifNv6-0007ZY-9C for importer@patchew.org; Thu, 12 Dec 2019 07:50:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36980) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifNtj-0006AM-RS for qemu-devel@nongnu.org; Thu, 12 Dec 2019 07:48:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifNth-0005jX-D6 for qemu-devel@nongnu.org; Thu, 12 Dec 2019 07:48:50 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:23332 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifNth-0005iL-9p for qemu-devel@nongnu.org; Thu, 12 Dec 2019 07:48:49 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-lwoQqSMtP7C664reThka4w-1; Thu, 12 Dec 2019 07:48:47 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05AE0DB68; Thu, 12 Dec 2019 12:48:46 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 09D7510013A1; Thu, 12 Dec 2019 12:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576154928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=quY/CuROmNruxW1DGcY5ylIdglxJ30C+FEQEjGEZBzw=; b=Khky0empvgjLiHPuFL0ImlMJlAropC8ZAlca1h3P41sEp+X+49WAhqbix3sLnZZFaLg2OC Ywiw0aa/UVgcxSfNBDozTusHMpyrRI3vXLthMgy9I10bASVSTTBute5srvNtkW5HpAPw06 KITpNYZwDT1bO789D/TpsVGU5y4mndc= From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH 1/2] numa: remove not needed check Date: Thu, 12 Dec 2019 13:48:55 +0100 Message-Id: <1576154936-178362-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1576154936-178362-1-git-send-email-imammedo@redhat.com> References: <1576154936-178362-1-git-send-email-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: lwoQqSMtP7C664reThka4w-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tao Xu , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently parse_numa_node() is always called from already numa enabled context. Drop unnecessary check if numa is supported. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- hw/core/numa.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index e3332a9..19f082d 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -83,10 +83,6 @@ static void parse_numa_node(MachineState *ms, NumaNodeOp= tions *node, return; } =20 - if (!mc->cpu_index_to_instance_props || !mc->get_default_cpu_node_id) { - error_setg(errp, "NUMA is not supported by this machine-type"); - return; - } for (cpus =3D node->cpus; cpus; cpus =3D cpus->next) { CpuInstanceProperties props; if (cpus->value >=3D max_cpus) { @@ -178,9 +174,8 @@ void parse_numa_distance(MachineState *ms, NumaDistOpti= ons *dist, Error **errp) void set_numa_options(MachineState *ms, NumaOptions *object, Error **errp) { Error *err =3D NULL; - MachineClass *mc =3D MACHINE_GET_CLASS(ms); =20 - if (!mc->numa_mem_supported) { + if (!ms->numa_state) { error_setg(errp, "NUMA is not supported by this machine-type"); goto end; } --=20 2.7.4