From nobody Mon May 6 19:50:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576113538; cv=none; d=zohomail.com; s=zohoarc; b=N8nm2KyUNULZE4EHWuywK0XsTDfB2oZjw2/jNxqzG43p7rAAsKOgtiH0yV6kQimSxrXJgsDDf3n4uVoVjxNQElExexgKwYdR6xq0guvQONjRsOzgd9gpJc+soxXoGv+tgDvlkBitVilgZbk+NYwHo+iLE4LTVB2lt3N/dMfbTyE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576113538; h=Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=HS0mYx2ICk6pSEqwdC6wNsFaEiKXYYrwbDgZwYY2qoc=; b=ctRf93YV/Z89wREP14DmW9EofeWXdqEc1eaOpRPn+YiNV34kyE5iYTqhaiccvNlmCA0x17Yaear95Q97XPtmOLX55AzveMikPOkmM6ExIY8no/IS7IZ/8g4NC1W75chFec+uLAcoMLWDmGVvRyFCChZsuQEq6Z4AeCl++Pjcksc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157611353878991.30644733037298; Wed, 11 Dec 2019 17:18:58 -0800 (PST) Received: from localhost ([::1]:52536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifD85-0003i6-NC for importer@patchew.org; Wed, 11 Dec 2019 20:18:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58830) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifD7D-0002oW-Ht for qemu-devel@nongnu.org; Wed, 11 Dec 2019 20:18:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifD7C-0004xG-D5 for qemu-devel@nongnu.org; Wed, 11 Dec 2019 20:18:03 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:34611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifD7C-0004um-31 for qemu-devel@nongnu.org; Wed, 11 Dec 2019 20:18:02 -0500 Received: by mail-wr1-x444.google.com with SMTP id t2so820348wrr.1 for ; Wed, 11 Dec 2019 17:18:02 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id i8sm4289870wro.47.2019.12.11.17.17.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Dec 2019 17:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id; bh=HS0mYx2ICk6pSEqwdC6wNsFaEiKXYYrwbDgZwYY2qoc=; b=Zv+Z/ih6l3wKGkBvoQrtSQRLGXlw3zV+2SW98lLUz2xK+lt+fDeMf1j1yfDszqfIvH AwgQJLtjtVDW8blOjc69n6hamktAU2JXMQWp8N0scUaKZLtfR9L2a0ilpjSTbnIMZHLl bhiZoE/BW9tddiWRcytG44DPDsyvYMM/Wl9X21abCMP4Uru0QdpTc3K5mg2F7QFh4z39 r60LT0ifgtjXSlKdxCfLJvZHcnZvgrs64wa+UtiC/QezG94FimLvvj7HiNK0Q671XtEr 2XOFjgiX7+KMv7LZ7i4OEnloEN0vGMnTYOKciQmLTJMqhOH8vwfNl+Rzb5H3kUB8AW4b n9TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=HS0mYx2ICk6pSEqwdC6wNsFaEiKXYYrwbDgZwYY2qoc=; b=ffq2lBUnmHlhcaB3bumNQsZyMX5PWg/qrcWFeqW/NSy+SU2lvXqYFvs60w7Kvg9Dlx mIaAsI4pn0Ac1QUVGi/1q60snOvKchUpCnF7S1qg+APOky3Ne1isIfZ3TLPdRgTgbc/s vTDwbvpPO1hdHEs3zIV78Rin/SIWMhS2hDGfDsB305tWyiTP9epUHZyUQOk1fhBR/tDL sHxzxecdTyHJWgBaNwqPjiTaBgBwrFFA7Cb95NAWSAggarwAjm05IOGs6tH7TLAjCau5 XSMPHMKjfNB7+RavQL0NSKTirJLj3can/j69bgJGxwMjNVVlZxGl6bMV3JfdVMzOy8W5 qaEQ== X-Gm-Message-State: APjAAAXMb+ANKZHzfK+KFZFqCsW9kIWB15TN2HB6D2dN0SKm3+myFgCq 2SR6Kf7Roov1SA5ru0w3FqY5r7iA X-Google-Smtp-Source: APXvYqzCXnQEUdN0F9f4Xb2ycW2IQJZckWU3ICrqv3w+zl2ykz4Vca9LhAqHWAdMJucbi2iWQGnJrA== X-Received: by 2002:a5d:540f:: with SMTP id g15mr2917443wrv.86.1576113480461; Wed, 11 Dec 2019 17:18:00 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH v2] tests: use g_test_rand_int Date: Thu, 12 Dec 2019 02:17:58 +0100 Message-Id: <1576113478-42926-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" g_test_rand_int provides a reproducible random integer number, using a different number seed every time but allowing reproduction using the --seed command line option. It is thus better suited to tests than g_random_int or random. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- tests/ivshmem-test.c | 2 +- tests/test-bitmap.c | 8 ++++---- tests/test-qga.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c index be9aa92..ecda256 100644 --- a/tests/ivshmem-test.c +++ b/tests/ivshmem-test.c @@ -443,7 +443,7 @@ static gchar *mktempshm(int size, int *fd) while (true) { gchar *name; =20 - name =3D g_strdup_printf("/qtest-%u-%u", getpid(), g_random_int()); + name =3D g_strdup_printf("/qtest-%u-%u", getpid(), g_test_rand_int= ()); *fd =3D shm_open(name, O_CREAT|O_RDWR|O_EXCL, S_IRWXU|S_IRWXG|S_IRWXO); if (*fd > 0) { diff --git a/tests/test-bitmap.c b/tests/test-bitmap.c index 087e02a..2f5b714 100644 --- a/tests/test-bitmap.c +++ b/tests/test-bitmap.c @@ -22,10 +22,10 @@ static void check_bitmap_copy_with_offset(void) bmap2 =3D bitmap_new(BMAP_SIZE); bmap3 =3D bitmap_new(BMAP_SIZE); =20 - bmap1[0] =3D random(); - bmap1[1] =3D random(); - bmap1[2] =3D random(); - bmap1[3] =3D random(); + bmap1[0] =3D g_test_rand_int(); + bmap1[1] =3D g_test_rand_int(); + bmap1[2] =3D g_test_rand_int(); + bmap1[3] =3D g_test_rand_int(); total =3D BITS_PER_LONG * 4; =20 /* Shift 115 bits into bmap2 */ diff --git a/tests/test-qga.c b/tests/test-qga.c index 1ca49bb..d2b2435 100644 --- a/tests/test-qga.c +++ b/tests/test-qga.c @@ -143,7 +143,7 @@ static void qmp_assertion_message_error(const char = *domain, static void test_qga_sync_delimited(gconstpointer fix) { const TestFixture *fixture =3D fix; - guint32 v, r =3D g_random_int(); + guint32 v, r =3D g_test_rand_int(); unsigned char c; QDict *ret; =20 @@ -186,7 +186,7 @@ static void test_qga_sync_delimited(gconstpointer fix) static void test_qga_sync(gconstpointer fix) { const TestFixture *fixture =3D fix; - guint32 v, r =3D g_random_int(); + guint32 v, r =3D g_test_rand_int(); QDict *ret; =20 /* --=20 1.8.3.1