From nobody Mon Feb 9 16:34:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575904914; cv=none; d=zohomail.com; s=zohoarc; b=ljeHJ4UqDgzLfqnfoSZnqk+TBRXEO/RogPe6O2XwoQNOChhhJ1gzWoGUfrja8N2kXhvrF/D5a1ZWNNFmWx5FD8lw2EVqydLKLepSbNKl5zJyJQ14jJAbnw5EE4v4X9LlxRx9u0G07Y0ZhorzHSnBDodZBfW/Gwuhl7ox6PGteyc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575904914; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=ylzcvlP2ozbD0HAsIyPi1y+3NrZwIrQQ1hXTxu0zBY0=; b=OlxliK/dpqxRjkSqCEQ7FCx5IDpXam6+Q3qe5qnL6XHJ7/nEj1/dmcO924+o+0+iidChyVs7alQS3VEUroJCuU9qU4lyC/rQEtfYAFkVduWjw8XrFaoAx95nmZfqAoex+a7r2xI6TBpkl9CejpBDVScBBpwyJurqPpwx2IhMjMQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1575904914352765.0286328139385; Mon, 9 Dec 2019 07:21:54 -0800 (PST) Received: from localhost ([::1]:41452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieKrB-0007Y4-4z for importer@patchew.org; Mon, 09 Dec 2019 10:21:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47298) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieKY4-0003cu-US for qemu-devel@nongnu.org; Mon, 09 Dec 2019 10:02:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieKY3-0001ZS-3T for qemu-devel@nongnu.org; Mon, 09 Dec 2019 10:02:08 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:53187) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieKY2-0001YW-Sf for qemu-devel@nongnu.org; Mon, 09 Dec 2019 10:02:07 -0500 Received: by mail-wm1-x32e.google.com with SMTP id p9so15827962wmc.2 for ; Mon, 09 Dec 2019 07:02:06 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id g9sm27219371wro.67.2019.12.09.07.02.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Dec 2019 07:02:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ylzcvlP2ozbD0HAsIyPi1y+3NrZwIrQQ1hXTxu0zBY0=; b=bl4Yk6rXeyOFlqEEvxiUoO400Rtp0gyFUxoJwSD4M7bn7ubT+599lu4X7PIoJHT/XR PJwZaC4Ni0MNuUTjgZERaua2xMLYrusxwoBGEhGM3aUFN3oh5IPA4eSJ2tdq5pGMgtz9 5NC9QuHNEY+caHL8/nb8mI+oh6qqalP2b97R7mSLxYejRdpEbFNOdM7+PlYObZLZ2dla EdWEaX8ZU90IUxoGF10FXpKicwK/ouWRlq6SZaurGgc5ORwIkeLIUhLpORYt8c9yhWl7 0uAvo+V3j52p8lxXGyk5CpWWvszX7I9Ja6sJi6dh5xq5RiXoTndawzDqHwPONwIfarKJ yCYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ylzcvlP2ozbD0HAsIyPi1y+3NrZwIrQQ1hXTxu0zBY0=; b=qRHH9VlmqNI+ncpu8Z3tjOibGElcjoIheS+dIxMd2B3S2VTaG70dez4bIz6KakdCc9 1g1OU6NWvIwL0w1c+LZxEjB/bDINrQwhZPdzEUaJs/jvXTO4FXCVWF6iuLBCEx6uy7o8 ANKRCGfyNJO+E2g67qTg9UxzsJWr61dGJWInsaR3wg3H+/Xji8LdAhv5ZvRE2rJbnmJy l2GyNSHC2eab5WxuiUZJpzGRMzdu/IRg04+GWClixkXOCwo6IRa0OSLE9YKJH17YqeKx 0/tHLMMKyLU9CToZgArKC3/dMv1zYIWsjAV0OBSSs6yaJZ76YCscC0T1U6poupEWPnZJ z7Ww== X-Gm-Message-State: APjAAAXZub30apdjxm/5zvO+COgJliN3sBJbU7DKXoTr2v0DLJzFvnwm vAXBF4xo7oolpHX/rye4suwB50fb X-Google-Smtp-Source: APXvYqw9upMJ3R4hmA5nEZslrDr+7wNW9+sVYWfVPPjrgoL0wyFYuFAgs5MTHG5BsnH/ncIGg8IT3g== X-Received: by 2002:a1c:8153:: with SMTP id c80mr24775007wmd.58.1575903725108; Mon, 09 Dec 2019 07:02:05 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH v2 16/18] kvm: convert "-machine kvm_shadow_mem" to an accelerator property Date: Mon, 9 Dec 2019 16:01:43 +0100 Message-Id: <1575903705-12925-17-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1575903705-12925-1-git-send-email-pbonzini@redhat.com> References: <1575903705-12925-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32e X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, elmarco@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- accel/kvm/kvm-all.c | 43 +++++++++++++++++++++++++++++++++++++++++++ hw/core/machine.c | 39 --------------------------------------- include/hw/boards.h | 2 -- qemu-options.hx | 6 +++--- target/i386/kvm.c | 2 +- vl.c | 4 ++++ 6 files changed, 51 insertions(+), 45 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index ca00daa..f0b9294 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -41,6 +41,7 @@ #include "hw/irq.h" #include "sysemu/sev.h" #include "sysemu/balloon.h" +#include "qapi/visitor.h" =20 #include "hw/boards.h" =20 @@ -92,6 +93,7 @@ struct KVMState int max_nested_state_len; int many_ioeventfds; int intx_set_mask; + int kvm_shadow_mem; bool sync_mmu; bool manual_dirty_log_protect; /* The man page (and posix) say ioctl numbers are signed int, but @@ -2940,6 +2942,40 @@ static bool kvm_accel_has_memory(MachineState *ms, A= ddressSpace *as, return false; } =20 +static void kvm_get_kvm_shadow_mem(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + KVMState *s =3D KVM_STATE(obj); + int64_t value =3D s->kvm_shadow_mem; + + visit_type_int(v, name, &value, errp); +} + +static void kvm_set_kvm_shadow_mem(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + KVMState *s =3D KVM_STATE(obj); + Error *error =3D NULL; + int64_t value; + + visit_type_int(v, name, &value, &error); + if (error) { + error_propagate(errp, error); + return; + } + + s->kvm_shadow_mem =3D value; +} + +static void kvm_accel_instance_init(Object *obj) +{ + KVMState *s =3D KVM_STATE(obj); + + s->kvm_shadow_mem =3D -1; +} + static void kvm_accel_class_init(ObjectClass *oc, void *data) { AccelClass *ac =3D ACCEL_CLASS(oc); @@ -2947,11 +2983,18 @@ static void kvm_accel_class_init(ObjectClass *oc, v= oid *data) ac->init_machine =3D kvm_init; ac->has_memory =3D kvm_accel_has_memory; ac->allowed =3D &kvm_allowed; + + object_class_property_add(oc, "kvm-shadow-mem", "int", + kvm_get_kvm_shadow_mem, kvm_set_kvm_shadow_mem, + NULL, NULL, &error_abort); + object_class_property_set_description(oc, "kvm-shadow-mem", + "KVM shadow MMU size", &error_abort); } =20 static const TypeInfo kvm_accel_type =3D { .name =3D TYPE_KVM_ACCEL, .parent =3D TYPE_ACCEL, + .instance_init =3D kvm_accel_instance_init, .class_init =3D kvm_accel_class_init, .instance_size =3D sizeof(KVMState), }; diff --git a/hw/core/machine.c b/hw/core/machine.c index d7a0356..bfb5f6f 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -211,33 +211,6 @@ static void machine_set_kernel_irqchip(Object *obj, Vi= sitor *v, } } =20 -static void machine_get_kvm_shadow_mem(Object *obj, Visitor *v, - const char *name, void *opaque, - Error **errp) -{ - MachineState *ms =3D MACHINE(obj); - int64_t value =3D ms->kvm_shadow_mem; - - visit_type_int(v, name, &value, errp); -} - -static void machine_set_kvm_shadow_mem(Object *obj, Visitor *v, - const char *name, void *opaque, - Error **errp) -{ - MachineState *ms =3D MACHINE(obj); - Error *error =3D NULL; - int64_t value; - - visit_type_int(v, name, &value, &error); - if (error) { - error_propagate(errp, error); - return; - } - - ms->kvm_shadow_mem =3D value; -} - static char *machine_get_kernel(Object *obj, Error **errp) { MachineState *ms =3D MACHINE(obj); @@ -785,12 +758,6 @@ static void machine_class_init(ObjectClass *oc, void *= data) object_class_property_set_description(oc, "kernel-irqchip", "Configure KVM in-kernel irqchip", &error_abort); =20 - object_class_property_add(oc, "kvm-shadow-mem", "int", - machine_get_kvm_shadow_mem, machine_set_kvm_shadow_mem, - NULL, NULL, &error_abort); - object_class_property_set_description(oc, "kvm-shadow-mem", - "KVM shadow MMU size", &error_abort); - object_class_property_add_str(oc, "kernel", machine_get_kernel, machine_set_kernel, &error_abort); object_class_property_set_description(oc, "kernel", @@ -892,7 +859,6 @@ static void machine_initfn(Object *obj) =20 ms->kernel_irqchip_allowed =3D true; ms->kernel_irqchip_split =3D mc->default_kernel_irqchip_split; - ms->kvm_shadow_mem =3D -1; ms->dump_guest_core =3D true; ms->mem_merge =3D true; ms->enable_graphics =3D true; @@ -963,11 +929,6 @@ bool machine_kernel_irqchip_split(MachineState *machin= e) return machine->kernel_irqchip_split; } =20 -int machine_kvm_shadow_mem(MachineState *machine) -{ - return machine->kvm_shadow_mem; -} - int machine_phandle_start(MachineState *machine) { return machine->phandle_start; diff --git a/include/hw/boards.h b/include/hw/boards.h index cdcf481..46119eb 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -66,7 +66,6 @@ bool machine_usb(MachineState *machine); bool machine_kernel_irqchip_allowed(MachineState *machine); bool machine_kernel_irqchip_required(MachineState *machine); bool machine_kernel_irqchip_split(MachineState *machine); -int machine_kvm_shadow_mem(MachineState *machine); int machine_phandle_start(MachineState *machine); bool machine_dump_guest_core(MachineState *machine); bool machine_mem_merge(MachineState *machine); @@ -278,7 +277,6 @@ struct MachineState { bool kernel_irqchip_allowed; bool kernel_irqchip_required; bool kernel_irqchip_split; - int kvm_shadow_mem; char *dtb; char *dumpdtb; int phandle_start; diff --git a/qemu-options.hx b/qemu-options.hx index 6f12b31..779c8af 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -34,7 +34,6 @@ DEF("machine", HAS_ARG, QEMU_OPTION_machine, \ " supported accelerators are kvm, xen, hax, hvf, whpx o= r tcg (default: tcg)\n" " kernel_irqchip=3Don|off|split controls accelerated ir= qchip support (default=3Doff)\n" " vmport=3Don|off|auto controls emulation of vmport (de= fault: auto)\n" - " kvm_shadow_mem=3Dsize of KVM shadow MMU in bytes\n" " dump-guest-core=3Don|off include guest memory in a co= re dump (default=3Don)\n" " mem-merge=3Don|off controls memory merge support (def= ault: on)\n" " aes-key-wrap=3Don|off controls support for AES key wr= apping (default=3Don)\n" @@ -74,8 +73,6 @@ Controls in-kernel irqchip support for the chosen acceler= ator when available. Enables emulation of VMWare IO port, for vmmouse etc. auto says to select = the value based on accel. For accel=3Dxen the default is off otherwise the def= ault is on. -@item kvm_shadow_mem=3Dsize -Defines the size of the KVM shadow MMU. @item dump-guest-core=3Don|off Include guest memory in a core dump. The default is on. @item mem-merge=3Don|off @@ -118,6 +115,7 @@ DEF("accel", HAS_ARG, QEMU_OPTION_accel, "-accel [accel=3D]accelerator[,prop[=3Dvalue][,...]]\n" " select accelerator (kvm, xen, hax, hvf, whpx or tcg; = use 'help' for a list)\n" " igd-passthru=3Don|off (enable Xen integrated Intel gr= aphics passthrough, default=3Doff)\n" + " kvm-shadow-mem=3Dsize of KVM shadow MMU in bytes\n" " tb-size=3Dn (TCG translation block cache size)\n" " thread=3Dsingle|multi (enable multi-threaded TCG)\n",= QEMU_ARCH_ALL) STEXI @@ -131,6 +129,8 @@ fails to initialize. @item igd-passthru=3Don|off When Xen is in use, this option controls whether Intel integrated graphics devices can be passed through to the guest (default=3Doff) +@item kvm-shadow-mem=3Dsize +Defines the size of the KVM shadow MMU. @item tb-size=3D@var{n} Controls the size (in MiB) of the TCG translation block cache. @item thread=3Dsingle|multi diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 1d10046..62ce681 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -2163,7 +2163,7 @@ int kvm_arch_init(MachineState *ms, KVMState *s) } qemu_register_reset(kvm_unpoison_all, NULL); =20 - shadow_mem =3D machine_kvm_shadow_mem(ms); + shadow_mem =3D object_property_get_int(OBJECT(s), "kvm-shadow-mem", &e= rror_abort); if (shadow_mem !=3D -1) { shadow_mem /=3D 4096; ret =3D kvm_vm_ioctl(s, KVM_SET_NR_MMU_PAGES, shadow_mem); diff --git a/vl.c b/vl.c index ee872f2..3678522 100644 --- a/vl.c +++ b/vl.c @@ -2639,6 +2639,10 @@ static int machine_set_property(void *opaque, object_register_sugar_prop(ACCEL_CLASS_NAME("xen"), qom_name, valu= e); return 0; } + if (g_str_equal(qom_name, "kvm-shadow-mem")) { + object_register_sugar_prop(ACCEL_CLASS_NAME("kvm"), qom_name, valu= e); + return 0; + } =20 return object_parse_property_opt(opaque, name, value, "type", errp); } --=20 1.8.3.1