From nobody Wed May 1 22:02:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1575285478; cv=none; d=zohomail.com; s=zohoarc; b=ImHO6NcmjgV6NaykZyX5mElQxF4zlBYqG/W0w/NshCeslqOTxPPJ5TmVbIcT3GP1T9OFgvR4YAfBDNtYw4qEjqNrbNe5Iz+YCZrGIS7ISLSo3Zdk4BMLcI3RibRConMD6s2UumC+PCuL/hWdCOkE5pPzEpHvezK6YN54zWjvLVg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575285478; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=my4cnSuI+j6XnWCPkucEiVTY/nyVSH0ToCd8lLGAIgU=; b=OvbX8szRkknZz7l2ad8fYSUn8lPlXWcrgsTuXLnzmXdfL9kco23B0IuNTMLDotkypf5elLYtjPV6QzQV7nbvyPvZGubcc+24vKd83RS+EvEUrOQSqgy0Cu92kJ6ROmd3VPRIwB2OYeUQAkSTVZo/TJr/TOfGaHf8koq0/e9NHyo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1575285478785471.56440100513373; Mon, 2 Dec 2019 03:17:58 -0800 (PST) Received: from localhost ([::1]:34206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibjiH-0004FO-DH for importer@patchew.org; Mon, 02 Dec 2019 06:17:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41190) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibjgU-0003Fy-KW for qemu-devel@nongnu.org; Mon, 02 Dec 2019 06:16:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibjgT-0000IE-Bw for qemu-devel@nongnu.org; Mon, 02 Dec 2019 06:16:06 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:50860 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibjgS-0000Gk-WD for qemu-devel@nongnu.org; Mon, 02 Dec 2019 06:16:05 -0500 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8BD4CBE6F78E38C4A1BD; Mon, 2 Dec 2019 19:15:59 +0800 (CST) Received: from HGHY2P002143101.china.huawei.com (10.184.39.213) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Dec 2019 19:15:51 +0800 From: To: , , , , Subject: [PATCH] virtio-serial-bus: fix memory leak while attach virtio-serial-bus Date: Mon, 2 Dec 2019 19:15:43 +0800 Message-ID: <1575285343-21864-1-git-send-email-pannengyuan@huawei.com> X-Mailer: git-send-email 2.7.2.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.184.39.213] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liyiting@huawei.com, kuhn.chenqun@huawei.com, PanNengyuan , qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: PanNengyuan ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in virtio_serial_device_unrealize, the memory leak stack is as bellow: Direct leak of 1290240 byte(s) in 180 object(s) allocated from: #0 0x7fc9bfc27560 in calloc (/usr/lib64/libasan.so.3+0xc7560) #1 0x7fc9bed6f015 in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x50015) #2 0x5650e02b83e7 in virtio_add_queue /mnt/sdb/qemu-4.2.0-rc0/hw/virtio= /virtio.c:2327 #3 0x5650e02847b5 in virtio_serial_device_realize /mnt/sdb/qemu-4.2.0-r= c0/hw/char/virtio-serial-bus.c:1089 #4 0x5650e02b56a7 in virtio_device_realize /mnt/sdb/qemu-4.2.0-rc0/hw/v= irtio/virtio.c:3504 #5 0x5650e03bf031 in device_set_realized /mnt/sdb/qemu-4.2.0-rc0/hw/cor= e/qdev.c:876 #6 0x5650e0531efd in property_set_bool /mnt/sdb/qemu-4.2.0-rc0/qom/obje= ct.c:2080 #7 0x5650e053650e in object_property_set_qobject /mnt/sdb/qemu-4.2.0-rc= 0/qom/qom-qobject.c:26 #8 0x5650e0533e14 in object_property_set_bool /mnt/sdb/qemu-4.2.0-rc0/q= om/object.c:1338 #9 0x5650e04c0e37 in virtio_pci_realize /mnt/sdb/qemu-4.2.0-rc0/hw/virt= io/virtio-pci.c:1801 Reported-by: Euler Robot Signed-off-by: PanNengyuan --- hw/char/virtio-serial-bus.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 3325904..da9019a 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw/char/virtio-serial-bus.c @@ -1126,9 +1126,15 @@ static void virtio_serial_device_unrealize(DeviceSta= te *dev, Error **errp) { VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); VirtIOSerial *vser =3D VIRTIO_SERIAL(dev); + int i; =20 QLIST_REMOVE(vser, next); =20 + for (i =3D 0; i <=3D vser->bus.max_nr_ports; i++) { + virtio_del_queue(vdev, 2 * i); + virtio_del_queue(vdev, 2 * i + 1); + } + g_free(vser->ivqs); g_free(vser->ovqs); g_free(vser->ports_map); --=20 2.7.2.windows.1