From nobody Mon Feb 9 16:21:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1574930861; cv=none; d=zohomail.com; s=zohoarc; b=IWkhN8EHzGc0ZyqoyQytWOA6hUlErTs46EvLE/ZqSbPtcBLAdSE95vOotn7hspa4graLFGTimAGeShPcxfoI9UMxMjZLBUBzdl2bLErjxZ8/KYH97UZ1UplKz5SCqKipJSmldmFs/vadK7qRvhg5oZ46fDbn5MRBalPkhDWc/PY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574930861; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=sBLSyjeuDPI5zdfPLG7uGtP+Eg4ttsYy345q3CBAQHA=; b=Joy872R30YetYzfeXsaxFGNsKVCvlOgfJZ28xh5fDQBbecB7ffJLyUcXY0tVhdb0Pdv39GoRbvp7p8+Dea/BbRK+Ln7BKaRC3f4tZOIO5ZMSG08OJHQ1A5iNhJvEZumNoZmgwZKvYJaa12B2AC/lwN4Lx+V4ppa08F7RsjpvI34= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157493086133367.57997612561383; Thu, 28 Nov 2019 00:47:41 -0800 (PST) Received: from localhost ([::1]:46576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaFSb-0004TZ-FR for importer@patchew.org; Thu, 28 Nov 2019 03:47:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36264) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaFR0-0003pg-DF for qemu-devel@nongnu.org; Thu, 28 Nov 2019 03:45:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaFQz-0004Is-2P for qemu-devel@nongnu.org; Thu, 28 Nov 2019 03:45:58 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2269 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iaFM5-0008P6-Ho; Thu, 28 Nov 2019 03:40:53 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 685EEA3C9EBAACD49D55; Thu, 28 Nov 2019 16:40:43 +0800 (CST) Received: from HGHY2P002143101.china.huawei.com (10.184.39.213) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.439.0; Thu, 28 Nov 2019 16:40:34 +0800 From: To: , , Subject: [PATCH] block/nbd: fix memory leak in nbd_open() Date: Thu, 28 Nov 2019 16:40:10 +0800 Message-ID: <1574930410-43468-1-git-send-email-pannengyuan@huawei.com> X-Mailer: git-send-email 2.7.2.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.184.39.213] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liyiting@huawei.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, PanNengyuan , qemu-devel@nongnu.org, kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: PanNengyuan In currently implementation there will be a memory leak when nbd_client_connect() returns error status. Here is an easy way to reproduce: 1. run qemu-iotests as follow and check the result with asan: ./check -raw 143 Following is the asan output backtrack: Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x7f629688a560 in calloc (/usr/lib64/libasan.so.3+0xc7560) #1 0x7f6295e7e015 in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x50015) #2 0x56281dab4642 in qobject_input_start_struct /mnt/sdb/qemu-4.2.0-rc= 0/qapi/qobject-input-visitor.c:295 #3 0x56281dab1a04 in visit_start_struct /mnt/sdb/qemu-4.2.0-rc0/qapi/q= api-visit-core.c:49 #4 0x56281dad1827 in visit_type_SocketAddress qapi/qapi-visit-sockets.= c:386 #5 0x56281da8062f in nbd_config /mnt/sdb/qemu-4.2.0-rc0/block/nbd.c:17= 16 #6 0x56281da8062f in nbd_process_options /mnt/sdb/qemu-4.2.0-rc0/block= /nbd.c:1829 #7 0x56281da8062f in nbd_open /mnt/sdb/qemu-4.2.0-rc0/block/nbd.c:1873 Direct leak of 15 byte(s) in 1 object(s) allocated from: #0 0x7f629688a3a0 in malloc (/usr/lib64/libasan.so.3+0xc73a0) #1 0x7f6295e7dfbd in g_malloc (/usr/lib64/libglib-2.0.so.0+0x4ffbd) #2 0x7f6295e96ace in g_strdup (/usr/lib64/libglib-2.0.so.0+0x68ace) #3 0x56281da804ac in nbd_process_options /mnt/sdb/qemu-4.2.0-rc0/block/= nbd.c:1834 #4 0x56281da804ac in nbd_open /mnt/sdb/qemu-4.2.0-rc0/block/nbd.c:1873 Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f629688a3a0 in malloc (/usr/lib64/libasan.so.3+0xc73a0) #1 0x7f6295e7dfbd in g_malloc (/usr/lib64/libglib-2.0.so.0+0x4ffbd) #2 0x7f6295e96ace in g_strdup (/usr/lib64/libglib-2.0.so.0+0x68ace) #3 0x56281dab41a3 in qobject_input_type_str_keyval /mnt/sdb/qemu-4.2.= 0-rc0/qapi/qobject-input-visitor.c:536 #4 0x56281dab2ee9 in visit_type_str /mnt/sdb/qemu-4.2.0-rc0/qapi/qapi= -visit-core.c:297 #5 0x56281dad0fa1 in visit_type_UnixSocketAddress_members qapi/qapi-vi= sit-sockets.c:141 #6 0x56281dad17b6 in visit_type_SocketAddress_members qapi/qapi-vi= sit-sockets.c:366 #7 0x56281dad186a in visit_type_SocketAddress qapi/qapi-visit-socke= ts.c:393 #8 0x56281da8062f in nbd_config /mnt/sdb/qemu-4.2.0-rc0/block/nbd.c:1= 716 #9 0x56281da8062f in nbd_process_options /mnt/sdb/qemu-4.2.0-rc0/bloc= k/nbd.c:1829 #10 0x56281da8062f in nbd_open /mnt/sdb/qemu-4.2.0-rc0/block/nbd.c:1873 Reported-by: Euler Robot Signed-off-by: PanNengyuan --- block/nbd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index 1239761..bc40a25 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -1881,6 +1881,11 @@ static int nbd_open(BlockDriverState *bs, QDict *opt= ions, int flags, =20 ret =3D nbd_client_connect(bs, errp); if (ret < 0) { + object_unref(OBJECT(s->tlscreds)); + qapi_free_SocketAddress(s->saddr); + g_free(s->export); + g_free(s->tlscredsid); + g_free(s->x_dirty_bitmap); return ret; } /* successfully connected */ --=20 2.7.2.windows.1