From nobody Sat May 18 19:24:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1574685512; cv=none; d=zohomail.com; s=zohoarc; b=b373krtQxUvROZel9qrlmc7FxGD4tJ7rmJFtdqX0JzvZVwrsGUrCO1sCPARsSLSp53tMDvLlk5EDMKoNsM+RxpgjkxVH7fh6dWT3Bb4dLjTSkrGJR5P8GZhUmP2SbuOEbm6QP6qAR3SylTSyWjZXdf7oXdM1dJ6kX4u6m8K4wQI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574685512; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=YhGSQLV2D7XNSxzSxCbubGu4XO9QMlaCo9qKLd5hMtY=; b=NRwoRyp1S/FLiOQfkxSvWYKfe2nu1Al7hWtLuXmpvf1qIVoUsWNtZacSiipv6Hnhvrbkl0gnPAR4CqSlF5I0qBVfXaTYwqgtv1lMLkGSQ/nV+oT5grFpOGfchFNrJ1uGkL3/L9s04j4L3qeHp2HIfGOQSZo6HoLoi67aeQIO3Rw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15746855123101021.9901099479592; Mon, 25 Nov 2019 04:38:32 -0800 (PST) Received: from localhost ([::1]:43112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZDdP-0007wi-7V for importer@patchew.org; Mon, 25 Nov 2019 07:38:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33609) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZDaW-0005Cg-IS for qemu-devel@nongnu.org; Mon, 25 Nov 2019 07:35:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZDaV-00063m-Fv for qemu-devel@nongnu.org; Mon, 25 Nov 2019 07:35:32 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:48886 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iZDaQ-0005tw-U9; Mon, 25 Nov 2019 07:35:27 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 2FFE3C02C28C39762234; Mon, 25 Nov 2019 20:35:15 +0800 (CST) Received: from HGHY2P002143101.china.huawei.com (10.184.39.213) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Mon, 25 Nov 2019 20:35:05 +0800 From: To: Subject: [PATCH V2] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue Date: Mon, 25 Nov 2019 20:34:51 +0800 Message-ID: <1574685291-38176-1-git-send-email-pannengyuan@huawei.com> X-Mailer: git-send-email 2.7.2.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.184.39.213] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kuhn.chenqun@huawei.com, qemu-arm@nongnu.org, PanNengyuan , qemu-devel@nongnu.org, kenny.zhangjun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: PanNengyuan This fixes coverity issues 68911917: 360 CID 68911917: (NULL_RETURNS) 361. dereference: Dereferencing "source", which is known to be "NULL". 361 if (source->mask & event_mask) { 362 break; 363 } Reported-by: Euler Robot Signed-off-by: PanNengyuan --- hw/ppc/spapr_events.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 0e4c195..e355e00 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -358,6 +358,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(Spapr= MachineState *spapr, rtas_event_log_to_source(spapr, spapr_event_log_entry_type(entry)); =20 + g_assert(source); if (source->mask & event_mask) { break; } --=20 2.7.2.windows.1