From nobody Mon May 6 04:51:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574240637; cv=none; d=zoho.com; s=zohoarc; b=PQ71lXIY4cvcSPr5T+wv2E4A1i8VyCr0ctqlkmCGiHzvioX3hlWoR1O2cyaLzsxi7MEX9sa5iGQLINQaD3c7ot/kV/IJnVzwxlyiOq0GA4GbL6J+TiyeAT7RvYaCwEjdLY7OCkZ0BpQwL/5O5FbztCdIyu3vIzuAfdb89waY5yE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574240637; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=szCs7CHpwFXfeXzzTMSx7nFEjamilkWRjqiGRBdrq9w=; b=MwfXuj1v3nc+/dVB3SonsHfEaPLH5KfoPVlsDSVVJqDSx77i6HEKfjM+4kXocuekpQn2QHSvH8tJY1vfsp10bHkkmMocESWZQgxedfyOan9a1aAp/hKJGQnbhYYgiKW3glTrO7PE6tj4D7bkTrywRnlH9460Xatiz29s8VjS9Rk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1574240637024536.9404588198818; Wed, 20 Nov 2019 01:03:57 -0800 (PST) Received: from localhost ([::1]:54980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXLtz-00065J-T8 for importer@patchew.org; Wed, 20 Nov 2019 04:03:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38927) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXLsq-0004oI-FX for qemu-devel@nongnu.org; Wed, 20 Nov 2019 04:02:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXLsp-00088W-Dp for qemu-devel@nongnu.org; Wed, 20 Nov 2019 04:02:44 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:28858 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iXLsp-00088G-A6 for qemu-devel@nongnu.org; Wed, 20 Nov 2019 04:02:43 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-JW2a_bJyO7a9gNrDg-eiPA-1; Wed, 20 Nov 2019 04:02:41 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3685118B9FC1 for ; Wed, 20 Nov 2019 09:02:40 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id E11F21FA; Wed, 20 Nov 2019 09:02:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574240562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=szCs7CHpwFXfeXzzTMSx7nFEjamilkWRjqiGRBdrq9w=; b=BJFKJjdjk8f07rKh9dlZwxM5EEf/IY/5EvW0+xh1CacvFrX2Rbcpg+CUqHDp0iP+tTO2h5 efz57Dj/s1oVSw9asq19USTmTXZFUvQAJKqTQJPChSYqsANHzRviveHFd++EveLHBrKyRe p3SB6nEKsh4C/+fnIGxMXdg4X1Phjyw= From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH] tests: acpi: always retain dumped ACPI tables in case of error Date: Wed, 20 Nov 2019 10:02:40 +0100 Message-Id: <1574240560-12538-1-git-send-email-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: JW2a_bJyO7a9gNrDg-eiPA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If IASL wasn't able to parse expected file, test will just print warning "Warning! iasl couldn't parse the expected aml\n" and remove temporary table dumped from guest. Typically expected tables are always valid, with an exception when patchset introduces new tables. Make sure dumped tables are retained even if expected files are not valid, so one could have a chance to manualy check new tables. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 96803c1..3ef927e 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -437,11 +437,11 @@ static void test_acpi_asl(test_data *data) g_assert(!err || exp_err); =20 if (g_strcmp0(asl->str, exp_asl->str)) { + sdt->tmp_files_retain =3D true; if (exp_err) { fprintf(stderr, "Warning! iasl couldn't parse the expected aml\n"); } else { - sdt->tmp_files_retain =3D true; exp_sdt->tmp_files_retain =3D true; fprintf(stderr, "acpi-test: Warning! %.4s mismatch. " --=20 2.7.4