From nobody Sun May 5 10:55:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1574042201; cv=none; d=zoho.com; s=zohoarc; b=eNZaTjCnOwabA6GxM/KJVv2AoYUiJ9jqmPhX0JanetGAkZ+YlXtHBoCydjcQegRIcYil13G2r5ZZKFdgTFjCx4lCulZJyPo7ufxpNgHfd3Ns+I29QLEkFhTS6tdyay0QNJh922rnTP4kd/i1d31j1KuK5qYB03a61ca3c1/5kVs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574042201; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=yYhZsgiBGW26NGza1O20FGMJ9rUcUVwp6rHNKI0/XQ8=; b=YteDyYnMtj7CsW9IhacW2xfmtns/o3qr1MGmqaMOPus+ogFFHjhi3j6GdZHyEIIDX/Iqxcx5Fa5Ugm40Hnk5zDEk/Fs8cXVGlAhzQfs5/sdoH9mvc4nmhcmEhkuptcwEWpR1L4cLqhlT/4oUtTvOoB92hNMrdl+BgDsViPTQl1g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157404220170189.41308610637122; Sun, 17 Nov 2019 17:56:41 -0800 (PST) Received: from localhost ([::1]:57514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWWHM-0005ci-DL for importer@patchew.org; Sun, 17 Nov 2019 20:56:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34860) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWWBo-0003ZN-Fe for qemu-devel@nongnu.org; Sun, 17 Nov 2019 20:50:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWWBn-0006vG-CD for qemu-devel@nongnu.org; Sun, 17 Nov 2019 20:50:52 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:44354 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iWWBk-0006uK-KU; Sun, 17 Nov 2019 20:50:48 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 094F0E37F54E9B4B59E8; Mon, 18 Nov 2019 09:50:44 +0800 (CST) Received: from HGHY2P002143101.china.huawei.com (10.184.39.213) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 18 Nov 2019 09:50:36 +0800 From: To: Subject: [Qemu-devel][PATCH] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue Date: Mon, 18 Nov 2019 09:50:13 +0800 Message-ID: <1574041813-35408-1-git-send-email-pannengyuan@huawei.com> X-Mailer: git-send-email 2.7.2.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.184.39.213] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-Mailman-Approved-At: Sun, 17 Nov 2019 20:55:24 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, PanNengyuan , kenny.zhangjun@huawei.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: PanNengyuan source is being dereferenced before it is null checked, hence there is a potential null pointer dereference. This fixes: 360 CID 68911917: (NULL_RETURNS) 361. dereference: Dereferencing "source", which is known to be "NULL". 361 if (source->mask & event_mask) { 362 break; 363 } Reported-by: Euler Robot Signed-off-by: PanNengyuan --- hw/ppc/spapr_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 0e4c195..febd2ef 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -358,7 +358,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(Spapr= MachineState *spapr, rtas_event_log_to_source(spapr, spapr_event_log_entry_type(entry)); =20 - if (source->mask & event_mask) { + if (source && (source->mask & event_mask)) { break; } } --=20 2.7.2.windows.1