From nobody Sun May 5 05:21:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1572421508; cv=none; d=zoho.com; s=zohoarc; b=OhCDdWdppVeNT6p/TT3EyDmgHy0bAJs7mh7a4UpdOI7T66q9dEpV8Fpi9OBt/JzxlFXX8EgXsE3A3f5qnFOpNd4BkUPl8abJTO4BxbSunU3lhBwmB37t2pVj+Oy9nG/SW52C3LMgseGq00azOWMkGrRL8kMwTLVCdXkapxAo+nE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572421508; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=JHrARmXnQgG30bLECJ2oAJThALI2uMewYvTLzCfkGFc=; b=ZyPHwciUr3mngtMvSyHjD04vPeDYpDo/yG+yD+wEjZEsOiqOm8B30MH6FDFg6HHTTcPPsj6loJNxaTG/LDCwC7TOpz2uFSWL4jVkXr/0JYpnfX5c2afau/UE53dH5Zoc7SYYgm7rbCzX06IPlXCLfWNV9FyZgZhRA1w1TIt6bOQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1572421508875812.3738437034978; Wed, 30 Oct 2019 00:45:08 -0700 (PDT) Received: from localhost ([::1]:37584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPifC-0002XW-3R for importer@patchew.org; Wed, 30 Oct 2019 03:45:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59377) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPid9-0001rU-GB for qemu-devel@nongnu.org; Wed, 30 Oct 2019 03:43:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPid6-0003uV-BK for qemu-devel@nongnu.org; Wed, 30 Oct 2019 03:42:57 -0400 Received: from mga01.intel.com ([192.55.52.88]:61161) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPid6-0003Iz-2G for qemu-devel@nongnu.org; Wed, 30 Oct 2019 03:42:56 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 00:42:49 -0700 Received: from icl-2s.bj.intel.com ([10.240.193.48]) by fmsmga005.fm.intel.com with ESMTP; 30 Oct 2019 00:42:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,246,1569308400"; d="scan'208";a="400056866" From: Luwei Kang To: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com Subject: [PATCH v1 Resend] target/i386: set the CPUID level to 0x14 on old machine-type Date: Wed, 30 Oct 2019 14:28:02 +0800 Message-Id: <1572416882-41378-1-git-send-email-luwei.kang@intel.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Luwei Kang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The CPUID level need to be set to 0x14 manually on old machine-type if Intel PT is enabled in guest. e.g. in Qemu 3.1 -machine pc-i440fx-3.1 -cpu qemu64,+intel-pt will be CPUID[0].EAX(level)=3D7 and CPUID[7].EBX[25](intel-pt)=3D1. Some Intel PT capabilities are exposed by leaf 0x14 and the missing capabilities will cause some MSRs access failed. This patch add a warning message to inform the user to extend the CPUID level. Suggested-by: Eduardo Habkost Signed-off-by: Luwei Kang --- target/i386/cpu.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index a624163..f67c479 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -5440,8 +5440,12 @@ static void x86_cpu_expand_features(X86CPU *cpu, Err= or **errp) =20 /* Intel Processor Trace requires CPUID[0x14] */ if ((env->features[FEAT_7_0_EBX] & CPUID_7_0_EBX_INTEL_PT) && - kvm_enabled() && cpu->intel_pt_auto_level) { - x86_cpu_adjust_level(cpu, &cpu->env.cpuid_min_level, 0x14); + kvm_enabled()) { + if (cpu->intel_pt_auto_level) + x86_cpu_adjust_level(cpu, &cpu->env.cpuid_min_level, 0x14); + else + warn_report("Intel PT need CPUID leaf 0x14, please set " + "by \"-cpu ...,+intel-pt,level=3D0x14\""); } =20 /* CPU topology with multi-dies support requires CPUID[0x1F] */ --=20 1.8.3.1