[PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019

Aleksandar Markovic posted 12 patches 4 years, 5 months ago
Test checkpatch failed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com
Maintainers: Aleksandar Markovic <amarkovic@wavecomp.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Aurelien Jarno <aurelien@aurel32.net>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
There is a newer version of this series
.mailmap                 |    5 +-
MAINTAINERS              |   18 +-
target/mips/helper.c     |  123 +-
target/mips/helper.h     |  155 +-
target/mips/msa_helper.c | 4583 ++++++++++++++++++++++++++++++----------------
target/mips/op_helper.c  | 1010 ++++++----
target/mips/translate.c  |  512 +++++-
7 files changed, 4319 insertions(+), 2087 deletions(-)
[PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Posted by Aleksandar Markovic 4 years, 5 months ago
From: Aleksandar Markovic <amarkovic@wavecomp.com>

Mostly cosmetic changes.

v5->v6:

  - minor corrections (r-b, t-b marks) in commit messages
  - added patches 11 and 12

v4->v5:

  - minor correction in patch on helper.c
  - added patches 9 and 10

v3->v4:

  - added patches 7 and 8

v2->v3:

  - removed all patches that were already integrated
  - patches 1 and 2 are improved from v2
  - added patches 3-6

v1->v2:

  - minor corrections to satisfy reviews
  - added several more patches

Aleksandar Markovic (12):
  target/mips: Clean up helper.c
  target/mips: Clean up op_helper.c
  MAINTAINERS: Update mail address of Aleksandar Rikalo
  target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
  target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
  target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
  target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
  target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
  target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
  target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
  target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>
  target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>

 .mailmap                 |    5 +-
 MAINTAINERS              |   18 +-
 target/mips/helper.c     |  123 +-
 target/mips/helper.h     |  155 +-
 target/mips/msa_helper.c | 4583 ++++++++++++++++++++++++++++++----------------
 target/mips/op_helper.c  | 1010 ++++++----
 target/mips/translate.c  |  512 +++++-
 7 files changed, 4319 insertions(+), 2087 deletions(-)

-- 
2.7.4


Re: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Posted by no-reply@patchew.org 4 years, 5 months ago
Patchew URL: https://patchew.org/QEMU/1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Type: series
Message-id: 1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
36112c6 target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>
c385d15 target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>
1cb06f9 target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
c163234 target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
e291f35 target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
6e9e5a5 target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
d6312d1 target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
8825acf target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
fc46b54 target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
217fbe2 MAINTAINERS: Update mail address of Aleksandar Rikalo
5e0227b target/mips: Clean up op_helper.c
a8fa795 target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/12 Checking commit a8fa7957997d (target/mips: Clean up helper.c)
2/12 Checking commit 5e0227b2346c (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1059: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/12 Checking commit 217fbe216ae8 (MAINTAINERS: Update mail address of Aleksandar Rikalo)
4/12 Checking commit fc46b54fe0a0 (target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>)
5/12 Checking commit 8825acf5951f (target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>)
6/12 Checking commit d6312d1d6fe6 (target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>)
7/12 Checking commit 6e9e5a5404a5 (target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/12 Checking commit e291f3532f5d (target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>)
9/12 Checking commit c16323490f9c (target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>)
10/12 Checking commit 1cb06f9ae607 (target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>)
11/12 Checking commit c385d15ca204 (target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>)
12/12 Checking commit 36112c61daf9 (target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Posted by no-reply@patchew.org 4 years, 5 months ago
Patchew URL: https://patchew.org/QEMU/1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Type: series
Message-id: 1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20191018092136.26581-1-eric.auger@redhat.com -> patchew/20191018092136.26581-1-eric.auger@redhat.com
 * [new tag]         patchew/20191023082431.30780-1-pbonzini@redhat.com -> patchew/20191023082431.30780-1-pbonzini@redhat.com
 - [tag update]      patchew/cover.1570208781.git.maozhongyi@cmss.chinamobile.com -> patchew/cover.1570208781.git.maozhongyi@cmss.chinamobile.com
Switched to a new branch 'test'
d09fef5 target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>
30a6202 target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>
308fc7a target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
32248b0 target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
dad828f target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
f1c8a56 target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
f5f90bf target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
ce348ae target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
704c174 target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
4fcd018 MAINTAINERS: Update mail address of Aleksandar Rikalo
7311d0a target/mips: Clean up op_helper.c
c464bc9 target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/12 Checking commit c464bc9194b7 (target/mips: Clean up helper.c)
2/12 Checking commit 7311d0a646ea (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1059: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/12 Checking commit 4fcd018cf015 (MAINTAINERS: Update mail address of Aleksandar Rikalo)
4/12 Checking commit 704c174cc449 (target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>)
5/12 Checking commit ce348ae7e85b (target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>)
6/12 Checking commit f5f90bf94e05 (target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>)
7/12 Checking commit f1c8a567a523 (target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/12 Checking commit dad828f28cc7 (target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>)
9/12 Checking commit 32248b0e5194 (target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>)
10/12 Checking commit 308fc7adf033 (target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>)
11/12 Checking commit 30a62025b560 (target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>)
12/12 Checking commit d09fef515e58 (target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Posted by no-reply@patchew.org 4 years, 5 months ago
Patchew URL: https://patchew.org/QEMU/1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Type: series
Message-id: 1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
67bb877 target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>
e2de4dc target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>
5a7dfbf target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
48614e3 target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
b71fd4f target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
0ab1f37 target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
f6c7c8a target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
6e09061 target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
abc5063 target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
4c9a2be MAINTAINERS: Update mail address of Aleksandar Rikalo
b1f1de4 target/mips: Clean up op_helper.c
18f4171 target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/12 Checking commit 18f417113620 (target/mips: Clean up helper.c)
2/12 Checking commit b1f1de430f2e (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1059: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/12 Checking commit 4c9a2bed5479 (MAINTAINERS: Update mail address of Aleksandar Rikalo)
4/12 Checking commit abc5063443d3 (target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>)
5/12 Checking commit 6e09061f3d43 (target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>)
6/12 Checking commit f6c7c8ad441b (target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>)
7/12 Checking commit 0ab1f37b65bf (target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/12 Checking commit b71fd4fe41cc (target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>)
9/12 Checking commit 48614e367297 (target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>)
10/12 Checking commit 5a7dfbf52558 (target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>)
11/12 Checking commit e2de4dc7eb94 (target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>)
12/12 Checking commit 67bb8777638a (target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Posted by no-reply@patchew.org 4 years, 5 months ago
Patchew URL: https://patchew.org/QEMU/1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Type: series
Message-id: 1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
4a47a90 target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>
80b4880 target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>
045f415 target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
861d76a target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
39d4345 target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
a86a459 target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
5714c4f target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
17d744e target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
bd4d22e target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
e271939 MAINTAINERS: Update mail address of Aleksandar Rikalo
9938bd3 target/mips: Clean up op_helper.c
fc20b79 target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/12 Checking commit fc20b79dea40 (target/mips: Clean up helper.c)
2/12 Checking commit 9938bd3b2fb2 (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1059: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/12 Checking commit e2719394e1b4 (MAINTAINERS: Update mail address of Aleksandar Rikalo)
4/12 Checking commit bd4d22e72ce9 (target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>)
5/12 Checking commit 17d744ed246a (target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>)
6/12 Checking commit 5714c4f6f3ae (target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>)
7/12 Checking commit a86a45905bb5 (target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/12 Checking commit 39d4345977ca (target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>)
9/12 Checking commit 861d76a00b7b (target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>)
10/12 Checking commit 045f415cf74c (target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>)
11/12 Checking commit 80b488087528 (target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>)
12/12 Checking commit 4a47a90d1e70 (target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1571685097-15175-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com