[PATCH 0/2] xics, xive: Add some missing comments

Greg Kurz posted 2 patches 2 weeks ago
Failed in applying to current master (apply log)
hw/intc/xics.c |    8 ++++++++
hw/intc/xive.c |   12 ++++++++++++
2 files changed, 20 insertions(+)

[PATCH 0/2] xics, xive: Add some missing comments

Posted by Greg Kurz 2 weeks ago
As noted by Markus, the reason why a device type isn't user creatable
should be documented.

These patches can be squashed into the ones that made the devices
non user-creatable, or applied as follow-ups, at the discretion of
the maintainer.

--
Greg

---

Greg Kurz (2):
      xive: Add /* Reason */ comment to "->user_creatable = false" statements
      xics: Add /* Reason */ comment to "->user_creatable = false" statements


 hw/intc/xics.c |    8 ++++++++
 hw/intc/xive.c |   12 ++++++++++++
 2 files changed, 20 insertions(+)


Re: [PATCH 0/2] xics, xive: Add some missing comments

Posted by David Gibson 2 weeks ago
On Mon, Oct 07, 2019 at 03:42:58PM +0200, Greg Kurz wrote:
> As noted by Markus, the reason why a device type isn't user creatable
> should be documented.
> 
> These patches can be squashed into the ones that made the devices
> non user-creatable, or applied as follow-ups, at the discretion of
> the maintainer.

Applied and squashed.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson