[PATCH ci-fix 0/8] fix various memory leaks (but not all)

Paolo Bonzini posted 8 patches 4 years, 5 months ago
Test docker-mingw@fedora passed
Test checkpatch failed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu failed
Test asan failed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1569936988-635-1-git-send-email-pbonzini@redhat.com
Maintainers: Fam Zheng <fam@euphon.net>, Aleksandar Markovic <amarkovic@wavecomp.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Thomas Huth <huth@tuxfamily.org>, Helge Deller <deller@gmx.de>, John Snow <jsnow@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Richard Henderson <rth@twiddle.net>, Aleksandar Rikalo <arikalo@wavecomp.com>, Michael Walle <michael@walle.cc>, "Hervé Poussineau" <hpoussin@reactos.org>, "Alex Bennée" <alex.bennee@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>
disas/cris.c                | 59 ++++++++++++++++++++++-----------------------
hw/hppa/dino.c              |  1 +
hw/hppa/machine.c           |  4 ++-
hw/ide/cmd646.c             |  1 +
hw/m68k/mcf5208.c           |  2 ++
hw/microblaze/boot.c        |  1 +
hw/mips/mips_int.c          |  1 +
hw/mips/mips_jazz.c         |  2 ++
hw/timer/lm32_timer.c       |  6 ++---
hw/timer/milkymist-sysctl.c | 10 ++++----
tests/docker/test-debug     |  1 +
11 files changed, 49 insertions(+), 39 deletions(-)
[PATCH ci-fix 0/8] fix various memory leaks (but not all)
Posted by Paolo Bonzini 4 years, 5 months ago
Hi all, the asan and docker-clang@ubuntu tests are failing due
to memory leaks, mostly in instance_init but some also in
realize.  The former are caught by device-introspect-test,
the latter by boot-serial-test.

This series fixes the simplest ones.  ARM and aarch64 failures
remain so I'm disabling LeakSanitizer tests in CI with the last
patch.

Paolo

Paolo Bonzini (8):
  ide: fix leak from qemu_allocate_irqs
  microblaze: fix leak of fdevice tree blob
  mcf5208: fix leak from qemu_allocate_irqs
  hppa: fix leak from g_strdup_printf
  mips: fix memory leaks in board initialization
  cris: do not leak struct cris_disasm_data
  lm32: do not leak memory on object_new/object_unref
  docker: test-debug: disable LeakSanitizer

 disas/cris.c                | 59 ++++++++++++++++++++++-----------------------
 hw/hppa/dino.c              |  1 +
 hw/hppa/machine.c           |  4 ++-
 hw/ide/cmd646.c             |  1 +
 hw/m68k/mcf5208.c           |  2 ++
 hw/microblaze/boot.c        |  1 +
 hw/mips/mips_int.c          |  1 +
 hw/mips/mips_jazz.c         |  2 ++
 hw/timer/lm32_timer.c       |  6 ++---
 hw/timer/milkymist-sysctl.c | 10 ++++----
 tests/docker/test-debug     |  1 +
 11 files changed, 49 insertions(+), 39 deletions(-)

-- 
1.8.3.1


Re: [PATCH ci-fix 0/8] fix various memory leaks (but not all)
Posted by no-reply@patchew.org 4 years, 5 months ago
Patchew URL: https://patchew.org/QEMU/1569936988-635-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1569936988-635-1-git-send-email-pbonzini@redhat.com
Subject: [PATCH ci-fix 0/8] fix various memory leaks (but not all)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
82a01e4 docker: test-debug: disable LeakSanitizer
a641027 lm32: do not leak memory on object_new/object_unref
4371ce1 cris: do not leak struct cris_disasm_data
4528288 mips: fix memory leaks in board initialization
e06bae0 hppa: fix leak from g_strdup_printf
becd3c3 mcf5208: fix leak from qemu_allocate_irqs
8b51d7a microblaze: fix leak of fdevice tree blob
02eaa60 ide: fix leak from qemu_allocate_irqs

=== OUTPUT BEGIN ===
1/8 Checking commit 02eaa60b9e2a (ide: fix leak from qemu_allocate_irqs)
2/8 Checking commit 8b51d7aff31f (microblaze: fix leak of fdevice tree blob)
3/8 Checking commit becd3c365fdf (mcf5208: fix leak from qemu_allocate_irqs)
4/8 Checking commit e06bae052258 (hppa: fix leak from g_strdup_printf)
5/8 Checking commit 4528288f43ef (mips: fix memory leaks in board initialization)
6/8 Checking commit 4371ce1f2f81 (cris: do not leak struct cris_disasm_data)
ERROR: space prohibited between function name and open parenthesis '('
#23: FILE: disas/cris.c:1298:
+cris_parse_disassembler_options (struct cris_disasm_data *disdata,

ERROR: code indent should never use tabs
#24: FILE: disas/cris.c:1299:
+^I^I^I^I char *disassembler_options,$

ERROR: space prohibited between function name and open parenthesis '('
#39: FILE: disas/cris.c:1305:
+       || (strcmp (disassembler_options, "nocase") != 0));

ERROR: space prohibited between function name and open parenthesis '('
#55: FILE: disas/cris.c:2734:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#56: FILE: disas/cris.c:2735:
+^I^I^I^I   cris_dis_v0_v10);$

ERROR: space prohibited between function name and open parenthesis '('
#69: FILE: disas/cris.c:2746:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#70: FILE: disas/cris.c:2747:
+^I^I^I^I   cris_dis_v32);$

ERROR: space prohibited between function name and open parenthesis '('
#83: FILE: disas/cris.c:2761:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#84: FILE: disas/cris.c:2762:
+^I^I^I^I   cris_dis_common_v10_v32);$

ERROR: space prohibited between function name and open parenthesis '('
#97: FILE: disas/cris.c:2774:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#98: FILE: disas/cris.c:2775:
+^I^I^I^I   cris_dis_v0_v10);$

ERROR: space prohibited between function name and open parenthesis '('
#111: FILE: disas/cris.c:2787:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#112: FILE: disas/cris.c:2788:
+^I^I^I^I   cris_dis_v32);$

ERROR: space prohibited between function name and open parenthesis '('
#125: FILE: disas/cris.c:2801:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#126: FILE: disas/cris.c:2802:
+^I^I^I^I   cris_dis_common_v10_v32);$

total: 15 errors, 0 warnings, 107 lines checked

Patch 6/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/8 Checking commit a64102750d5f (lm32: do not leak memory on object_new/object_unref)
8/8 Checking commit 82a01e41c267 (docker: test-debug: disable LeakSanitizer)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1569936988-635-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com