From nobody Wed Nov 12 08:37:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1569416587; cv=none; d=zoho.com; s=zohoarc; b=gMmtv0xD7NLwhP7pOrusxnZhFYjJlMmSle/rToVBQilODiRHB540opKPj5/iSDeSaIUMNtEtV3cSSvrs/BBXoxCWNUvIQm2c/vJMD6tu6zWsCyLNdL/maYL+kfCf22XGAtgWsKrbnSzMnzJUOduRI4Fmhj2NNjHiWxasqjwR5TE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569416587; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=zBpSum8NDFtKEUvyJjj1ScxAFRMrAYEJAjySo/Jvgug=; b=fTLnHYwmzpZxaJdD4znY81b/EeAL/Bhc0E4I3pWFwjocvR4DzoA/LpTnB/xgVQ6ajbYnu4rQWCMyj8u9YCfn344MuWJeNORPpS7PZ7YuwBbtB74Z7VfAa1EY4t/U/bF6wpJwFN0s07TECIZIBXPD8uaU0UHCT7lzIaTu/UGf+0k= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569416587167514.4027044220571; Wed, 25 Sep 2019 06:03:07 -0700 (PDT) Received: from localhost ([::1]:49672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD6wL-0008RB-Df for importer@patchew.org; Wed, 25 Sep 2019 09:02:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57991) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD6gq-0001TL-FF for qemu-devel@nongnu.org; Wed, 25 Sep 2019 08:46:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iD6go-0002Lw-Uu for qemu-devel@nongnu.org; Wed, 25 Sep 2019 08:46:40 -0400 Received: from mx2.rt-rk.com ([89.216.37.149]:56141 helo=mail.rt-rk.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iD6go-0002Go-MO for qemu-devel@nongnu.org; Wed, 25 Sep 2019 08:46:38 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.rt-rk.com (Postfix) with ESMTP id 462C81A23C3; Wed, 25 Sep 2019 14:46:22 +0200 (CEST) Received: from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local [10.10.13.43]) by mail.rt-rk.com (Postfix) with ESMTPSA id 170EE1A23CF; Wed, 25 Sep 2019 14:46:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at rt-rk.com From: Aleksandar Markovic To: qemu-devel@nongnu.org Subject: [PATCH v2 19/20] target/mips: msa: Simplify and move helper for MOVE.V Date: Wed, 25 Sep 2019 14:46:11 +0200 Message-Id: <1569415572-19635-20-git-send-email-aleksandar.markovic@rt-rk.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1569415572-19635-1-git-send-email-aleksandar.markovic@rt-rk.com> References: <1569415572-19635-1-git-send-email-aleksandar.markovic@rt-rk.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 89.216.37.149 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arikalo@wavecomp.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Aleksandar Markovic Achieves clearer code and slightly better performance. Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 2 +- target/mips/msa_helper.c | 31 +++++++++++++------------------ 2 files changed, 14 insertions(+), 19 deletions(-) diff --git a/target/mips/helper.h b/target/mips/helper.h index cc216f7..3b1a965 100644 --- a/target/mips/helper.h +++ b/target/mips/helper.h @@ -887,6 +887,7 @@ DEF_HELPER_4(msa_mod_s_h, void, env, i32, i32, i32) DEF_HELPER_4(msa_mod_s_w, void, env, i32, i32, i32) DEF_HELPER_4(msa_mod_s_d, void, env, i32, i32, i32) =20 +DEF_HELPER_3(msa_move_v, void, env, i32, i32) =20 DEF_HELPER_4(msa_andi_b, void, env, i32, i32, i32) DEF_HELPER_4(msa_ori_b, void, env, i32, i32, i32) @@ -977,7 +978,6 @@ DEF_HELPER_5(msa_splati_df, void, env, i32, i32, i32, i= 32) DEF_HELPER_5(msa_insve_df, void, env, i32, i32, i32, i32) DEF_HELPER_3(msa_ctcmsa, void, env, tl, i32) DEF_HELPER_2(msa_cfcmsa, tl, env, i32) -DEF_HELPER_3(msa_move_v, void, env, i32, i32) =20 DEF_HELPER_5(msa_fcaf_df, void, env, i32, i32, i32, i32) DEF_HELPER_5(msa_fcun_df, void, env, i32, i32, i32, i32) diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c index 8ad9d42..cece69b 100644 --- a/target/mips/msa_helper.c +++ b/target/mips/msa_helper.c @@ -1974,7 +1974,19 @@ void helper_msa_mod_u_d(CPUMIPSState *env, uint32_t = wd, uint32_t ws, uint32_t wt * +---------------+------------------------------------------------------= ----+ */ =20 -/* TODO: insert Move group helpers here */ +static inline void msa_move_v(wr_t *pwd, wr_t *pws) +{ + pwd->d[0] =3D pws->d[0]; + pwd->d[1] =3D pws->d[1]; +} + +void helper_msa_move_v(CPUMIPSState *env, uint32_t wd, uint32_t ws) +{ + wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); + wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); + + msa_move_v(pwd, pws); +} =20 =20 /* @@ -2031,15 +2043,6 @@ void helper_msa_mod_u_d(CPUMIPSState *env, uint32_t = wd, uint32_t ws, uint32_t wt /* TODO: insert Shift group helpers here */ =20 =20 -static inline void msa_move_v(wr_t *pwd, wr_t *pws) -{ - uint32_t i; - - for (i =3D 0; i < DF_ELEMENTS(DF_DOUBLE); i++) { - pwd->d[i] =3D pws->d[i]; - } -} - #define MSA_FN_IMM8(FUNC, DEST, OPERATION) \ void helper_msa_ ## FUNC(CPUMIPSState *env, uint32_t wd, uint32_t ws, \ uint32_t i8) \ @@ -3826,14 +3829,6 @@ target_ulong helper_msa_cfcmsa(CPUMIPSState *env, ui= nt32_t cs) return 0; } =20 -void helper_msa_move_v(CPUMIPSState *env, uint32_t wd, uint32_t ws) -{ - wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); - wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); - - msa_move_v(pwd, pws); -} - void helper_msa_fill_df(CPUMIPSState *env, uint32_t df, uint32_t wd, uint32_t rs) { --=20 2.7.4