From nobody Wed Nov 12 07:03:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568646423; cv=none; d=zoho.com; s=zohoarc; b=UAn5Dsbsg56aoUNAxrkaZ1ZYHuJGzFVAwMNVlRMVGu8gSxbpVEWvZfhqyO/rr8F/B5Nc6DDoVvSOsxakrP2u5PsX1qvG/5jteLIHnJqyxqvXfQvyjg6VIjz7SQpBC8+RLjg71s5bwhLfTi+A68varNEGj9yu2vt2LKh3XWCmjpo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568646423; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=XFqUfZ0D+qjTEWF2tGgFMQF/kgJJHpcKbhrb9txVbKA=; b=N5R7SjDoNRpvua7p1mEv1JbqsjU1aN/Z5PR/H/u8ri7g410Vv1GBKNB6RJcAn+QBH3F2TpzeQcP+mxYYhkDhMPutmGHRSfRgrUHvKk+sQAWZujbGCwVoCa+V6eMY9TF090KPlqwwccDvv7pphb7SCjcq/sVbiqxE/rH1leHPtNQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568646423363281.54017585352574; Mon, 16 Sep 2019 08:07:03 -0700 (PDT) Received: from localhost ([::1]:35690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9saj-0005l5-F1 for importer@patchew.org; Mon, 16 Sep 2019 11:07:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53607) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9sCp-0006KT-5T for qemu-devel@nongnu.org; Mon, 16 Sep 2019 10:42:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9sCn-0007Qi-Eb for qemu-devel@nongnu.org; Mon, 16 Sep 2019 10:42:18 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:34914) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9sCn-0007Q1-32 for qemu-devel@nongnu.org; Mon, 16 Sep 2019 10:42:17 -0400 Received: by mail-wr1-x432.google.com with SMTP id v8so3819656wrt.2 for ; Mon, 16 Sep 2019 07:42:16 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id i14sm17024298wra.78.2019.09.16.07.42.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Sep 2019 07:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=XFqUfZ0D+qjTEWF2tGgFMQF/kgJJHpcKbhrb9txVbKA=; b=B8Rm226j0iatczokUjljTF5QA7+6reh4Bx5DkXsExrYpF9oK3HeQuAjI58sNUv1vaz fn+7IL35uEiH+RB6lifq21t2vKQWWMgNcUrTzrWhWScFoaZNse2SiRf93x+GzXOWE43z Z8BqQsz2Uwc5V5R+ssrlifdNnIhpcwq75hCWY9sI/FUpYc3ErICj5HAmlrSPC7XOltcu vwnwAa7n20JMlon9rDvQ/QmYwQ+2nAcrNRK3pwGF3osYuGh7rF0a+m5ivvt7a7MI4VTT hVpYLWkcPz8I2+HXIm5HbnYDMeCps1Q0xRmuQFFkuAZ8OVewwU7BRMi9TlomlyHfNEEN iIng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=XFqUfZ0D+qjTEWF2tGgFMQF/kgJJHpcKbhrb9txVbKA=; b=qxXdi9JT/St/DcWFI83Lmfv2yURRJuewtRJMJtr6GOtXtt0UwOTF1zBsutgNtrFI4U 1pNCYjyztF3V6IdPpvo6dXaZk+2Cd8dChcyLpYgRf0QEq7CYHfYO/m+fwkEGPzXTZK6V HRcPPiOve0ISP6Ysd/WLJc5r0z7w+G/KPptq11GSnf0L3+Zk4tye2Kdl7HMn6QRSzx0r 4xPclFkUjK1i264gtOyV+NInEWtmKt9F5GDhEvpm0rdW31AxWyb0FHoIKp/SBIgzUOXm OFWsy8lRmLsHNmyl7dbMJ1kNsTg5gCcmO4zQBLjXiARAE14A0tg3VALSQxl7APfMtXNK 8h0A== X-Gm-Message-State: APjAAAUszM2o7pOvwLK8N6xftubYlJkY/Q34Kk7J7fbqKnOemPprh21S gneQ1Fw5WBbJx2b6N8LdlpRang1/ X-Google-Smtp-Source: APXvYqxSL+q0ZO7Cx8+j3Je9PXyS769us4xiWkAjSLq0/+OeRK4ZLWvyymLeYYvHuI0p2R2TOoxpXA== X-Received: by 2002:adf:d848:: with SMTP id k8mr112778wrl.254.1568644935671; Mon, 16 Sep 2019 07:42:15 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 16 Sep 2019 16:41:45 +0200 Message-Id: <1568644929-9124-6-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1568644929-9124-1-git-send-email-pbonzini@redhat.com> References: <1568644929-9124-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 Subject: [Qemu-devel] [PULL 05/29] exec.c: correct the maximum skip value during compact X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Wei Yang skip is defined with 6 bits. So the maximum value should be (1 << 6). Signed-off-by: Wei Yang Message-Id: <20190321082555.21118-6-richardw.yang@linux.intel.com> Signed-off-by: Paolo Bonzini --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index d9827ef..d1969bb 100644 --- a/exec.c +++ b/exec.c @@ -324,7 +324,7 @@ static void phys_page_compact(PhysPageEntry *lp, Node *= nodes) assert(valid_ptr < P_L2_SIZE); =20 /* Don't compress if it won't fit in the # of bits we have. */ - if (lp->skip + p[valid_ptr].skip >=3D (1 << 3)) { + if (lp->skip + p[valid_ptr].skip >=3D (1 << 6)) { return; } =20 --=20 1.8.3.1