From nobody Wed Nov 12 02:09:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1567339193; cv=none; d=zoho.com; s=zohoarc; b=gXlWv2N/6g65VhY5a3b9TFDUrklBMh7YhIxtoP2utF3KrHUCGdMq4C+Y/0wLo7B52RM2368OVWEVLYeqmg79qVw/SQ15nF4sVKVHb1MKXuOuSvWEw8WBuf/hch5OFsC3TVwjsYf3VNtIOakaQ1SYY1W4abHx45cUO+NL4rf9nAg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567339193; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=2baCtFZp9zErekU7vNvw31t3KkN9K4Vkr4O42G+hels=; b=MsCunHoOjeVprmjTTwow63Z/hEV0CJUgSevAD3HwlYmuh9QVeC5ci+SMsp0UGXK4c/BxZ1YKeaGISRh8WIGosG7JUAK2I9HddkGcAptQXFLpDrT70dH1oJEcEQ09u5Sm75wvxZZHSwCbqIBVJTcplF7tWpCuuakLBfUhOGRMgMU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1567339193502902.779068606266; Sun, 1 Sep 2019 04:59:53 -0700 (PDT) Received: from localhost ([::1]:56752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4OWJ-0001Gy-78 for importer@patchew.org; Sun, 01 Sep 2019 07:59:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50223) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4OQ7-0003M9-5P for qemu-devel@nongnu.org; Sun, 01 Sep 2019 07:53:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4OQ5-0004RT-Pp for qemu-devel@nongnu.org; Sun, 01 Sep 2019 07:53:22 -0400 Received: from relay.sw.ru ([185.231.240.75]:52470) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i4OQ5-0004Mv-GA; Sun, 01 Sep 2019 07:53:21 -0400 Received: from [172.16.25.136] (helo=dhcp-172-16-25-136.sw.ru) by relay.sw.ru with esmtp (Exim 4.92) (envelope-from ) id 1i4OQ2-0000CW-7x; Sun, 01 Sep 2019 14:53:18 +0300 From: Andrey Shinkevich To: qemu-devel@nongnu.org, qemu-block@nongnu.org Date: Sun, 1 Sep 2019 14:53:04 +0300 Message-Id: <1567338786-586124-5-git-send-email-andrey.shinkevich@virtuozzo.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1567338786-586124-1-git-send-email-andrey.shinkevich@virtuozzo.com> References: <1567338786-586124-1-git-send-email-andrey.shinkevich@virtuozzo.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH v7 4/6] iotests: Valgrind fails with nonexistent directory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, mreitz@redhat.com, andrey.shinkevich@virtuozzo.com, den@openvz.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The Valgrind uses the exported variable TMPDIR and fails if the directory does not exist. Let us exclude such a test case from being run under the Valgrind and notify the user of it. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich Reviewed-by: John Snow --- tests/qemu-iotests/051 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 index ce942a5..f8141ca 100755 --- a/tests/qemu-iotests/051 +++ b/tests/qemu-iotests/051 @@ -377,6 +377,10 @@ printf %b "qemu-io $device_id \"write -P 0x33 0 4k\"\n= commit $device_id\n" | $QEMU_IO -c "read -P 0x33 0 4k" "$TEST_IMG" | _filter_qemu_io =20 # Using snapshot=3Don with a non-existent TMPDIR +if [ "${VALGRIND_QEMU}" =3D=3D "y" ]; then + _casenotrun "Valgrind needs a valid TMPDIR for itself" +fi +VALGRIND_QEMU=3D"" \ TMPDIR=3D/nonexistent run_qemu -drive driver=3Dnull-co,snapshot=3Don =20 # Using snapshot=3Don together with read-only=3Don --=20 1.8.3.1