From nobody Wed Nov 12 01:49:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1567306788; cv=none; d=zoho.com; s=zohoarc; b=Zzi6dTcMKrm0Kb6LRAigLRhVSp8O0FaxCFiO740204SrU+t0q7RYRIcmliLHjs3cM365ykkFyKlSMhbEx0RWJ45kjt4MlAthLKEvUVmaRl8Mf8ECjJ0d+6U/7O+IFU95fz/78b+M8h8x3D/GpC1Yt69AyqGHrS+f6FLnSBVtoQo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567306788; h=Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=lXtGv9HRdPTFI+Me4gtyUazvsCGsUrPGnXpSFbFm+8k=; b=JNCP6QXr+j+9UrrdFv3ZN3PUmhvZd95wl6fwo0YVMIbs3UpN97FsNF5aAAvcOmIZovVeCFOx13P+hdk3pQaU54wAZBBZ/dH+kB0bjWHYF37YE0UUBrIR3z97LHH6O/hrJ8rTTfwcwdqjKXK7indWA1Yvgh/PnLmDd6NNL3C2puI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1567306788432626.8123042133059; Sat, 31 Aug 2019 19:59:48 -0700 (PDT) Received: from localhost ([::1]:47224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4G5i-0004me-PZ for importer@patchew.org; Sat, 31 Aug 2019 22:59:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47554) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4Fza-0007YX-Dq for qemu-devel@nongnu.org; Sat, 31 Aug 2019 22:53:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4FzZ-0006Ej-4Q for qemu-devel@nongnu.org; Sat, 31 Aug 2019 22:53:26 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:33207) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i4FzY-0006DK-Tv; Sat, 31 Aug 2019 22:53:25 -0400 Received: by mail-pf1-x444.google.com with SMTP id q10so1865665pfl.0; Sat, 31 Aug 2019 19:53:24 -0700 (PDT) Received: from localhost.localdomain (unknown-224-80.windriver.com. [147.11.224.80]) by smtp.gmail.com with ESMTPSA id p10sm11453307pff.132.2019.08.31.19.53.22 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 31 Aug 2019 19:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=lXtGv9HRdPTFI+Me4gtyUazvsCGsUrPGnXpSFbFm+8k=; b=OwNILccBuhk2MCU7VMhNIEcRJUjggHcTbgJLdYq53Th0Jh5eAw6md/8lH8DvLP/8i9 0GPXyQX59uOD8+3vDWO9HVjk1VLPmKq4+fazrfT4Sh3sI5ioCegx1OPRVLBA/zDPk0HU V9sBhV90akN4sIjYLSFsLSrnFOwiy7FIlXwQvTBfw4CGap7zn0KW1rqQpeIGQY9gnqQu 2fjbYbW7UhdmjyQtSVMx3dB4XQ52mVDKbEEr6oFGtHXQzJeVvAgMDrKtVSpRthHrFyf7 aJVy7puF0zHJRk28fKGMJXXz95to6Iogtfh6/7NjaUk88cROAtouB6BqVvqtQX0TGG+s o7Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=lXtGv9HRdPTFI+Me4gtyUazvsCGsUrPGnXpSFbFm+8k=; b=FyMj6DmNs3lbu4LeR62mfcciZZzdAdN2AxLlY1zbWWIoXnUlVNxKMFP1jd5AH4ncOi CudHJ8qhjZM2aUqKeMNrFAY9i6Xj6F95lKZJ2OqjJNv4E+Q1SYM32g3q5BzPRxS5gulh Gbrj06cm3QV2EFtETafnlv+4ZiBQwdqDEKIy47b9uRGY8xrnIk8fsxNHTH69tWpzokG5 xr8B9hgtd6DSqPp5V64TKEdZuygD7D8HwFFTD6ABuE4j9WDKVGVH03XRXeH1Kg4+Q6wf ph9h0umVqrfQkFnFutLty7H0edgd2aN3RzIosZnghrKdzdhTQvQxzXm8A7oVacsjywC6 u51g== X-Gm-Message-State: APjAAAWzoX1lSLQHgoQlidgF46u1iFsGixzdi7NK5Pr10jNaCGYHLSzG doRGkQzg6bdnUepE8C8SiqQ= X-Google-Smtp-Source: APXvYqwT8UKcEgOKABR6xcf7OV8tHo5GFe7774tIWHqgfyGom6bFiAtKKVcBgvgsVZgJTW1q3sF75g== X-Received: by 2002:aa7:908b:: with SMTP id i11mr25159631pfa.199.1567306404051; Sat, 31 Aug 2019 19:53:24 -0700 (PDT) From: Bin Meng To: Alistair Francis , Palmer Dabbelt , qemu-devel@nongnu.org, qemu-riscv@nongnu.org Date: Sat, 31 Aug 2019 19:52:46 -0700 Message-Id: <1567306391-2682-6-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1567306391-2682-1-git-send-email-bmeng.cn@gmail.com> References: <1567306391-2682-1-git-send-email-bmeng.cn@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 Subject: [Qemu-devel] [PATCH v7 05/30] riscv: hw: Change to use qemu_log_mask(LOG_GUEST_ERROR, ...) instead X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Replace the call to hw_error() with qemu_log_mask(LOG_GUEST_ERROR,...) in various sifive models. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v7: None Changes in v6: None Changes in v5: - new patch to change to use qemu_log_mask(LOG_GUEST_ERROR,...) instead in various sifive models Changes in v4: None Changes in v3: None Changes in v2: None hw/riscv/sifive_prci.c | 8 +++++--- hw/riscv/sifive_test.c | 5 +++-- hw/riscv/sifive_uart.c | 9 +++++---- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/riscv/sifive_prci.c b/hw/riscv/sifive_prci.c index f406682..1ab98d4 100644 --- a/hw/riscv/sifive_prci.c +++ b/hw/riscv/sifive_prci.c @@ -20,6 +20,7 @@ =20 #include "qemu/osdep.h" #include "hw/sysbus.h" +#include "qemu/log.h" #include "qemu/module.h" #include "target/riscv/cpu.h" #include "hw/riscv/sifive_prci.h" @@ -37,7 +38,8 @@ static uint64_t sifive_prci_read(void *opaque, hwaddr add= r, unsigned int size) case SIFIVE_PRCI_PLLOUTDIV: return s->plloutdiv; } - hw_error("%s: read: addr=3D0x%x\n", __func__, (int)addr); + qemu_log_mask(LOG_GUEST_ERROR, "%s: read: addr=3D0x%x\n", + __func__, (int)addr); return 0; } =20 @@ -65,8 +67,8 @@ static void sifive_prci_write(void *opaque, hwaddr addr, s->plloutdiv =3D (uint32_t) val64; break; default: - hw_error("%s: bad write: addr=3D0x%x v=3D0x%x\n", - __func__, (int)addr, (int)val64); + qemu_log_mask(LOG_GUEST_ERROR, "%s: bad write: addr=3D0x%x v=3D0x%= x\n", + __func__, (int)addr, (int)val64); } } =20 diff --git a/hw/riscv/sifive_test.c b/hw/riscv/sifive_test.c index cd86831..655a3d7 100644 --- a/hw/riscv/sifive_test.c +++ b/hw/riscv/sifive_test.c @@ -20,6 +20,7 @@ =20 #include "qemu/osdep.h" #include "hw/sysbus.h" +#include "qemu/log.h" #include "qemu/module.h" #include "sysemu/sysemu.h" #include "target/riscv/cpu.h" @@ -48,8 +49,8 @@ static void sifive_test_write(void *opaque, hwaddr addr, break; } } - hw_error("%s: write: addr=3D0x%x val=3D0x%016" PRIx64 "\n", - __func__, (int)addr, val64); + qemu_log_mask(LOG_GUEST_ERROR, "%s: write: addr=3D0x%x val=3D0x%016" P= RIx64 "\n", + __func__, (int)addr, val64); } =20 static const MemoryRegionOps sifive_test_ops =3D { diff --git a/hw/riscv/sifive_uart.c b/hw/riscv/sifive_uart.c index 3b3f94f..cd74043 100644 --- a/hw/riscv/sifive_uart.c +++ b/hw/riscv/sifive_uart.c @@ -18,6 +18,7 @@ =20 #include "qemu/osdep.h" #include "qapi/error.h" +#include "qemu/log.h" #include "hw/sysbus.h" #include "chardev/char.h" #include "chardev/char-fe.h" @@ -93,8 +94,8 @@ uart_read(void *opaque, hwaddr addr, unsigned int size) return s->div; } =20 - hw_error("%s: bad read: addr=3D0x%x\n", - __func__, (int)addr); + qemu_log_mask(LOG_GUEST_ERROR, "%s: bad read: addr=3D0x%x\n", + __func__, (int)addr); return 0; } =20 @@ -125,8 +126,8 @@ uart_write(void *opaque, hwaddr addr, s->div =3D val64; return; } - hw_error("%s: bad write: addr=3D0x%x v=3D0x%x\n", - __func__, (int)addr, (int)value); + qemu_log_mask(LOG_GUEST_ERROR, "%s: bad write: addr=3D0x%x v=3D0x%x\n", + __func__, (int)addr, (int)value); } =20 static const MemoryRegionOps uart_ops =3D { --=20 2.7.4