From nobody Mon Feb 9 21:11:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566284802; cv=none; d=zoho.com; s=zohoarc; b=MZpOCOQ5namTRxXNfGfODL0JjGdQyM/eDwb++Fv1arSOPwLQYLilgmauAqp6XVwhtCAtqxKCr4zd9D3MUvOOCcD8LSdLp7RW2XZlegGWKXsf1ZmOKRQHlpicOQH8po4EeUC66z4GwQUQuLzEtymk230LFp9MWDWEannQUjwJvgE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566284802; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=l56DRYPomzf3JYPGRPii6PukFd0xaJWNyHCecQQ5dIc=; b=ZruNGEmdiCvzeeIYlAJjQ2BhyU86Gv1LmmacFyc6xV0d+IpoxGuw+HdA429e93RtDEc/jjodjJsRn8z3v501a/v2y2LRK0l4Zph77TYJinKkLRos7KZza854vkB+m16p3VAhE+XG5ajYfblNcjMWuGhV/D9wU34WD1lciiVGCcU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566284802166430.15512191914706; Tue, 20 Aug 2019 00:06:42 -0700 (PDT) Received: from localhost ([::1]:33818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzyE4-000332-Nx for importer@patchew.org; Tue, 20 Aug 2019 03:06:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42583) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzy8L-0005bP-Im for qemu-devel@nongnu.org; Tue, 20 Aug 2019 03:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzy8K-0003C5-Fu for qemu-devel@nongnu.org; Tue, 20 Aug 2019 03:00:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30669) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzy8K-0003BO-AA for qemu-devel@nongnu.org; Tue, 20 Aug 2019 03:00:44 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 913618D6CAA; Tue, 20 Aug 2019 07:00:43 +0000 (UTC) Received: from 640k.localdomain.com (ovpn-112-20.ams2.redhat.com [10.36.112.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F552BABE; Tue, 20 Aug 2019 07:00:42 +0000 (UTC) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 20 Aug 2019 08:59:32 +0200 Message-Id: <1566284395-30287-14-git-send-email-pbonzini@redhat.com> In-Reply-To: <1566284395-30287-1-git-send-email-pbonzini@redhat.com> References: <1566284395-30287-1-git-send-email-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Tue, 20 Aug 2019 07:00:43 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 13/36] i386/kvm: initialize struct at full before ioctl call X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Shinkevich Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Andrey Shinkevich Not the whole structure is initialized before passing it to the KVM. Reduce the number of Valgrind reports. Signed-off-by: Andrey Shinkevich Message-Id: <1564502498-805893-4-git-send-email-andrey.shinkevich@virtuozzo= .com> Signed-off-by: Paolo Bonzini --- target/i386/kvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index a66b956..ce3f1c3 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -190,6 +190,7 @@ static int kvm_get_tsc(CPUState *cs) return 0; } =20 + memset(&msr_data, 0, sizeof(msr_data)); msr_data.info.nmsrs =3D 1; msr_data.entries[0].index =3D MSR_IA32_TSC; env->tsc_valid =3D !runstate_is_running(); @@ -1706,6 +1707,7 @@ int kvm_arch_init_vcpu(CPUState *cs) =20 if (has_xsave) { env->xsave_buf =3D qemu_memalign(4096, sizeof(struct kvm_xsave)); + memset(env->xsave_buf, 0, sizeof(struct kvm_xsave)); } =20 max_nested_state_len =3D kvm_max_nested_state_length(); @@ -3488,6 +3490,7 @@ static int kvm_put_debugregs(X86CPU *cpu) return 0; } =20 + memset(&dbgregs, 0, sizeof(dbgregs)); for (i =3D 0; i < 4; i++) { dbgregs.db[i] =3D env->dr[i]; } --=20 1.8.3.1