From nobody Sun Feb 8 16:11:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1565239578; cv=none; d=zoho.com; s=zohoarc; b=NE8kP+NArd0vX5e5Q3WMnJupBb7iJsU2v1d1ONeYK+W9HLI/XcSkf9BQcGpEK79fpEa8PjukS4juXrSGnu5mSK20qv3XgrRKgkdoiqN/XZcOCVTQuKxYePF6/z52ZsR/r0bQB/qsZnHGTtHQEsCq28d7XRnkZxFlVvBRDuP1QNE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565239578; h=Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=E6yxnr+XaLfykr9binetZruI0I2aHRyZR2ZqXqM16+Q=; b=L2ySCrd76wsytpngHy1KV2TkHxcUcEg6Y0UwwxX3FpDvgBd0YRZiuEiH9v8KYQzUQrlPG2G53Etqe/tDiKFW6X6WMmkutsMM/TK7WiCaJJ54nmqeC2lrvSAKA3nYoZVmDY5+8VkEGQKxZ/xtOAYVDkOPIZ9+cHitlNjmasbFEW4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565239578157520.0102660926505; Wed, 7 Aug 2019 21:46:18 -0700 (PDT) Received: from localhost ([::1]:46904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvaJP-0002dN-Tp for importer@patchew.org; Thu, 08 Aug 2019 00:46:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52048) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvaIs-0001iz-03 for qemu-devel@nongnu.org; Thu, 08 Aug 2019 00:45:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvaIq-00057c-VL for qemu-devel@nongnu.org; Thu, 08 Aug 2019 00:45:29 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:41238) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvaIq-00057B-O0; Thu, 08 Aug 2019 00:45:28 -0400 Received: by mail-pl1-x641.google.com with SMTP id m9so42825644pls.8; Wed, 07 Aug 2019 21:45:28 -0700 (PDT) Received: from localhost.localdomain (unknown-224-80.windriver.com. [147.11.224.80]) by smtp.gmail.com with ESMTPSA id h26sm98458499pfq.64.2019.08.07.21.45.26 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 07 Aug 2019 21:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=E6yxnr+XaLfykr9binetZruI0I2aHRyZR2ZqXqM16+Q=; b=hUON9jRVNF7N/A24B0IPUEFT28l8jnaBbCe5NxkH6Ul/h8+XxuLBlhXnjki8xVcquw zxrQ0yp0ywDQCwjutT7YOgpQSiOTbe/VFujGo5OdnbQMq1H3srkdDc8yRtRlk5IggUWm 0AmESPv3m7T+duoVP2Rd1OF6dDV1Jp+387GHVgLqNTRWtSmNVAyuRDAUtbUpv+jiV9M5 hgS3PIpvAj+jVSZdI850JvEGGWGSyd+VKATwjDKqQqdFXcQUq8DXNSJikHaN4841nC5K lSViqGmiahEDc6DQaZvewY1lquNwZ8pxQsbzkuMU3hlPlbdjrRwPWRJKH79Nmp9VpdtX GKeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=E6yxnr+XaLfykr9binetZruI0I2aHRyZR2ZqXqM16+Q=; b=lbp8o+Gn5yGT6M+Oi4GBRkTfmWDtSdfZAaWI8svK1X9QBmgidAu2gPZFpBOpTtT1j8 pmW1jPjB5TF7r6JPj21mCWW7obX7fcw2G5f6NSVCJJh/vIsmuraKbdG6btQAeQs8WSoN 4S7MgP9N+EwqnyXjkVedsvEfbKp1I90yzzK4pURkgFCYn3zEBtv1VcXkRnzK8Tpa01aU W2FTO3hXIwXSLOZwiIsarH7fthpb4ocICHPHFIjfRA/wWSwYB5u7Q02SlXb2FXzQFPLY K0DerqHafc4ELZKEuo5eA/aAfJeOZTBfdRGm2zU+3VHqsK7bXsdG/ikz6wzsZal7kPzq JUkA== X-Gm-Message-State: APjAAAUwB3Qyd/zZgGcAlyzOXQyt26mDvGpZn744VmoMrgl/J9Kugrjq aPJF1X7KOJ2gUczH2etgfdE= X-Google-Smtp-Source: APXvYqw4z9WWpJ45iE0nPmX+JnmRsVo9AeOAKqblWrZWfPh+jxTnQc8XRWzz2T+12bm2cya6y5P8Hw== X-Received: by 2002:a17:902:b949:: with SMTP id h9mr10738694pls.120.1565239527351; Wed, 07 Aug 2019 21:45:27 -0700 (PDT) From: Bin Meng To: Alistair Francis , "Edgar E. Iglesias" , Jason Wang , Peter Maydell , Stefano Garzarella , qemu-devel@nongnu.org, qemu-arm@nongnu.org Date: Wed, 7 Aug 2019 21:44:39 -0700 Message-Id: <1565239479-2130-1-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1565020374-23888-1-git-send-email-bmeng.cn@gmail.com> References: <1565020374-23888-1-git-send-email-bmeng.cn@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 Subject: [Qemu-devel] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When CADENCE_GEM_ERR_DEBUG is turned on, there are several compilation errors in DB_PRINT(). Fix them. Signed-off-by: Bin Meng --- Changes in v2: - use HWADDR_PRIx instead of TARGET_FMT_plx for consistency - use 'z' modifier to print sizeof(..) hw/net/cadence_gem.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index d412085..b6ff2c1 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c @@ -983,8 +983,9 @@ static ssize_t gem_receive(NetClientState *nc, const ui= nt8_t *buf, size_t size) return -1; } =20 - DB_PRINT("copy %d bytes to 0x%x\n", MIN(bytes_to_copy, rxbufsize), - rx_desc_get_buffer(s->rx_desc[q])); + DB_PRINT("copy %d bytes to 0x%" HWADDR_PRIx "\n", + MIN(bytes_to_copy, rxbufsize), + rx_desc_get_buffer(s, s->rx_desc[q])); =20 /* Copy packet data to emulated DMA buffer */ address_space_write(&s->dma_as, rx_desc_get_buffer(s, s->rx_desc[q= ]) + @@ -1157,7 +1158,7 @@ static void gem_transmit(CadenceGEMState *s) if (tx_desc_get_length(desc) > sizeof(tx_packet) - (p - tx_packet)) { DB_PRINT("TX descriptor @ 0x%x too large: size 0x%x space = " \ - "0x%x\n", (unsigned)packet_desc_addr, + "0x%zx\n", (unsigned)packet_desc_addr, (unsigned)tx_desc_get_length(desc), sizeof(tx_packet) - (p - tx_packet)); break; --=20 2.7.4