From nobody Sat Apr 12 06:37:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1564381910; cv=none; d=zoho.com; s=zohoarc; b=lYQ5DA5WNujdDuPfh4X3s2brRUuneh1dqULjpY2S24jO31w51NZ4JoxEdCLC627w09iJKLmOx1loKt4FKD4D4d+RlnQwYJreMfk7nlHeoKxTITAWNjQ/gQ+iGQ192Hsn2o4YNzvDhQEijHw44XBQOtiCeUytWb5sGAYvsaTarZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564381910; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Vqkm8vn8TEM79rH6E106syEw50Fqw8KtBnA/5LLPYBM=; b=TL6NOX59Gbq4rMQTLb38eNTjSoYqsah652yfssFWaLwUr415F5eqv0+p6PX18M+iGDbRS0e7m8UA6RIvWH9f4pDxMew9Sm1hj0+vJ51JGNipY73jN5meXenxUrUXxwdQTgHosm/Qv/BUtmVdPFJeWfFfjnmFb5118vvhrjVl2sY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564381910338987.5062376555364; Sun, 28 Jul 2019 23:31:50 -0700 (PDT) Received: from localhost ([::1]:49817 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrzCH-0004mK-AP for importer@patchew.org; Mon, 29 Jul 2019 02:31:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53679) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrzAS-00027g-1w for qemu-devel@nongnu.org; Mon, 29 Jul 2019 02:29:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrzAR-0007as-3k for qemu-devel@nongnu.org; Mon, 29 Jul 2019 02:29:55 -0400 Received: from mail.ispras.ru ([83.149.199.45]:36736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hrzAQ-0007aC-Sr for qemu-devel@nongnu.org; Mon, 29 Jul 2019 02:29:55 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id E59AE54006A; Mon, 29 Jul 2019 09:29:53 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Mon, 29 Jul 2019 09:29:53 +0300 Message-ID: <156438179371.22071.7134093736590754203.stgit@pasha-Precision-3630-Tower> In-Reply-To: <156438176555.22071.10523120047318890136.stgit@pasha-Precision-3630-Tower> References: <156438176555.22071.10523120047318890136.stgit@pasha-Precision-3630-Tower> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [for-4.2 PATCH 5/6] replay: finish record/replay before closing the disks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, quintela@redhat.com, ciro.santilli@gmail.com, jasowang@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, mreitz@redhat.com, alex.bennee@linaro.org, maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com, boost.lists@gmail.com, thomas.dullien@googlemail.com, dovgaluk@ispras.ru, artem.k.pisarenko@gmail.com, dgilbert@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Pavel Dovgalyuk After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c | 2 ++ vl.c | 1 + 2 files changed, 3 insertions(+) diff --git a/replay/replay.c b/replay/replay.c index 6a62ec3811..71c4e6b777 100644 --- a/replay/replay.c +++ b/replay/replay.c @@ -385,6 +385,8 @@ void replay_finish(void) g_free(replay_snapshot); replay_snapshot =3D NULL; =20 + replay_mode =3D REPLAY_MODE_NONE; + replay_finish_events(); } =20 diff --git a/vl.c b/vl.c index b73fd078a8..2a341f5ad2 100644 --- a/vl.c +++ b/vl.c @@ -4499,6 +4499,7 @@ int main(int argc, char **argv, char **envp) =20 /* No more vcpu or device emulation activity beyond this point */ vm_shutdown(); + replay_finish(); =20 job_cancel_sync_all(); bdrv_close_all();