From nobody Tue Nov 11 16:01:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1564044347; cv=none; d=zoho.com; s=zohoarc; b=cZTHl3zAn6zfou0pS7yVA7gNMKrGTN602DMqXZj4hnIkRJGJ3seH+KHPtIoFpK/L65t77AjxD5U6XV/ERgRBA4Ll2EOYvMRuFaS7BJrkxIxw+yum3syVIo1lmHjz0yawUDn0M8r6+TA9b6vgSV/lDbAw6eprBXNsbQTthjCQPhg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564044347; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=kzmHwe/8qFSWkJO7cZpuLzgW75s2EsHMLFqSs6DJJjc=; b=lhQB2iH93t/DjNJtbxd7CqIYTfhXWXEwVDspSp560D0ywwyM4RWZQNekWYWi4FO5GhZkWgnL81jrUtFdKz0sHyWsO8oPJehhJLF005v+CR+A5IILiYkV2CUhZvi3Rz0IaO8jGQRNnETno/4hzne8wJ2ddjPQ6/h9TNnMFVstyv0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564044347482194.42173054718785; Thu, 25 Jul 2019 01:45:47 -0700 (PDT) Received: from localhost ([::1]:57202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqZNi-0003x7-4R for importer@patchew.org; Thu, 25 Jul 2019 04:45:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50136) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqZMY-0007ua-PM for qemu-devel@nongnu.org; Thu, 25 Jul 2019 04:44:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqZMX-00005l-LZ for qemu-devel@nongnu.org; Thu, 25 Jul 2019 04:44:34 -0400 Received: from mail.ispras.ru ([83.149.199.45]:56994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqZMX-00005T-Dk for qemu-devel@nongnu.org; Thu, 25 Jul 2019 04:44:33 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 8F95954006A; Thu, 25 Jul 2019 11:44:32 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Thu, 25 Jul 2019 11:44:32 +0300 Message-ID: <156404427238.18669.12378772823692338069.stgit@pasha-Precision-3630-Tower> In-Reply-To: <156404424989.18669.12696116045723475173.stgit@pasha-Precision-3630-Tower> References: <156404424989.18669.12696116045723475173.stgit@pasha-Precision-3630-Tower> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [for-4.2 PATCH v2 4/8] replay: fix replay shutdown X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, quintela@redhat.com, ciro.santilli@gmail.com, jasowang@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, mreitz@redhat.com, alex.bennee@linaro.org, maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com, boost.lists@gmail.com, thomas.dullien@googlemail.com, dovgaluk@ispras.ru, artem.k.pisarenko@gmail.com, dgilbert@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Pavel Dovgalyuk This patch fixes shutdown of the replay process, which is terminated with the assert when shutdown event is read from the log. replay_finish_event reads new data_kind and therefore the value of data_kind should be preserved to be valid at qemu_system_shutdown_request call. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/replay/replay.c b/replay/replay.c index 8b172b2d1b..8d77a4ca4c 100644 --- a/replay/replay.c +++ b/replay/replay.c @@ -45,14 +45,14 @@ bool replay_next_event_is(int event) } =20 while (true) { - if (event =3D=3D replay_state.data_kind) { + unsigned int data_kind =3D replay_state.data_kind; + if (event =3D=3D data_kind) { res =3D true; } - switch (replay_state.data_kind) { + switch (data_kind) { case EVENT_SHUTDOWN ... EVENT_SHUTDOWN_LAST: replay_finish_event(); - qemu_system_shutdown_request(replay_state.data_kind - - EVENT_SHUTDOWN); + qemu_system_shutdown_request(data_kind - EVENT_SHUTDOWN); break; default: /* clock, time_t, checkpoint and other events */