From nobody Sat Feb 7 04:13:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563829540; cv=none; d=zoho.com; s=zohoarc; b=X9rlTXJRGzF0OaxMaXMn+ZlEFyK36ddfY10iCk8di92DBGAYYXCMBzu/B3DP8lO3wHe3jBxzSZ4iGTdhGU7YMQ5/YmGpt8U8QxvItOVGv9M1MAwp3GDcPdtN7fgDw+vrFjymV98p08A1TvWYFPiXP8RvPwKtMg4FyE7uJQTgwEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563829540; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=94m98zJwRs1ARbASN6bBc7n1f1hsdvBpDpKlGgoy9QI=; b=TblsKLKTksb498V00s4SaXL7wLeM8Ek+wjVfEJu+QD4kKw00XJcIMIUa9JF8k3HbSDTk2gZwoC+pIaCPC6qN3b4itrgpSSDRk1P1GUeIJbovZubF1mpHcH9DpB8tCnf8FaJ7stE+tr7fg51ReNLND8WpTeJyIsTBspPEPPPOMWw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563829540753595.6468837525427; Mon, 22 Jul 2019 14:05:40 -0700 (PDT) Received: from localhost ([::1]:37710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpfV2-0001WQ-K4 for importer@patchew.org; Mon, 22 Jul 2019 17:05:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51707) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpfUr-000188-KR for qemu-devel@nongnu.org; Mon, 22 Jul 2019 17:05:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpfUq-0001yh-Cb for qemu-devel@nongnu.org; Mon, 22 Jul 2019 17:05:25 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:36411) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpfUq-0001y0-4M for qemu-devel@nongnu.org; Mon, 22 Jul 2019 17:05:24 -0400 Received: by mail-wr1-x430.google.com with SMTP id n4so40912597wrs.3 for ; Mon, 22 Jul 2019 14:05:24 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id n2sm27842565wmi.38.2019.07.22.14.05.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jul 2019 14:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=94m98zJwRs1ARbASN6bBc7n1f1hsdvBpDpKlGgoy9QI=; b=gCk1Zlu3cWZfpjhsTB2RbItqptsAao4sPHiWOmQwDlonVAv9/MVLpj0nVLlvoH2R6e 22KWG5CNUWfEOfhbdVrSAihbOtyh1FXfpyrYwy8wOe32j2fLX4bNb2exnR49Tw09istk 6TPKDZnGBTqqhyDbLLJNjQCR/TF19qHoq/3HyAwlofJQNB2AAk7rHXBcUsG4slpzsOCF +pqGRNxmeIwI0IjM/LEIPvtRS7p4/PGem4qmlwLRAyr4PVpRc78MaWFfraLvalJ/EuB9 whYIj/7PlFlPaQ+LWemazrtxIJ44gh1ofKyW+wRzpBLfZ8vTh8yi5u5ZHM4pE3P+/VPa CEzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=94m98zJwRs1ARbASN6bBc7n1f1hsdvBpDpKlGgoy9QI=; b=Mx8zHQYZSTEj4Ha07Vz+DbT1p75jjoMcglgTSyBsBsDjtfeTGVIzbCTP5gnU8TaZS/ KLi7MnE575/6PjFc5trVt+p0KwOiVBvrzvqSjKVVAzVFnoCbEElyzUYrDnmL3WY36NCu MDYUzToWpiQy2vKMvdVtfVZQl94ro5Cnsgv2oDJDLT9hCcilqYZ0/cuA7LSsJf3r7kuT 0bDGNj1I+cdGziZf/7f2BcpsDa34uiXnLB2a3hoaMnOcz53HCifTwtP96ZjGQboqNRPC oUFsnBALkP4kQYGqN3PwAXfhORjzjCYiIDaJPZ2+uksyZ/0ez9FXlz+g5g2JHTIWpwjQ /32A== X-Gm-Message-State: APjAAAV0zOv6Wwt6VlxzCCylGm82Ikh1CESuSzoWz/oFPB0YqFtlTI/Y 6isAJSV+UqknZqTIFmSneDRcNprdXtQ= X-Google-Smtp-Source: APXvYqwMpDtyIsFrz5QpxjeI2CCZBoBNg39yqeqNu6mm/wtm4DIaq/1abdlmMNrC6IxyCF0qUL3BOg== X-Received: by 2002:a5d:5452:: with SMTP id w18mr37085372wrv.327.1563829522533; Mon, 22 Jul 2019 14:05:22 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 22 Jul 2019 23:05:20 +0200 Message-Id: <1563829520-17525-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::430 Subject: [Qemu-devel] [PATCH v2] virtio-scsi: fixed virtio_scsi_ctx_check failed when detaching scsi disk X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhengui li Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Zhengui li commit a6f230c move blockbackend back to main AioContext on unplug. It set = the AioContext of SCSIDevice to the main AioContex, but s->ctx is still the iothread AioConte= x=C3=AF=C2=BC=CB=86if the scsi controller is configure with iothread=C3=AF=C2=BC=E2=80=B0. So if there are having in-= flight requests during unplug, a failing assertion happend. The bt is below: (gdb) bt #0 0x0000ffff86aacbd0 in raise () from /lib64/libc.so.6 #1 0x0000ffff86aadf7c in abort () from /lib64/libc.so.6 #2 0x0000ffff86aa6124 in __assert_fail_base () from /lib64/libc.so.6 #3 0x0000ffff86aa61a4 in __assert_fail () from /lib64/libc.so.6 #4 0x0000000000529118 in virtio_scsi_ctx_check (d=3D, s=3D<= optimized out>, s=3D) at /home/qemu-4.0.0/hw/scsi/virtio-scs= i.c:246 #5 0x0000000000529ec4 in virtio_scsi_handle_cmd_req_prepare (s=3D0x2779ec0= 0, req=3D0xffff740397d0) at /home/qemu-4.0.0/hw/scsi/virtio-scsi.c:559 #6 0x000000000052a228 in virtio_scsi_handle_cmd_vq (s=3D0x2779ec00, vq=3D0= xffff7c6d7110) at /home/qemu-4.0.0/hw/scsi/virtio-scsi.c:603 #7 0x000000000052afa8 in virtio_scsi_data_plane_handle_cmd (vdev=3D, vq=3D0xffff7c6d7110) at /home/qemu-4.0.0/hw/scsi/virtio-scsi-data= plane.c:59 #8 0x000000000054d94c in virtio_queue_host_notifier_aio_poll (opaque=3D) at /home/qemu-4.0.0/hw/virtio/virtio.c:2452 assert(blk_get_aio_context(d->conf.blk) =3D=3D s->ctx) failed. To avoid assertion failed, moving the "if" after qdev_simple_device_unplug= _cb. In addition, to avoid another qemu crash below, add aio_disable_external be= fore qdev_simple_device_unplug_cb, which disable the further processing of exter= nal clients when doing qdev_simple_device_unplug_cb. (gdb) bt #0 scsi_req_unref (req=3D0xffff6802c6f0) at hw/scsi/scsi-bus.c:1283 #1 0x00000000005294a4 in virtio_scsi_handle_cmd_req_submit (req=3D, s=3D) at /home/qemu-4.0.0/hw/scsi/virtio-scsi.c:589 #2 0x000000000052a2a8 in virtio_scsi_handle_cmd_vq (s=3Ds@entry=3D0x9c90e9= 0, vq=3Dvq@entry=3D0xffff7c05f110) at /home/qemu-4.0.0/hw/scsi/virtio-scsi= .c:625 #3 0x000000000052afd8 in virtio_scsi_data_plane_handle_cmd (vdev=3D, vq=3D0xffff7c05f110) at /home/qemu-4.0.0/hw/scsi/virtio-scsi-dataplane.= c:60 #4 0x000000000054d97c in virtio_queue_host_notifier_aio_poll (opaque=3D) at /home/qemu-4.0.0/hw/virtio/virtio.c:2447 #5 0x00000000009b204c in run_poll_handlers_once (ctx=3Dctx@entry=3D0x6efea= 40, timeout=3Dtimeout@entry=3D0xffff7d7f7308) at util/aio-posix.c:521 #6 0x00000000009b2b64 in run_poll_handlers (ctx=3Dctx@entry=3D0x6efea40, max_ns=3Dmax_ns@entry=3D4000, timeout=3Dtimeout@entry=3D0xffff7d7f7308)= at util/aio-posix.c:559 #7 0x00000000009b2ca0 in try_poll_mode (ctx=3Dctx@entry=3D0x6efea40, timeo= ut=3D0xffff7d7f7308, timeout@entry=3D0xffff7d7f7348) at util/aio-posix.c:594 #8 0x00000000009b31b8 in aio_poll (ctx=3D0x6efea40, blocking=3Dblocking@en= try=3Dtrue) at util/aio-posix.c:636 #9 0x00000000006973cc in iothread_run (opaque=3D0x6ebd800) at iothread.c:75 #10 0x00000000009b592c in qemu_thread_start (args=3D0x6efef60) at util/qemu= -thread-posix.c:502 #11 0x0000ffff8057f8bc in start_thread () from /lib64/libpthread.so.0 #12 0x0000ffff804e5f8c in thread_start () from /lib64/libc.so.6 (gdb) p bus $1 =3D (SCSIBus *) 0x0 Signed-off-by: Zhengui li Message-Id: <1563696502-7972-1-git-send-email-lizhengui@huawei.com> Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index d0bdbff..8b9e5e2 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -832,6 +832,7 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotpl= ug_dev, DeviceState *dev, VirtIODevice *vdev =3D VIRTIO_DEVICE(hotplug_dev); VirtIOSCSI *s =3D VIRTIO_SCSI(vdev); SCSIDevice *sd =3D SCSI_DEVICE(dev); + AioContext *ctx =3D s->ctx ?: qemu_get_aio_context(); =20 if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { virtio_scsi_acquire(s); @@ -841,14 +842,16 @@ static void virtio_scsi_hotunplug(HotplugHandler *hot= plug_dev, DeviceState *dev, virtio_scsi_release(s); } =20 + aio_disable_external(ctx); + qdev_simple_device_unplug_cb(hotplug_dev, dev, errp); + aio_enable_external(ctx); + if (s->ctx) { virtio_scsi_acquire(s); /* If other users keep the BlockBackend in the iothread, that's ok= */ blk_set_aio_context(sd->conf.blk, qemu_get_aio_context(), NULL); virtio_scsi_release(s); } - - qdev_simple_device_unplug_cb(hotplug_dev, dev, errp); } =20 static struct SCSIBusInfo virtio_scsi_scsi_info =3D { --=20 1.8.3.1