From nobody Sat May 18 08:35:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1563812610; cv=none; d=zoho.com; s=zohoarc; b=dV/M5Xh0CluU+usFvU0MJta1Ya1NKmOT3h4sXiXi85ffap+/Kou5okcp8/SrDILG+GCC3b8woni2cnmQ+dOVkH2IVdaZfT1GVbufa1uLJRiXWhvDFIr+eHzkGXUB+u1TANnRFGpS2ewzMsUvrTk5K9AFbiGzka7udNDPND89HIM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563812610; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=ck9MHqxNsWCET5LNcvQY7C6qEXMnR9if5fPni529Uvk=; b=Eo+QjleCUenfz/bqXQe9w6j8Jzv2f6NJbpkpAOAA49A9uDULIDPl6xXnX9AGrUoDMm2HSYoJy2EIX7WClonhIesCLKcab9i6zOlW6DwsX0Mt7XTk7kw7rYl9yaAxxJtjwAbdii+0b9P9fX573rFFQJJXqxkePkL/MmWaP49wF7k= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563812610297720.3272026958216; Mon, 22 Jul 2019 09:23:30 -0700 (PDT) Received: from localhost ([::1]:35742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpb5y-0001Jt-Vk for importer@patchew.org; Mon, 22 Jul 2019 12:23:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35418) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpb5h-0000Wf-Tq for qemu-devel@nongnu.org; Mon, 22 Jul 2019 12:23:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpb5f-0003ra-5c for qemu-devel@nongnu.org; Mon, 22 Jul 2019 12:23:08 -0400 Received: from mx2.rt-rk.com ([89.216.37.149]:41837 helo=mail.rt-rk.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpb5e-0003pY-Le for qemu-devel@nongnu.org; Mon, 22 Jul 2019 12:23:06 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.rt-rk.com (Postfix) with ESMTP id 78ECD1A1FAC; Mon, 22 Jul 2019 18:23:00 +0200 (CEST) Received: from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local [10.10.13.43]) by mail.rt-rk.com (Postfix) with ESMTPSA id 592CC1A2027; Mon, 22 Jul 2019 18:23:00 +0200 (CEST) X-Virus-Scanned: amavisd-new at rt-rk.com From: Aleksandar Markovic To: qemu-devel@nongnu.org Date: Mon, 22 Jul 2019 18:22:52 +0200 Message-Id: <1563812573-30309-2-git-send-email-aleksandar.markovic@rt-rk.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1563812573-30309-1-git-send-email-aleksandar.markovic@rt-rk.com> References: <1563812573-30309-1-git-send-email-aleksandar.markovic@rt-rk.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 89.216.37.149 Subject: [Qemu-devel] [PATCH for 4.1 v6 1/2] target/mips: Add 'fall through' comments for handling nanoMips' SHXS, SWXS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arikalo@wavecomp.com, sw@weilnetz.de, philmd@redhat.com, amarkovic@wavecomp.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Missed in commit fb32f8c8560. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index 3575eff..ca62800 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -20141,12 +20141,14 @@ static void gen_p_lsx(DisasContext *ctx, int rd, = int rs, int rt) switch (extract32(ctx->opcode, 7, 4)) { case NM_SHXS: check_nms(ctx); + /* fall through */ case NM_LHXS: case NM_LHUXS: tcg_gen_shli_tl(t0, t0, 1); break; case NM_SWXS: check_nms(ctx); + /* fall through */ case NM_LWXS: case NM_LWC1XS: case NM_SWC1XS: --=20 2.7.4 From nobody Sat May 18 08:35:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1563812622; cv=none; d=zoho.com; s=zohoarc; b=Hz/3DsttZhBSW//1MYzwCEzGruVatYRLm64R9NH9Csf7Z8KBB5gOuVbQwfgOYFup3NXqiyMCUD+aS5bFGiAdeUllYQsUTsWB4SUX0wj1zwkkl/+LO/v8rag+qyerdYlxwAvqWJTxRE2IZoKSVnolvcJHe+Enp1jnUYzCajFczkU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563812622; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Pyr9PnN3+KWq3iJMn215UEK2QlVDXjPasEKjYuzN/Hs=; b=EPMgGl8nlV4whp4P5y7CNPypcWz6/TEslXMzF4D6DUiO5OWPLLO/LozvRjA3SOZ8BcpGOhB9Cs8A2CeyQiv9SVrRzz12Jx2e4rb0H2xPFFs+Tl8n3WyC4vLAiztmGGNah2iUUZdLJcT8I97fgajNBkaalQ5aJZ7maod1WkAg6V4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563812622894985.2217384999548; Mon, 22 Jul 2019 09:23:42 -0700 (PDT) Received: from localhost ([::1]:35750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpb6D-0002co-UH for importer@patchew.org; Mon, 22 Jul 2019 12:23:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35417) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpb5h-0000We-Te for qemu-devel@nongnu.org; Mon, 22 Jul 2019 12:23:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpb5e-0003r6-Kn for qemu-devel@nongnu.org; Mon, 22 Jul 2019 12:23:08 -0400 Received: from mx2.rt-rk.com ([89.216.37.149]:41835 helo=mail.rt-rk.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpb5d-0003pX-00 for qemu-devel@nongnu.org; Mon, 22 Jul 2019 12:23:05 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.rt-rk.com (Postfix) with ESMTP id 853461A2027; Mon, 22 Jul 2019 18:23:00 +0200 (CEST) Received: from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local [10.10.13.43]) by mail.rt-rk.com (Postfix) with ESMTPSA id 650AA1A2066; Mon, 22 Jul 2019 18:23:00 +0200 (CEST) X-Virus-Scanned: amavisd-new at rt-rk.com From: Aleksandar Markovic To: qemu-devel@nongnu.org Date: Mon, 22 Jul 2019 18:22:53 +0200 Message-Id: <1563812573-30309-3-git-send-email-aleksandar.markovic@rt-rk.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1563812573-30309-1-git-send-email-aleksandar.markovic@rt-rk.com> References: <1563812573-30309-1-git-send-email-aleksandar.markovic@rt-rk.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 89.216.37.149 Subject: [Qemu-devel] [PATCH for 4.1 v6 2/2] target/mips: Fix emulation of MSA pack instructions on big endian hosts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arikalo@wavecomp.com, sw@weilnetz.de, philmd@redhat.com, amarkovic@wavecomp.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Aleksandar Markovic Fix emulation of MSA pack instructions on big endian hosts. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo --- target/mips/msa_helper.c | 74 ++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 74 insertions(+) diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c index a383c40..a5a8657 100644 --- a/target/mips/msa_helper.c +++ b/target/mips/msa_helper.c @@ -2113,6 +2113,24 @@ void helper_msa_pckev_df(CPUMIPSState *env, uint32_t= df, uint32_t wd, =20 switch (df) { case DF_BYTE: +#if defined(HOST_WORDS_BIGENDIAN) + pwd->b[8] =3D pws->b[9]; + pwd->b[10] =3D pws->b[13]; + pwd->b[12] =3D pws->b[1]; + pwd->b[14] =3D pws->b[5]; + pwd->b[0] =3D pwt->b[9]; + pwd->b[2] =3D pwt->b[13]; + pwd->b[4] =3D pwt->b[1]; + pwd->b[6] =3D pwt->b[5]; + pwd->b[9] =3D pws->b[11]; + pwd->b[13] =3D pws->b[3]; + pwd->b[1] =3D pwt->b[11]; + pwd->b[5] =3D pwt->b[3]; + pwd->b[11] =3D pws->b[15]; + pwd->b[3] =3D pwt->b[15]; + pwd->b[15] =3D pws->b[7]; + pwd->b[7] =3D pwt->b[7]; +#else pwd->b[15] =3D pws->b[14]; pwd->b[13] =3D pws->b[10]; pwd->b[11] =3D pws->b[6]; @@ -2129,8 +2147,19 @@ void helper_msa_pckev_df(CPUMIPSState *env, uint32_t= df, uint32_t wd, pwd->b[4] =3D pwt->b[8]; pwd->b[8] =3D pws->b[0]; pwd->b[0] =3D pwt->b[0]; +#endif break; case DF_HALF: +#if defined(HOST_WORDS_BIGENDIAN) + pwd->h[4] =3D pws->h[5]; + pwd->h[6] =3D pws->h[1]; + pwd->h[0] =3D pwt->h[5]; + pwd->h[2] =3D pwt->h[1]; + pwd->h[5] =3D pws->h[7]; + pwd->h[1] =3D pwt->h[7]; + pwd->h[7] =3D pws->h[3]; + pwd->h[3] =3D pwt->h[3]; +#else pwd->h[7] =3D pws->h[6]; pwd->h[5] =3D pws->h[2]; pwd->h[3] =3D pwt->h[6]; @@ -2139,12 +2168,20 @@ void helper_msa_pckev_df(CPUMIPSState *env, uint32_= t df, uint32_t wd, pwd->h[2] =3D pwt->h[4]; pwd->h[4] =3D pws->h[0]; pwd->h[0] =3D pwt->h[0]; +#endif break; case DF_WORD: +#if defined(HOST_WORDS_BIGENDIAN) + pwd->w[2] =3D pws->w[3]; + pwd->w[0] =3D pwt->w[3]; + pwd->w[3] =3D pws->w[1]; + pwd->w[1] =3D pwt->w[1]; +#else pwd->w[3] =3D pws->w[2]; pwd->w[1] =3D pwt->w[2]; pwd->w[2] =3D pws->w[0]; pwd->w[0] =3D pwt->w[0]; +#endif break; case DF_DOUBLE: pwd->d[1] =3D pws->d[0]; @@ -2164,6 +2201,24 @@ void helper_msa_pckod_df(CPUMIPSState *env, uint32_t= df, uint32_t wd, =20 switch (df) { case DF_BYTE: +#if defined(HOST_WORDS_BIGENDIAN) + pwd->b[7] =3D pwt->b[6]; + pwd->b[5] =3D pwt->b[2]; + pwd->b[3] =3D pwt->b[14]; + pwd->b[1] =3D pwt->b[10]; + pwd->b[15] =3D pws->b[6]; + pwd->b[13] =3D pws->b[2]; + pwd->b[11] =3D pws->b[14]; + pwd->b[9] =3D pws->b[10]; + pwd->b[6] =3D pwt->b[4]; + pwd->b[2] =3D pwt->b[12]; + pwd->b[14] =3D pws->b[4]; + pwd->b[10] =3D pws->b[12]; + pwd->b[4] =3D pwt->b[0]; + pwd->b[12] =3D pws->b[0]; + pwd->b[0] =3D pwt->b[8]; + pwd->b[8] =3D pws->b[8]; +#else pwd->b[0] =3D pwt->b[1]; pwd->b[2] =3D pwt->b[5]; pwd->b[4] =3D pwt->b[9]; @@ -2180,8 +2235,19 @@ void helper_msa_pckod_df(CPUMIPSState *env, uint32_t= df, uint32_t wd, pwd->b[11] =3D pws->b[7]; pwd->b[7] =3D pwt->b[15]; pwd->b[15] =3D pws->b[15]; +#endif break; case DF_HALF: +#if defined(HOST_WORDS_BIGENDIAN) + pwd->h[3] =3D pwt->h[2]; + pwd->h[1] =3D pwt->h[6]; + pwd->h[7] =3D pws->h[2]; + pwd->h[5] =3D pws->h[6]; + pwd->h[2] =3D pwt->h[0]; + pwd->h[6] =3D pws->h[0]; + pwd->h[0] =3D pwt->h[4]; + pwd->h[4] =3D pws->h[4]; +#else pwd->h[0] =3D pwt->h[1]; pwd->h[2] =3D pwt->h[5]; pwd->h[4] =3D pws->h[1]; @@ -2190,12 +2256,20 @@ void helper_msa_pckod_df(CPUMIPSState *env, uint32_= t df, uint32_t wd, pwd->h[5] =3D pws->h[3]; pwd->h[3] =3D pwt->h[7]; pwd->h[7] =3D pws->h[7]; +#endif break; case DF_WORD: +#if defined(HOST_WORDS_BIGENDIAN) + pwd->w[1] =3D pwt->w[0]; + pwd->w[3] =3D pws->w[0]; + pwd->w[0] =3D pwt->w[2]; + pwd->w[2] =3D pws->w[2]; +#else pwd->w[0] =3D pwt->w[1]; pwd->w[2] =3D pws->w[1]; pwd->w[1] =3D pwt->w[3]; pwd->w[3] =3D pws->w[3]; +#endif break; case DF_DOUBLE: pwd->d[0] =3D pwt->d[1]; --=20 2.7.4