From nobody Mon Feb 9 12:14:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562359266; cv=none; d=zoho.com; s=zohoarc; b=SJlrX4oZ3oQMoBJNxLEpTLblNjXFXikwQCaSPmhcAa5owgSmTAAr/9oJe9OgvjvPb/lqDCcpOJfLtbQKHtZoYCeXU7GurL2693hOgLw1rO9PxF2pLhpcIv/7w/wWEaLn4Qqa9P71uNUrd7DU9LjpH/ppImc4jRBCuDfEmXdk3iE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562359266; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=tkNz7uqIs0Rv1hq1F0XpRF7vtnO8a8dqtlBjE4VOmbk=; b=VCax47GQuRUW53FkhFYmso9f5Aa3Qnx5kfHWA+45ydtpoEL2HuQ3V7TSt2JeVasIhhAHaubuNwAgkHPoMrRnUiLl1lSaWIlUS2ZBGaIOE4yFrYZvVLGnh+DsoAkNgLPiHYlsxQd4i4rG0+D0uBYVMbBjIKDNkAycr8+I3EjMB3Q= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562359265996578.120434594466; Fri, 5 Jul 2019 13:41:05 -0700 (PDT) Received: from localhost ([::1]:55960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjV0y-00042R-Qk for importer@patchew.org; Fri, 05 Jul 2019 16:41:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34266) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjUkS-0004Yh-LK for qemu-devel@nongnu.org; Fri, 05 Jul 2019 16:24:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjUkQ-00033s-LR for qemu-devel@nongnu.org; Fri, 05 Jul 2019 16:24:00 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:40230) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjUkL-0002n8-Nc for qemu-devel@nongnu.org; Fri, 05 Jul 2019 16:23:55 -0400 Received: by mail-wr1-x42a.google.com with SMTP id r1so4699621wrl.7 for ; Fri, 05 Jul 2019 13:23:36 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id v23sm3035875wmj.32.2019.07.05.13.23.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 13:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=tkNz7uqIs0Rv1hq1F0XpRF7vtnO8a8dqtlBjE4VOmbk=; b=CiNK7xa1Jx2Ke2fdyKqozCsgA8qo8aCH4aKnQkiM3/MeT+qSk6SHXC1Ymv5D1/AC/7 fAuBD+3TQjrfDG0KN2ddV8fZ2KIWqDra8hQSw6R65TvZ4DptCg/U91j3MxuPZOZyClQF omMlyuylSzdJ4mFjGrG3bul7z3K/4IJj2ka0aMxoj8VIiQ0+R9ikCWYimVjlVRUDjz9K J9P7o6YVdw8dsng2d/sZxlLWnfgFZfvaDU6EcGOileGAXMH7MCf9XzrTX/rfSkjhoKjm L8tPA1rN3AgAlfRTgaTLSHePA85Dg//nz2fNA0nCdrsAApqU2+6gVoFYsH+m6EZ53ST6 7kmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=tkNz7uqIs0Rv1hq1F0XpRF7vtnO8a8dqtlBjE4VOmbk=; b=aO2V+zWW2JDclbavJ1EK77mxy1YoMn5EUBQwNFq0jK5ymilT3+HxTL+HawZd1mwJqE 84Ko23kDK0FEbOOIbgS9lUubLoa0NQk+Ndzn2bM0llf/I8d4Bzwgxxb1VyMm4NdNSfdx hcg5IHNfMGeym6PtOmjFpuOK6JbmOCg2/QOmJ0nCkWdlCav+qQ+YZSA6+8VgygjCPqjM /KI0IF7/8cLaebdxO9IDiqn7ICoHc4SmEX80OHN6ahsVUyXmdPnbfGU65/fmRoeTnFYg 6WO7Ye3xF+9woEvnjQJKcvLDeqxxuR+Bqrtl9G8gQKpPRCD9KcNtNb2NIeTJp2tV7+r1 08Tg== X-Gm-Message-State: APjAAAXKVxEfJROROsGXRmhE3Kok/UxjtOpMJgqJwL7hUmgKPNsjkpVP V1NlNGkG1ToJR6yfFyS+rjYj5BbRc9E= X-Google-Smtp-Source: APXvYqy2kXav6uHXm46tXNoqwg6Z+fTsS1uqDM1WinsjQIMu/CoKLgLdL8FPpnvRixxaFukcdI5A6w== X-Received: by 2002:a05:6000:1203:: with SMTP id e3mr5000065wrx.300.1562358214871; Fri, 05 Jul 2019 13:23:34 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 5 Jul 2019 22:23:22 +0200 Message-Id: <1562358202-28008-13-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1562358202-28008-1-git-send-email-pbonzini@redhat.com> References: <1562358202-28008-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42a Subject: [Qemu-devel] [PULL 12/12] ioapic: use irq number instead of vector in ioapic_eoi_broadcast X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Li Qiang When emulating irqchip in qemu, such as following command: x86_64-softmmu/qemu-system-x86_64 -m 1024 -smp 4 -hda /home/test/test.img -machine kernel-irqchip=3Doff --enable-kvm -vnc :0 -device edu -monitor std= io We will get a crash with following asan output: (qemu) /home/test/qemu5/qemu/hw/intc/ioapic.c:266:27: runtime error: index = 35 out of bounds for type 'int [24]' =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D113504=3D=3DERROR: AddressSanitizer: heap-buffer-overflow on address = 0x61b000003114 at pc 0x5579e3c7a80f bp 0x7fd004bf8c10 sp 0x7fd004bf8c00 WRITE of size 4 at 0x61b000003114 thread T4 #0 0x5579e3c7a80e in ioapic_eoi_broadcast /home/test/qemu5/qemu/hw/intc= /ioapic.c:266 #1 0x5579e3c6f480 in apic_eoi /home/test/qemu5/qemu/hw/intc/apic.c:428 #2 0x5579e3c720a7 in apic_mem_write /home/test/qemu5/qemu/hw/intc/apic.= c:802 #3 0x5579e3b1e31a in memory_region_write_accessor /home/test/qemu5/qemu= /memory.c:503 #4 0x5579e3b1e6a2 in access_with_adjusted_size /home/test/qemu5/qemu/me= mory.c:569 #5 0x5579e3b28d77 in memory_region_dispatch_write /home/test/qemu5/qemu= /memory.c:1497 #6 0x5579e3a1b36b in flatview_write_continue /home/test/qemu5/qemu/exec= .c:3323 #7 0x5579e3a1b633 in flatview_write /home/test/qemu5/qemu/exec.c:3362 #8 0x5579e3a1bcb1 in address_space_write /home/test/qemu5/qemu/exec.c:3= 452 #9 0x5579e3a1bd03 in address_space_rw /home/test/qemu5/qemu/exec.c:3463 #10 0x5579e3b8b979 in kvm_cpu_exec /home/test/qemu5/qemu/accel/kvm/kvm-= all.c:2045 #11 0x5579e3ae4499 in qemu_kvm_cpu_thread_fn /home/test/qemu5/qemu/cpus= .c:1287 #12 0x5579e4cbdb9f in qemu_thread_start util/qemu-thread-posix.c:502 #13 0x7fd0146376da in start_thread (/lib/x86_64-linux-gnu/libpthread.so= .0+0x76da) #14 0x7fd01436088e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x12188e This is because in ioapic_eoi_broadcast function, we uses 'vector' to index the 's->irq_eoi'. To fix this, we should uses the irq number. Signed-off-by: Li Qiang Reviewed-by: Peter Xu Message-Id: <20190622002119.126834-1-liq3ea@163.com> --- hw/intc/ioapic.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index db9e518..c408749 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -245,8 +245,8 @@ void ioapic_eoi_broadcast(int vector) s->ioredtbl[n] =3D entry & ~IOAPIC_LVT_REMOTE_IRR; =20 if (!(entry & IOAPIC_LVT_MASKED) && (s->irr & (1 << n))) { - ++s->irq_eoi[vector]; - if (s->irq_eoi[vector] >=3D SUCCESSIVE_IRQ_MAX_COUNT) { + ++s->irq_eoi[n]; + if (s->irq_eoi[n] >=3D SUCCESSIVE_IRQ_MAX_COUNT) { /* * Real hardware does not deliver the interrupt immedi= ately * during eoi broadcast, and this lets a buggy guest m= ake @@ -254,16 +254,16 @@ void ioapic_eoi_broadcast(int vector) * level-triggered interrupt. Emulate this behavior if= we * detect an interrupt storm. */ - s->irq_eoi[vector] =3D 0; + s->irq_eoi[n] =3D 0; timer_mod_anticipate(s->delayed_ioapic_service_timer, qemu_clock_get_ns(QEMU_CLOCK_VIRT= UAL) + NANOSECONDS_PER_SECOND / 100); - trace_ioapic_eoi_delayed_reassert(vector); + trace_ioapic_eoi_delayed_reassert(n); } else { ioapic_service(s); } } else { - s->irq_eoi[vector] =3D 0; + s->irq_eoi[n] =3D 0; } } } --=20 1.8.3.1