From nobody Fri Apr 11 19:00:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562040343; cv=none; d=zoho.com; s=zohoarc; b=UJ3gyAxkAEaDwBBI8cd5pir8gv/L/a0yHvC4fpTI2vkWr8J2etAgMzwOI9HSUuUz3lPmFVc0zPc4oPPMLWqMygS8g29RsazM834CGoLayuVmVndYt6PqGEue1psJkMLpXoJkLYXsPYDQFrHB1pNw7Bgv8kA8l97MNL38PXsWm1s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562040343; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=LcQvXnRlBRfaYnILyru9nl3NlgbU5BIQ+I+BsJ1dxCs=; b=jezF+uFlIecDJMp8EFgVIvOvAhSYMgKtzkE2OyG/xdUYlodBrRck0eGshvJ4GR7KN9b9RFSek+Swad0xkgaZpAqc1lAnDGomzcLVvrQkIHVu+80HWVk4tlxDsp0ugX8F7z/CuH3ltOmqn9zTMvDh2o/E/UO2XNiPQ4ChXvtAoUk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562040343267790.7332958723999; Mon, 1 Jul 2019 21:05:43 -0700 (PDT) Received: from localhost ([::1]:48426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiA2r-0006XP-ME for importer@patchew.org; Tue, 02 Jul 2019 00:05:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50431) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi8aH-0004mB-U4 for qemu-devel@nongnu.org; Mon, 01 Jul 2019 22:31:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hi8aG-0003eE-LO for qemu-devel@nongnu.org; Mon, 01 Jul 2019 22:31:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52566) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hi8aE-0003Vt-Qy for qemu-devel@nongnu.org; Mon, 01 Jul 2019 22:31:50 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 06D2D30860A3; Tue, 2 Jul 2019 02:31:38 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-232.pek2.redhat.com [10.72.12.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65D97BA53; Tue, 2 Jul 2019 02:31:36 +0000 (UTC) From: Jason Wang To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 2 Jul 2019 10:31:14 +0800 Message-Id: <1562034689-6539-3-git-send-email-jasowang@redhat.com> In-Reply-To: <1562034689-6539-1-git-send-email-jasowang@redhat.com> References: <1562034689-6539-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 02 Jul 2019 02:31:38 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 02/17] qemu-bridge-helper: Document known shortcomings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Jason Wang --- qemu-bridge-helper.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c index f9940de..95624bc 100644 --- a/qemu-bridge-helper.c +++ b/qemu-bridge-helper.c @@ -10,7 +10,17 @@ * * This work is licensed under the terms of the GNU GPL, version 2. See * the COPYING file in the top-level directory. - * + */ + +/* + * Known shortcomings: + * - There is no manual page + * - The syntax of the ACL file is not documented anywhere + * - parse_acl_file() doesn't report fopen() failure properly, fails + * to check ferror() after fgets() failure, arbitrarily truncates + * long lines, handles whitespace inconsistently, error messages + * don't point to the offending file and line, errors in included + * files are reported, but otherwise ignored, ... */ =20 #include "qemu/osdep.h" --=20 2.5.0