From nobody Sun May 19 01:15:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1561432958; cv=none; d=zoho.com; s=zohoarc; b=m48VN4dgXKNroa7FczHz/D8nPnn4L3zI+1AlPo2Eheww+S3OMZxbTWddfojF7VSrceMBWD/CzeDshEER4qgpk+xfG/gXi27cKIBHJiFyqLuYxX5RbisSmmtLxlpxk6DgfW1vRvi2FkU8t/R+TvCtMN0y26DxX22KGlzD72bsiHI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561432958; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=ellj7FG7NYRKdFvgEfy1USdnl3LEbRxttyFuTUbzDNA=; b=H+aRPGWQ2WZgYimcSfCSXl42SWxpy5EOqUbjK+0kBn/+nfHKwVA+bsbEsaSqu8wFzY1ZsRtWPirPI1dTL6u8wfxBOv7/fiQEXBxlEWeNePhMezNf89SGsike6uYNb5HUIa065mB185DAaCS3Ya4ggc7EzG+Tb9MK3WdiWW/N8SA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561432958799664.9019387615845; Mon, 24 Jun 2019 20:22:38 -0700 (PDT) Received: from localhost ([::1]:56154 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfc2F-00013f-Vu for importer@patchew.org; Mon, 24 Jun 2019 23:22:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38724) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfc1S-0000c4-3o for qemu-devel@nongnu.org; Mon, 24 Jun 2019 23:21:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfc1Q-0001yn-Vq for qemu-devel@nongnu.org; Mon, 24 Jun 2019 23:21:30 -0400 Received: from mga07.intel.com ([134.134.136.100]:36846) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfc1Q-0001tt-Mj for qemu-devel@nongnu.org; Mon, 24 Jun 2019 23:21:28 -0400 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jun 2019 20:21:23 -0700 Received: from joy-desktop.sh.intel.com ([10.239.13.126]) by fmsmga001.fm.intel.com with ESMTP; 24 Jun 2019 20:21:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,413,1557212400"; d="scan'208";a="182789717" From: Yan Zhao To: pbonzini@redhat.com Date: Tue, 25 Jun 2019 11:21:18 +0800 Message-Id: <1561432878-13754-1-git-send-email-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.100 Subject: [Qemu-devel] [PATCH v4] memory: assert on out of scope notification X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Auger , Yan Zhao , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It is wrong for an entry to have parts out of scope of notifier's range. assert this condition. Out of scope mapping/unmapping would cause problem, as in below case: 1. initially there are two notifiers with ranges 0-0xfedfffff, 0xfef00000-0xffffffffffffffff, IOVAs from 0x3c000000 - 0x3c1fffff is in shadow page table. 2. in vfio, memory_region_register_iommu_notifier() is followed by memory_region_iommu_replay(), which will first call address space unmap, and walk and add back all entries in vtd shadow page table. e.g. (1) for notifier 0-0xfedfffff, IOVAs from 0 - 0xffffffff get unmapped, and IOVAs from 0x3c000000 - 0x3c1fffff get mapped (2) for notifier 0xfef00000-0xffffffffffffffff IOVAs from 0 - 0x7fffffffff get unmapped, but IOVAs from 0x3c000000 - 0x3c1fffff cannot get mapped back. Cc: Eric Auger Signed-off-by: Yan Zhao --- v4: 1. modified commit title 2. using "assert" instead of printing warning message (Eric Auger) v3: refined code style and message format v2: 1. added a local variable entry_end (Eric Auger) 2. using PRIx64 as format for address range in warning message (Eric Auger) --- memory.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 0a089a7..35e8e77 100644 --- a/memory.c +++ b/memory.c @@ -1937,16 +1937,18 @@ void memory_region_notify_one(IOMMUNotifier *notifi= er, IOMMUTLBEntry *entry) { IOMMUNotifierFlag request_flags; + hwaddr entry_end =3D entry->iova + entry->addr_mask; =20 /* * Skip the notification if the notification does not overlap * with registered range. */ - if (notifier->start > entry->iova + entry->addr_mask || - notifier->end < entry->iova) { + if (notifier->start > entry_end || notifier->end < entry->iova) { return; } =20 + assert(entry->iova >=3D notifier->start && entry_end <=3D notifier->en= d); + if (entry->perm & IOMMU_RW) { request_flags =3D IOMMU_NOTIFIER_MAP; } else { --=20 2.7.4