From nobody Tue Sep 30 03:45:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1561106432; cv=none; d=zoho.com; s=zohoarc; b=OJ2I9ro9f7Hu6CK3prmjow1Bdt/gOWzutWY6pcGp6eixt0ovyMXh9MKezr9aU5C0K3qenyfW+BR2F1XPu/E4FOiIoAnywuvnvUTQXcqZY/ls8eJcjjW3pOlKBtviK91prcBvBZYORDgstgBkCAIsxx7P67hqvMKfV5vyZJk3ZYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561106432; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=9tDDv9/sirR00GtUM/v627/x7fIbqRxPEw20SPCZ3ZA=; b=A4/Wzr3E3bYh+tPqkCYBS/8cFw1y/u6FJE9kz24q7NSuKZw+qU2LrrOD/MctPnk7eSQuEdio+WcnPmZq+REzgbAHD/5oeXtzwds26OlRY3Gi2rHRVQ5DCq+5dCBuSDh3A6uLC61QwAcqR5LwRh9o1ANzKC6bpEPmRM0Sn4Vu42g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561106432792912.4939166385815; Fri, 21 Jun 2019 01:40:32 -0700 (PDT) Received: from localhost ([::1]:55538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heF5w-0007RX-Nb for importer@patchew.org; Fri, 21 Jun 2019 04:40:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58773) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heEza-0004Ud-Re for qemu-devel@nongnu.org; Fri, 21 Jun 2019 04:33:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1heEoJ-0001A2-Rj for qemu-devel@nongnu.org; Fri, 21 Jun 2019 04:22:17 -0400 Received: from mail.ispras.ru ([83.149.199.45]:41622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1heEoJ-00019Z-Hh for qemu-devel@nongnu.org; Fri, 21 Jun 2019 04:22:15 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id ADC5754006B; Fri, 21 Jun 2019 11:22:14 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Fri, 21 Jun 2019 11:22:14 +0300 Message-ID: <156110533452.25431.5472128681314713978.stgit@pasha-Precision-3630-Tower> In-Reply-To: <156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower> References: <156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH for-4.1 17/24] gdbstub: add reverse continue support in replay mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, quintela@redhat.com, ciro.santilli@gmail.com, jasowang@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, mreitz@redhat.com, alex.bennee@linaro.org, maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com, boost.lists@gmail.com, thomas.dullien@googlemail.com, dovgaluk@ispras.ru, artem.k.pisarenko@gmail.com, dgilbert@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Pavel Dovgalyuk This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were hit and to seek to the last breakpoint. Reverse continue loads the previous snapshot and tries to find the breakpoi= nt since that moment. If there are no such breakpoints, it proceeds to the earlier snapshot, and so on. When no breakpoints or watchpoints were hit at all, execution stops at the beginning of the replay log. Signed-off-by: Pavel Dovgalyuk --- cpus.c | 5 +++ exec.c | 1 + gdbstub.c | 9 +++++- include/sysemu/replay.h | 8 +++++ replay/replay-debugging.c | 71 +++++++++++++++++++++++++++++++++++++++++= ++++ stubs/replay.c | 5 +++ 6 files changed, 98 insertions(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index c2356f9836..e0e61abe64 100644 --- a/cpus.c +++ b/cpus.c @@ -1115,6 +1115,11 @@ static void cpu_handle_guest_debug(CPUState *cpu) cpu->stopped =3D true; } else { if (!cpu->singlestep_enabled) { + /* + * Report about the breakpoint and + * make a single step to skip it + */ + replay_breakpoint(); cpu_single_step(cpu, SSTEP_ENABLE); } else { cpu_single_step(cpu, 0); diff --git a/exec.c b/exec.c index ee21e6de34..b3c70f8c9a 100644 --- a/exec.c +++ b/exec.c @@ -2821,6 +2821,7 @@ static void check_watchpoint(int offset, int len, Mem= TxAttrs attrs, int flags) * Don't process the watchpoints when we are * in a reverse debugging operation. */ + replay_breakpoint(); return; } if (flags =3D=3D BP_MEM_READ) { diff --git a/gdbstub.c b/gdbstub.c index 2fe718d0b7..8d4cd3cf6e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1859,6 +1859,13 @@ static void handle_backward(GdbCmdContext *gdb_ctx, = void *user_ctx) put_packet(gdb_ctx->s, "E14"); } return; + case 'c': + if (replay_reverse_continue()) { + gdb_continue(gdb_ctx->s); + } else { + put_packet(gdb_ctx->s, "E14"); + } + return; } } =20 @@ -2121,7 +2128,7 @@ static void handle_query_supported(GdbCmdContext *gdb= _ctx, void *user_ctx) ";qXfer:features:read+"); } if (replay_mode =3D=3D REPLAY_MODE_PLAY) { - pstrcat(gdb_ctx->str_buf, sizeof(gdb_ctx->str_buf), ";ReverseStep+= "); + pstrcat(gdb_ctx->str_buf, sizeof(gdb_ctx->str_buf), ";ReverseStep+= ;ReverseContinue+"); } =20 if (gdb_ctx->num_params && diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h index 533003f2b0..1d18c9b6ea 100644 --- a/include/sysemu/replay.h +++ b/include/sysemu/replay.h @@ -79,11 +79,19 @@ const char *replay_get_filename(void); * Returns true on success. */ bool replay_reverse_step(void); +/* + * Start searching the last breakpoint/watchpoint. + * Used by gdbstub for backwards debugging. + * Returns true if the process successfully started. + */ +bool replay_reverse_continue(void); /* * Returns true if replay module is processing * reverse_continue or reverse_step request */ bool replay_running_debug(void); +/* Called in reverse debugging mode to collect breakpoint information */ +void replay_breakpoint(void); =20 /* Processing the instructions */ =20 diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c index 3d94859b8f..abb5fe687f 100644 --- a/replay/replay-debugging.c +++ b/replay/replay-debugging.c @@ -22,6 +22,8 @@ #include "migration/snapshot.h" =20 static bool replay_is_debugging; +static int64_t replay_last_breakpoint; +static int64_t replay_last_snapshot; =20 bool replay_running_debug(void) { @@ -252,3 +254,72 @@ bool replay_reverse_step(void) =20 return false; } + +static void replay_continue_end(void) +{ + replay_is_debugging =3D false; + vm_stop(RUN_STATE_DEBUG); + replay_delete_break(); +} + +static void replay_continue_stop(void *opaque) +{ + Error *err =3D NULL; + if (replay_last_breakpoint !=3D -1LL) { + replay_seek(replay_last_breakpoint, replay_stop_vm_debug, &err); + if (err) { + error_free(err); + replay_continue_end(); + } + return; + } + /* + * No breakpoints since the last snapshot. + * Find previous snapshot and try again. + */ + if (replay_last_snapshot !=3D 0) { + replay_seek(replay_last_snapshot - 1, replay_continue_stop, &err); + if (err) { + error_free(err); + replay_continue_end(); + } + replay_last_snapshot =3D replay_get_current_step(); + return; + } else { + /* Seek to the very first step */ + replay_seek(0, replay_stop_vm_debug, &err); + if (err) { + error_free(err); + replay_continue_end(); + } + return; + } + replay_continue_end(); +} + +bool replay_reverse_continue(void) +{ + Error *err =3D NULL; + + assert(replay_mode =3D=3D REPLAY_MODE_PLAY); + + if (replay_get_current_step() !=3D 0) { + replay_seek(replay_get_current_step() - 1, replay_continue_stop, &= err); + if (err) { + error_free(err); + return false; + } + replay_last_breakpoint =3D -1LL; + replay_is_debugging =3D true; + replay_last_snapshot =3D replay_get_current_step(); + return true; + } + + return false; +} + +void replay_breakpoint(void) +{ + assert(replay_mode =3D=3D REPLAY_MODE_PLAY); + replay_last_breakpoint =3D replay_get_current_step(); +} diff --git a/stubs/replay.c b/stubs/replay.c index 521552fa83..ee649726f4 100644 --- a/stubs/replay.c +++ b/stubs/replay.c @@ -85,3 +85,8 @@ bool replay_reverse_step(void) { return false; } + +bool replay_reverse_continue(void) +{ + return false; +}