From nobody Tue Sep 30 03:45:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1561108012; cv=none; d=zoho.com; s=zohoarc; b=UMXVmnmXhRF4K+kXvNOoTvgA2FxJ//JFfQnYpRoGbz46eTeIrqlylUddVmlm6Yo6zR0Iieyh55Rp54WH4jtmJN/5c2chlon1yOLq4gGAvwlcchCplsu4Y81EzG+YwlEULMUGnw8gqpcztsw5ihIBezIKEv20ZPRQN5erRBMltl0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561108012; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=pvk+4dDT3HRP5sPAU4jjw5BBbhk1hUrtBRsXTofVdDw=; b=IjExi6ab5WCA7cmP0/Y70ry6e9JFXbWfweMkWkfFR4mvmWpUufh2tgeGMcaGVu2QNqfwYisaNnjgo+nq8QlR4lWBnR8Z5CJskDr6I1KySgF0zKbqjPK4wdSpckCZdt+n2nv/Zv4T9wP1JJkyiu2MM85FNCFP5oKIq2Bv+4lRrtA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561108012740333.6011540611289; Fri, 21 Jun 2019 02:06:52 -0700 (PDT) Received: from localhost ([::1]:55722 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heFVT-000608-Je for importer@patchew.org; Fri, 21 Jun 2019 05:06:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58774) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heEzd-0004Ue-PM for qemu-devel@nongnu.org; Fri, 21 Jun 2019 04:33:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1heEnJ-0000Hj-Mn for qemu-devel@nongnu.org; Fri, 21 Jun 2019 04:21:14 -0400 Received: from mail.ispras.ru ([83.149.199.45]:41336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1heEnJ-0000HL-FR for qemu-devel@nongnu.org; Fri, 21 Jun 2019 04:21:13 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 50B31540093; Fri, 21 Jun 2019 11:21:12 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Fri, 21 Jun 2019 11:21:12 +0300 Message-ID: <156110527210.25431.7121967728273636187.stgit@pasha-Precision-3630-Tower> In-Reply-To: <156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower> References: <156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH for-4.1 06/24] replay: finish record/replay before closing the disks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, quintela@redhat.com, ciro.santilli@gmail.com, jasowang@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, mreitz@redhat.com, alex.bennee@linaro.org, maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com, boost.lists@gmail.com, thomas.dullien@googlemail.com, dovgaluk@ispras.ru, artem.k.pisarenko@gmail.com, dgilbert@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Pavel Dovgalyuk After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c | 2 ++ vl.c | 1 + 2 files changed, 3 insertions(+) diff --git a/replay/replay.c b/replay/replay.c index 8b172b2d1b..b75820a1c1 100644 --- a/replay/replay.c +++ b/replay/replay.c @@ -385,6 +385,8 @@ void replay_finish(void) g_free(replay_snapshot); replay_snapshot =3D NULL; =20 + replay_mode =3D REPLAY_MODE_NONE; + replay_finish_events(); } =20 diff --git a/vl.c b/vl.c index 8fcfd905ee..4543fdab25 100644 --- a/vl.c +++ b/vl.c @@ -4562,6 +4562,7 @@ int main(int argc, char **argv, char **envp) =20 /* No more vcpu or device emulation activity beyond this point */ vm_shutdown(); + replay_finish(); =20 job_cancel_sync_all(); bdrv_close_all();