From nobody Tue May 7 13:27:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1560494200; cv=none; d=zoho.com; s=zohoarc; b=hAuAZNDHfH2qkBngEBfd/uPzeMZOtGi/2BPkfP89KKufDMQQDitxOOO7U+pKVcFkq7WXvI2bU+N0zrJENrzEwr5oubl1vNb25UZwAZ76QUA6O3H9A/mXFsSQ+roR+MCW5b2p7L91MbOhHguk6umSWAiIg5nWQ5SUL0Wzg6cnzQU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560494200; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=Tz/F1eQwvTFv26zw8p7cRHb892kUC7w++LJ0D8HzM9s=; b=ojyAJhHMu8RkY1vzwvdiZErh9Mq8C/VTpLBPlzJ8FaqbpGJhEWuzIx+/xtsltQzxwM2bZ1B9bTviUZQyPqMD6GgKvOpV9I5NU9nmYulOUMkWbhYiyXDjNCRHEh8UBR+O85K5xaYNZEmFXLDdWEqkgXMKc8gVyz2K3EKKbu2s/mw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1560494200619245.9820944589352; Thu, 13 Jun 2019 23:36:40 -0700 (PDT) Received: from localhost ([::1]:48780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbfp5-0007eG-QF for importer@patchew.org; Fri, 14 Jun 2019 02:36:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55971) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbfoa-0007FS-L9 for qemu-devel@nongnu.org; Fri, 14 Jun 2019 02:35:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbfoZ-00038k-Ex for qemu-devel@nongnu.org; Fri, 14 Jun 2019 02:35:56 -0400 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:52556) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbfoZ-00034L-5t for qemu-devel@nongnu.org; Fri, 14 Jun 2019 02:35:55 -0400 Received: from localhost(mailfrom:tao.peng@linux.alibaba.com fp:SMTPD_---0TU87-DM_1560494124) by smtp.aliyun-inc.com(127.0.0.1); Fri, 14 Jun 2019 14:35:48 +0800 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R941e4; CH=green; DM=||false|; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e01422; MF=tao.peng@linux.alibaba.com; NM=1; PH=DS; RN=7; SR=0; TI=SMTPD_---0TU87-DM_1560494124; From: Peng Tao To: qemu-devel@nongnu.org Date: Fri, 14 Jun 2019 14:35:13 +0800 Message-Id: <1560494113-1141-1-git-send-email-tao.peng@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 47.88.44.36 Subject: [Qemu-devel] [PATCH] migration: allow private destination ram with x-ignore-shared X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Tao , "Dr. David Alan Gilbert" , Yury Kotov , Xu Wang , Jiangshan Lai , kata-dev@lists.katacontainers.io Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" By removing the share ram check, qemu is able to migrate to private destination ram when x-ignore-shared capability is on. Then we can create multiple destination VMs based on the same source VM. This changes the x-ignore-shared migration capability to work similar to Lai's original bypass-shared-memory work(https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg00003.html) which enables kata containers (https://katacontainers.io) to implement the VM templating feature. An example usage in kata containers(https://katacontainers.io): 1. Start the source VM: qemu-system-x86 -m 2G \ -object memory-backend-file,id=3Dmem0,size=3D2G,share=3Don,mem-path=3D= /tmpfs/template-memory \ -numa node,memdev=3Dmem0 2. Stop the template VM, set migration x-ignore-shared capability, migrate "exec:cat>/tmpfs/state", quit it 3. Start target VM: qemu-system-x86 -m 2G \ -object memory-backend-file,id=3Dmem0,size=3D2G,share=3Doff,mem-path= =3D/tmpfs/template-memory \ -numa node,memdev=3Dmem0 \ -incoming defer 4. connect to target VM qmp, set migration x-ignore-shared capability, migrate_incoming "exec:cat /tmpfs/state" 5. create more target VMs repeating 3 and 4 Cc: Dr. David Alan Gilbert Cc: Yury Kotov Cc: Jiangshan Lai Cc: Xu Wang Signed-off-by: Peng Tao Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1ca9ba7..cdb82a3 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -3373,7 +3373,6 @@ static int ram_save_setup(QEMUFile *f, void *opaque) } if (migrate_ignore_shared()) { qemu_put_be64(f, block->mr->addr); - qemu_put_byte(f, ramblock_is_ignored(block) ? 1 : 0); } } =20 @@ -4340,12 +4339,6 @@ static int ram_load(QEMUFile *f, void *opaque, int v= ersion_id) } if (migrate_ignore_shared()) { hwaddr addr =3D qemu_get_be64(f); - bool ignored =3D qemu_get_byte(f); - if (ignored !=3D ramblock_is_ignored(block)) { - error_report("RAM block %s should %s be migrat= ed", - id, ignored ? "" : "not"); - ret =3D -EINVAL; - } if (ramblock_is_ignored(block) && block->mr->addr !=3D addr) { error_report("Mismatched GPAs for block %s " --=20 1.8.3.1