From nobody Mon May 6 03:01:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559746255; cv=none; d=zoho.com; s=zohoarc; b=MkTopPuLW7ziSG2VxPoSPCgoueE5BOogcAn6Rp6ptNwF9ZeqHO6OLjf6a1Vp+oyOW2xgnPghVCWF7B1yI7F7cZjgM8hDDqbIcmIVxb97Zr5NIMiReRgc/FKmH7u0XmcYkOh7jrLv7WtITnPLMbxVLxKvRap1WbFn9pEmWudzIys= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559746255; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=HBejD4kNctFQZxlIySn8oYt9PMZJcFSlk2RkPUjdkvU=; b=lE/0qlcOGvGyHmPonqbYKVSI5joNl8zHrT+M5Yom8dgcIkIj1WvI+iPN/IMEy5H+/kbeyiMDbbEMwoBAuzrcxD93x5Y7gmUpwia82Tqvv1Z0/Qknp1KaB8ezue0xOGdzVGsTfJV8uYL8AdFYL+EzJPF4NGgNg4DQV6eKCv4ftCg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559746255683538.7529940301844; Wed, 5 Jun 2019 07:50:55 -0700 (PDT) Received: from localhost ([127.0.0.1]:43916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYXFe-0002Fl-K5 for importer@patchew.org; Wed, 05 Jun 2019 10:50:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYX5Y-0002PJ-Qi for qemu-devel@nongnu.org; Wed, 05 Jun 2019 10:40:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYX5X-0004Iv-4Z for qemu-devel@nongnu.org; Wed, 05 Jun 2019 10:40:28 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:35122) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYX5W-0004FE-TL; Wed, 05 Jun 2019 10:40:27 -0400 Received: by mail-wr1-x443.google.com with SMTP id m3so3922875wrv.2; Wed, 05 Jun 2019 07:40:24 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id t14sm22123117wrr.33.2019.06.05.07.40.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 07:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=HBejD4kNctFQZxlIySn8oYt9PMZJcFSlk2RkPUjdkvU=; b=H2g0r9Ck+GtYXFAJM8CEM3E8iW9MsehMBborRIS7s09EJJHVJrpGTt8hFouwQEcXBb evv4bWbXTL2+67QJqot9OxEr+a5/4BjdMrEkazdBBjUmuhwprD25pfPHVlReZF3hc0Be qKIt6ygylLtKmsK1tN5N47KBomTjrXSP8N4uxLf1JENkQnJUYCjEMvgM1h096mniVxDT lvTIv4J9Oayzm5kZ+YEzZkaoZ1IaxiSwH7R/EeoZfGHexj7NysYp/rkOod1fdZwdmMXX 1m/4ZEsnWCLd9pWLsAAZjBnGtynKV570PKifok9t4Sh25L0Vmdp1vyXMi8zSMDLc7Jpk kllA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=HBejD4kNctFQZxlIySn8oYt9PMZJcFSlk2RkPUjdkvU=; b=o82BQnBVSxJO7Ovo9/zJv0DPwmBg45WVP/W/NGlW6WF2N7f9Ev2Xf3CfaeGVzWYHIM V1JN7JLGGM+uVAWrLbHRXxqp7A/zLoeY9MTUhbn64ARotWu3cINza3zdthCEwQTQgKtO b4dakS28HynOoLT6OHvgTokwALL+Z3I1FIN1Ab8ur8x38sHpyYuAu8wwYecdHWTgaJXL +vdnGwmAZhJeEecDDOV9UhDhg1aW8pol/5RoJTC2GH1+Bv3tn6cfx/4doRmngLd4WOYo elFmOBvBAFI0rw7zv+tXzdtpGWjACp40h2V7w9f2+/0qYpWYdTLBPdsTWSc9k9LPcxtA Z7cw== X-Gm-Message-State: APjAAAWg8kL2So/B2UviTx7dZqXEFJFNQKPnPdFJ3FizJsg40xGHdrvK tExlHmHe69jkLfs6uial3W0FQdXA X-Google-Smtp-Source: APXvYqx+hZaVtuSY2ucGEhM4d22ceU3CgljWC3LrZg5YgdT3fwNl8STl2Da/mCgTNgk/k0ENgKmv8g== X-Received: by 2002:adf:e2cb:: with SMTP id d11mr15524444wrj.66.1559745623446; Wed, 05 Jun 2019 07:40:23 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 5 Jun 2019 16:40:19 +0200 Message-Id: <1559745620-18828-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1559745620-18828-1-git-send-email-pbonzini@redhat.com> References: <1559745620-18828-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PULL 1/2] vl: Fix -drive / -blockdev persistent reservation management X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Markus Armbruster qemu-system-FOO's main() acts on command line arguments in its own idiosyncratic order. There's not much method to its madness. Whenever we find a case where one kind of command line argument needs to refer to something created for another kind later, we rejigger the order. Recent commit cda4aa9a5a "vl: Create block backends before setting machine properties" was such a rejigger. Block backends are now created before "delayed" objects. This broke persistent reservation management. Reproducer: $ qemu-system-x86_64 -object pr-manager-helper,id=3Dpr-helper0,path=3D/= tmp/pr-helper0.sock-drive -drive file=3D/dev/mapper/crypt,file.pr-manager= =3Dpr-helper0,format=3Draw,if=3Dnone,id=3Ddrive-scsi0-0-0-2 qemu-system-x86_64: -drive file=3D/dev/mapper/crypt,file.pr-manager=3Dp= r-helper0,format=3Draw,if=3Dnone,id=3Ddrive-scsi0-0-0-2: No persistent rese= rvation manager with id 'pr-helper0' The delayed pr-manager-helper object is created too late for use by -drive or -blockdev. Normal objects are still created in time. pr-manager-helper has always been a delayed object (commit 7c9e527659 "scsi, file-posix: add support for persistent reservation management"). Turns out there's no real reason for that. Make it a normal object. Fixes: cda4aa9a5a08777cf13e164c0543bd4888b8adce Signed-off-by: Markus Armbruster Message-Id: <20190604151251.9903-2-armbru@redhat.com> Reviewed-by: Michal Privoznik Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- vl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vl.c b/vl.c index f023a8c..cc6246d 100644 --- a/vl.c +++ b/vl.c @@ -2751,8 +2751,7 @@ static bool object_create_initial(const char *type, Q= emuOpts *opts) exit(0); } =20 - if (g_str_equal(type, "rng-egd") || - g_str_has_prefix(type, "pr-manager-")) { + if (g_str_equal(type, "rng-egd")) { return false; } =20 --=20 1.8.3.1 From nobody Mon May 6 03:01:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559746328; cv=none; d=zoho.com; s=zohoarc; b=PC0uWjl1wRSTlYQqfp7CWZEBwr8olwfr+c8S5weK9bkQxwaLDwrxFcgR7qRI6dyeDmbXqkL+eWXYOkie7onjxoPljJXCta1/4AWBI3KY3pE41s3OVa3o3pPiZ0bwqqtO0feTvRszgrcRqlcTMRKZRdCMbVU6WuLN915paAVr0uk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559746328; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=fF19xYu0+HFkIIi6MXFFaCEjhliIhGHLof0zrfgmqj8=; b=LqACcb3F09u4ansXlXWAKwFJ5P+ssEkNe/DKhCxjOhiTKH+OMlPsBQgDHAjeMenjd8RP1gvMIi5TD/kYEuuC/R3Ste32GQ6D4aQZO0VKuhTUDzrZwiwB5PHJe3/K/S0LA4PApJPPlHsr0aZ3U8S9vWJFb3xKBY7rsuJ5oWyutDY= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559746328212873.0943506501746; Wed, 5 Jun 2019 07:52:08 -0700 (PDT) Received: from localhost ([127.0.0.1]:43949 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYXGm-0003RV-4q for importer@patchew.org; Wed, 05 Jun 2019 10:52:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYX5Y-0002PG-QQ for qemu-devel@nongnu.org; Wed, 05 Jun 2019 10:40:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYX5X-0004J8-63 for qemu-devel@nongnu.org; Wed, 05 Jun 2019 10:40:28 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:46604) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYX5W-0004GL-UB for qemu-devel@nongnu.org; Wed, 05 Jun 2019 10:40:27 -0400 Received: by mail-wr1-x42b.google.com with SMTP id n4so14492464wrw.13 for ; Wed, 05 Jun 2019 07:40:25 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id t14sm22123117wrr.33.2019.06.05.07.40.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 07:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=fF19xYu0+HFkIIi6MXFFaCEjhliIhGHLof0zrfgmqj8=; b=EI6yrydI2+LfHUhw+ZPCnoN66ieSU0nHlXBUaFhQhbCjt77fTWwZfPCV7LM1cec2PP dRQqk8i9wFEUPSUbDwNu7CHPFDqQBSTvtAUpQvqWtYBwWBFB/ee4b3cRXyPieZ24DvXs p5xAcAzLaIhVRnUsqCo7Pr6FyxR/0S9Eq64q/Zs5l4nQbg6jO64NNwNhP4Q3bnxPyLvq fFXLmUzNje/7z6fgtGNiuTI1qx/zr0/2UziBn5ju9qvrXywZX3ALP/YxWOByeIW/1DUj vE7mr8sdZYpCW7hRLolJfT1BKK86CExTrMs9Jqghwyvipy2mUu5MF5Cbwfd7/58f2ler oyPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=fF19xYu0+HFkIIi6MXFFaCEjhliIhGHLof0zrfgmqj8=; b=p2SCjC+CurMbl9NB4nhzw9NoRsKI8M2nhTxQTZx5S+gjACOUeHFw6pLvltFBWMOlJi ERejiyWLwBwvVF3yN22/+yp9q27uBglzPEDUxCnPh7Xg04DhsBoyIOySCTmdeTqLXbTp hhf9vf5LdAOesWBvXKrx2lwAe3xMxM6pkqGBhOZynk+aNIHvh0513tB/pDEzP+OxSbJL GIFjXEwSfyuBWnEqeENZbzUszJHjnl8tJxlg7yTH52J18VkC+/6SiHgMAnWIBjAJCPWF WJ9UcdMEQdY20DTGsSy81Egkw8iQ64hXCZNBRq9JXxHbPh11JRIoAnNRjQD7VbRXdB+u pPFA== X-Gm-Message-State: APjAAAX6CClnCIPafMrv9BNn3hX+6ShjaoCwYaF+DVOGz/w6p4tGdiSU wJytdXshBiawa/iNYqszMTOSPQpt X-Google-Smtp-Source: APXvYqwFYBaUivrkYGoUqzAgJegQhtPbZ3RA9SPa5yY8/CirvRZx9vP7II99VY5ogPxLvDiN+1NACA== X-Received: by 2002:a5d:618d:: with SMTP id j13mr3328283wru.195.1559745624418; Wed, 05 Jun 2019 07:40:24 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 5 Jun 2019 16:40:20 +0200 Message-Id: <1559745620-18828-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1559745620-18828-1-git-send-email-pbonzini@redhat.com> References: <1559745620-18828-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42b Subject: [Qemu-devel] [PULL 2/2] vl: Document why objects are delayed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Markus Armbruster Objects should not be "delayed" without a reason, as the previous commit demonstrates. The remaining ones have reasons. State them. and demand future ones come with such a statement. Signed-off-by: Markus Armbruster Message-Id: <20190604151251.9903-3-armbru@redhat.com> Reviewed-by: Michal Privoznik Signed-off-by: Paolo Bonzini --- vl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index cc6246d..cd1fbc4 100644 --- a/vl.c +++ b/vl.c @@ -2751,19 +2751,25 @@ static bool object_create_initial(const char *type,= QemuOpts *opts) exit(0); } =20 + /* + * Objects should not be made "delayed" without a reason. If you + * add one, state the reason in a comment! + */ + + /* Reason: rng-egd property "chardev" */ if (g_str_equal(type, "rng-egd")) { return false; } =20 #if defined(CONFIG_VHOST_USER) && defined(CONFIG_LINUX) + /* Reason: cryptodev-vhost-user property "chardev" */ if (g_str_equal(type, "cryptodev-vhost-user")) { return false; } #endif =20 /* - * return false for concrete netfilters since - * they depend on netdevs already existing + * Reason: filter-* property "netdev" etc. */ if (g_str_equal(type, "filter-buffer") || g_str_equal(type, "filter-dump") || --=20 1.8.3.1