[Qemu-devel] [PATCH 0/6] target/mips: Amend and clean up MSA support

Aleksandar Markovic posted 6 patches 4 years, 9 months ago
Test s390x passed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1559745316-1454-1-git-send-email-aleksandar.markovic@rt-rk.com
Maintainers: Aleksandar Rikalo <arikalo@wavecomp.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Aurelien Jarno <aurelien@aurel32.net>
target/mips/msa_helper.c                           | 252 +++++++++++--
tests/tcg/mips/include/wrappers_msa.h              | 402 ++++++++++++++-------
tests/tcg/mips/user/ase/msa/shift/test_msa_sll_b.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_sll_d.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_sll_h.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_sll_w.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_sra_b.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_sra_d.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_sra_h.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_sra_w.c | 153 ++++++++
.../tcg/mips/user/ase/msa/shift/test_msa_srar_b.c  | 153 ++++++++
.../tcg/mips/user/ase/msa/shift/test_msa_srar_d.c  | 153 ++++++++
.../tcg/mips/user/ase/msa/shift/test_msa_srar_h.c  | 153 ++++++++
.../tcg/mips/user/ase/msa/shift/test_msa_srar_w.c  | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_srl_b.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_srl_d.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_srl_h.c | 153 ++++++++
tests/tcg/mips/user/ase/msa/shift/test_msa_srl_w.c | 153 ++++++++
.../tcg/mips/user/ase/msa/shift/test_msa_srlr_b.c  | 153 ++++++++
.../tcg/mips/user/ase/msa/shift/test_msa_srlr_d.c  | 153 ++++++++
.../tcg/mips/user/ase/msa/shift/test_msa_srlr_h.c  | 153 ++++++++
.../tcg/mips/user/ase/msa/shift/test_msa_srlr_w.c  | 153 ++++++++
22 files changed, 3544 insertions(+), 170 deletions(-)
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_b.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_d.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_h.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_w.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_b.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_d.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_h.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_w.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_b.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_d.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_h.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_w.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_b.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_d.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_h.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_w.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_b.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_d.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_h.c
create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_w.c
[Qemu-devel] [PATCH 0/6] target/mips: Amend and clean up MSA support
Posted by Aleksandar Markovic 4 years, 9 months ago
From: Aleksandar Markovic <amarkovic@wavecomp.com>

This series contains various refactorings and cleanups of MSA
support.

Improve support for logic instructions, add tests for shift
instructions, improve code style, outline future organization.

Aleksandar Markovic (6):
  target/mips: Fix space-related format issues im msa_helper.c
  target/mips: Fix block-comment-related issues im msa_helper.c
  target/mips: Unroll loops in helpers for MSA logic instructions
  tests/tcg: target/mips: Add tests for MSA shift instructions
  tests/tcg: target/mips: Amend and rearrange MSA wrappers
  target/mips: Outline places for future MSA helpers

 target/mips/msa_helper.c                           | 252 +++++++++++--
 tests/tcg/mips/include/wrappers_msa.h              | 402 ++++++++++++++-------
 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_b.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_d.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_h.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_w.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_b.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_d.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_h.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_w.c | 153 ++++++++
 .../tcg/mips/user/ase/msa/shift/test_msa_srar_b.c  | 153 ++++++++
 .../tcg/mips/user/ase/msa/shift/test_msa_srar_d.c  | 153 ++++++++
 .../tcg/mips/user/ase/msa/shift/test_msa_srar_h.c  | 153 ++++++++
 .../tcg/mips/user/ase/msa/shift/test_msa_srar_w.c  | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_b.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_d.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_h.c | 153 ++++++++
 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_w.c | 153 ++++++++
 .../tcg/mips/user/ase/msa/shift/test_msa_srlr_b.c  | 153 ++++++++
 .../tcg/mips/user/ase/msa/shift/test_msa_srlr_d.c  | 153 ++++++++
 .../tcg/mips/user/ase/msa/shift/test_msa_srlr_h.c  | 153 ++++++++
 .../tcg/mips/user/ase/msa/shift/test_msa_srlr_w.c  | 153 ++++++++
 22 files changed, 3544 insertions(+), 170 deletions(-)
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_b.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_d.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_h.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_w.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_b.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_d.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_h.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_w.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_b.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_d.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_h.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_w.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_b.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_d.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_h.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_w.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_b.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_d.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_h.c
 create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_w.c

-- 
2.7.4


Re: [Qemu-devel] [PATCH 0/6] target/mips: Amend and clean up MSA support
Posted by Aleksandar Rikalo 4 years, 9 months ago
> From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
> Sent: Wednesday, June 5, 2019 4:35 PM
> To: qemu-devel@nongnu.org
> Cc: Aleksandar Markovic; Aleksandar Rikalo
> Subject: [PATCH 0/6] target/mips: Amend and clean up MSA support
>
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> This series contains various refactorings and cleanups of MSA
> support.
>
> Improve support for logic instructions, add tests for shift
> instructions, improve code style, outline future organization.
>
> Aleksandar Markovic (6):
>   target/mips: Fix space-related format issues im msa_helper.c
>   target/mips: Fix block-comment-related issues im msa_helper.c
>   target/mips: Unroll loops in helpers for MSA logic instructions
>   tests/tcg: target/mips: Add tests for MSA shift instructions
>   tests/tcg: target/mips: Amend and rearrange MSA wrappers
>   target/mips: Outline places for future MSA helpers
>

For the whole series:

Reviewed-by: Aleksandar Rikalo <arikalo@wavecomp.com>


>  target/mips/msa_helper.c                           | 252 +++++++++++--
>  tests/tcg/mips/include/wrappers_msa.h              | 402 ++++++++++++++-------
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sll_b.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sll_d.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sll_h.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sll_w.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sra_b.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sra_d.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sra_h.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sra_w.c | 153 ++++++++
>  .../tcg/mips/user/ase/msa/shift/test_msa_srar_b.c  | 153 ++++++++
>  .../tcg/mips/user/ase/msa/shift/test_msa_srar_d.c  | 153 ++++++++
>  .../tcg/mips/user/ase/msa/shift/test_msa_srar_h.c  | 153 ++++++++
>  .../tcg/mips/user/ase/msa/shift/test_msa_srar_w.c  | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srl_b.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srl_d.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srl_h.c | 153 ++++++++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srl_w.c | 153 ++++++++
>  .../tcg/mips/user/ase/msa/shift/test_msa_srlr_b.c  | 153 ++++++++
>  .../tcg/mips/user/ase/msa/shift/test_msa_srlr_d.c  | 153 ++++++++
>  .../tcg/mips/user/ase/msa/shift/test_msa_srlr_h.c  | 153 ++++++++
>  .../tcg/mips/user/ase/msa/shift/test_msa_srlr_w.c  | 153 ++++++++
>  22 files changed, 3544 insertions(+), 170 deletions(-)
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sll_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_sra_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srar_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srl_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_w.c
>
> --
> 2.7.4