From nobody Tue Feb 10 03:39:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1557753258; cv=none; d=zoho.com; s=zohoarc; b=nD4foWBcCjGNLqE4lGmx9YXPOyZmNY1/xYlqI++B+ZAjjPrh/i1D4jAwPU7O3v2W4+lx09LK1jYez9PdKnNKyGhLVOegXQof3R8VkD0usukF+mW7GwWYui0LAT+eOjjXfmwb4KX7ti0KXhTG120HXrOvxqgxKNe4iWBqzC9+kbI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557753258; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=CppaNZPgjiMA0RVTPrttMqmMlAsh9JEqURmMcfAC8TI=; b=MVmNKHgfM6q8RXBLTusKGOKvOuBJfUZIcdXmahRGBN3Kl8vUn7AwtGo7MIHdWxZzYXOPfFtjB1UHamjbLRBVxKLU5Toq6GYZD40zo20EcYbhIE/wjlYBIwaOnHxDfFWDBhp5v7vHzv7coDY2kDJFyTYSHzTzj+g1kR2MJ9e7E3I= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155775325827088.23571647424296; Mon, 13 May 2019 06:14:18 -0700 (PDT) Received: from localhost ([127.0.0.1]:57140 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQAmU-0004hn-8O for importer@patchew.org; Mon, 13 May 2019 09:14:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQAbo-0003Xj-JX for qemu-devel@nongnu.org; Mon, 13 May 2019 09:03:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQAM0-00084E-5M for qemu-devel@nongnu.org; Mon, 13 May 2019 08:46:53 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:57482 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQALy-0007xF-Bk; Mon, 13 May 2019 08:46:50 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 45F5B95B4F46855B7575; Mon, 13 May 2019 20:46:43 +0800 (CST) Received: from ros.huawei.com (10.143.28.118) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Mon, 13 May 2019 20:46:35 +0800 From: Dongjiu Geng To: , , , , , , , , , , , , , , , , , Date: Mon, 13 May 2019 05:43:02 -0700 Message-ID: <1557751388-27063-5-git-send-email-gengdongjiu@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1557751388-27063-1-git-send-email-gengdongjiu@huawei.com> References: <1557751388-27063-1-git-send-email-gengdongjiu@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.143.28.118] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 45.249.212.32 Subject: [Qemu-devel] [PATCH v16 04/10] acpi: add build_append_ghes_generic_data() helper for Generic Error Data Entry X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It will help to add Generic Error Data Entry to ACPI tables without using packed C structures and avoid endianness issues as API doesn't need explicit conversion. Signed-off-by: Dongjiu Geng --- hw/acpi/aml-build.c | 32 ++++++++++++++++++++++++++++++++ include/hw/acpi/aml-build.h | 6 ++++++ 2 files changed, 38 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index fb53f21..102a288 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -296,6 +296,38 @@ void build_append_ghes_notify(GArray *table, const uin= t8_t type, build_append_int_noprefix(table, error_threshold_window, 4); } =20 +/* Generic Error Data Entry + * ACPI 4.0: 17.3.2.6.1 Generic Error Data + */ +void build_append_ghes_generic_data(GArray *table, const char *section_typ= e, + uint32_t error_severity, uint16_t revi= sion, + uint8_t validation_bits, uint8_t flags, + uint32_t error_data_length, uint8_t *f= ru_id, + uint8_t *fru_text, uint64_t time_stamp) +{ + int i; + + for (i =3D 0; i < 16; i++) { + build_append_int_noprefix(table, section_type[i], 1); + } + + build_append_int_noprefix(table, error_severity, 4); + build_append_int_noprefix(table, revision, 2); + build_append_int_noprefix(table, validation_bits, 1); + build_append_int_noprefix(table, flags, 1); + build_append_int_noprefix(table, error_data_length, 4); + + for (i =3D 0; i < 16; i++) { + build_append_int_noprefix(table, fru_id[i], 1); + } + + for (i =3D 0; i < 20; i++) { + build_append_int_noprefix(table, fru_text[i], 1); + } + + build_append_int_noprefix(table, time_stamp, 8); +} + /* * Build NAME(XXXX, 0x00000000) where 0x00000000 is encoded as a dword, * and return the offset to 0x00000000 for runtime patching. diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index 90c8ef8..a71db2f 100644 --- a/include/hw/acpi/aml-build.h +++ b/include/hw/acpi/aml-build.h @@ -419,6 +419,12 @@ void build_append_ghes_notify(GArray *table, const uin= t8_t type, uint32_t error_threshold_value, uint32_t error_threshold_window); =20 +void build_append_ghes_generic_data(GArray *table, const char *section_typ= e, + uint32_t error_severity, uint16_t revi= sion, + uint8_t validation_bits, uint8_t flags, + uint32_t error_data_length, uint8_t *f= ru_id, + uint8_t *fru_text, uint64_t time_stamp= ); + void build_srat_memory(AcpiSratMemoryAffinity *numamem, uint64_t base, uint64_t len, int node, MemoryAffinityFlags flags); =20 --=20 1.8.3.1