From nobody Mon Feb 9 19:53:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556810298; cv=none; d=zoho.com; s=zohoarc; b=crqo45mXkpZGagqVs6sBTd2cEn56Md4uqXM2vmRZWaWGzh+8PFkjFaZE+htZgVnEi/dzwK1pIhVWLpFbftb8zLBMV6UO38CR/sSqnq85pZo4AIhPMWijalmQRHYYb+6Dl5Zjfmpnq3anow+D41XtlH+BTsIM2UzIonI0nBgq3ko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556810298; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=C0ZCYJq/XjJ+XgTY3t0QUYqIV7+YDBr3+9BmPPkjLJk=; b=YEdzrrZdoSA+FAafXuzADFygxLpr/d+v2o/74weRVnmIJAa1O7WJVJ7dYg5bMh8IzySosP6SGnN78MHUUdF8TBfAfKM+e7xgaYMS/dlCEVteo9k87nhnl5KUeUBX0kqZQYVf37J3EsLPzZDqY+KoqQnoSsI+f0rjVhO4InVekxQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556810298450549.7762507318732; Thu, 2 May 2019 08:18:18 -0700 (PDT) Received: from localhost ([127.0.0.1]:52953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMDTQ-0001vO-D9 for importer@patchew.org; Thu, 02 May 2019 11:18:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMD4w-0005kY-Ps for qemu-devel@nongnu.org; Thu, 02 May 2019 10:52:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMD4v-0003BC-Np for qemu-devel@nongnu.org; Thu, 02 May 2019 10:52:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3202) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMD4v-0003AD-IX for qemu-devel@nongnu.org; Thu, 02 May 2019 10:52:53 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B363A330260; Thu, 2 May 2019 14:52:52 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE10D71C80; Thu, 2 May 2019 14:52:48 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Date: Thu, 2 May 2019 16:52:03 +0200 Message-Id: <1556808723-226478-16-git-send-email-imammedo@redhat.com> In-Reply-To: <1556808723-226478-1-git-send-email-imammedo@redhat.com> References: <1556808723-226478-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 02 May 2019 14:52:52 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4 15/15] tests: acpi: print error unable to dump ACPI table during rebuild X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jones , Ben Warren , "Michael S. Tsirkin" , Laszlo Ersek , linuxarm@huawei.com, Shameer Kolothum , Shannon Zhao , Gonglei , Wei Yang , xuwei5@huawei.com, xuwei5@hisilicon.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Instead of just asserting print the error that lead to assert first. While at it move assert into rebuild branch, which removes redundant check done in case of !rebuild branch is taken (the later is taken care of by g_assert_no_error). Signed-off-by: Igor Mammedov Reviewed-by: Wei Yang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v4: * fix typo in commit message (Reviewed-by: Philippe Mathieu-Daud=C3=A9 ) --- tests/bios-tables-test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index eaa1b0c..6cb8b16 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -195,11 +195,14 @@ static void dump_aml_files(test_data *data, bool rebu= ild) sdt->aml, ext); fd =3D g_open(aml_file, O_WRONLY|O_TRUNC|O_CREAT, S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH); + if (fd < 0) { + perror(aml_file); + } + g_assert(fd >=3D 0); } else { fd =3D g_file_open_tmp("aml-XXXXXX", &sdt->aml_file, &error); g_assert_no_error(error); } - g_assert(fd >=3D 0); =20 ret =3D qemu_write_full(fd, sdt->aml, sdt->aml_len); g_assert(ret =3D=3D sdt->aml_len); --=20 2.7.4