From nobody Mon Nov 10 11:20:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556616508; cv=none; d=zoho.com; s=zohoarc; b=ShMtF9aal4s+i1PmzfFRiEQcl2bgh1nQx/EXddJSzqLV4ONJ6j00B7EIDCmpcJ+UfjjJjzs/AAnRasTketp+Qr10FQ+yZGU4gpShx3UJ31kTey3ij/TlLQm0bpbLmJZI18qiEpxBxu/UP6j8jCUMdC3jAHlip2q/q8EIB8+yNkc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556616508; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=JDIStnb+kb3QZhVbNjmxtQkNHvVTGnxLu9/GVbJt+cU=; b=P2iSTklAwjfz/ceFX0xUDaypVhoyNyXq3NEivGrJrnoXMiWkffpM8Tx0CNYVGsbF4ePlEdCwSB6++yWfIn/XDXeanTiOodFqOkHMTWjFaFPSeyDxDSh+/w5kqMPsWOTEzEoqxcG2ArYG3Ppqpybq/yC0YoaVDRTJb//MWw3vVME= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556616508196888.659575950216; Tue, 30 Apr 2019 02:28:28 -0700 (PDT) Received: from localhost ([127.0.0.1]:42099 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLP3p-0002mJ-7G for importer@patchew.org; Tue, 30 Apr 2019 05:28:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLP2V-0002AH-2a for qemu-devel@nongnu.org; Tue, 30 Apr 2019 05:27:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLP2U-0003OV-1i for qemu-devel@nongnu.org; Tue, 30 Apr 2019 05:27:03 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:2062 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLP2T-0003MU-Ns for qemu-devel@nongnu.org; Tue, 30 Apr 2019 05:27:02 -0400 Received: from DGGEML402-HUB.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 79E759F0EBA8A7623BB4; Tue, 30 Apr 2019 17:26:57 +0800 (CST) Received: from localhost.localdomain (10.175.104.211) by DGGEML402-HUB.china.huawei.com (10.3.17.38) with Microsoft SMTP Server id 14.3.439.0; Tue, 30 Apr 2019 17:26:48 +0800 From: Jie Wang To: Date: Tue, 30 Apr 2019 15:15:00 +0800 Message-ID: <1556608500-12183-1-git-send-email-wangjie88@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.104.211] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 45.249.212.189 Subject: [Qemu-devel] [PATCH] vhost: fix memory leak in vhost_user_scsi_realize X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangjie88@huawei.com, wu.wubin@huawei.com, mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fix memory leak in vhost_user_scsi_realize Signed-off-by: Jie Wang Reviewed-by: Stefan Hajnoczi --- hw/scsi/vhost-user-scsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c index 8b1e6876db..a9fd8ea305 100644 --- a/hw/scsi/vhost-user-scsi.c +++ b/hw/scsi/vhost-user-scsi.c @@ -69,6 +69,7 @@ static void vhost_user_scsi_realize(DeviceState *dev, Err= or **errp) VirtIOSCSICommon *vs =3D VIRTIO_SCSI_COMMON(dev); VHostUserSCSI *s =3D VHOST_USER_SCSI(dev); VHostSCSICommon *vsc =3D VHOST_SCSI_COMMON(s); + struct vhost_virtqueue *vqs =3D NULL; Error *err =3D NULL; int ret; =20 @@ -93,6 +94,7 @@ static void vhost_user_scsi_realize(DeviceState *dev, Err= or **errp) vsc->dev.vqs =3D g_new(struct vhost_virtqueue, vsc->dev.nvqs); vsc->dev.vq_index =3D 0; vsc->dev.backend_features =3D 0; + vqs =3D vsc->dev.vqs; =20 ret =3D vhost_dev_init(&vsc->dev, &s->vhost_user, VHOST_BACKEND_TYPE_USER, 0); @@ -100,6 +102,7 @@ static void vhost_user_scsi_realize(DeviceState *dev, E= rror **errp) error_setg(errp, "vhost-user-scsi: vhost initialization failed: %s= ", strerror(-ret)); vhost_user_cleanup(&s->vhost_user); + g_free(vqs); return; } =20 --=20 2.16.2.windows.1