From nobody Mon Nov 10 11:24:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1555933184; cv=none; d=zoho.com; s=zohoarc; b=dB3az4DI0YOGPMeNdqbsHwLi2OONzcf08Ip7w2TGmM4vMf68zZkWYyYb9OOtiF4XGXYgk2Ln2XDsddiuvBrY6WfOXb3cUy5Xssnx3PtvWbRjumzHFegdsKIWNqpAL2FZWzRa6ZDDIn+vcbtgsM+ChfBS9GjKCr0rxdZpcOTNoi8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555933184; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=75VZbF7srNgO4XgGtyXrtbt6oXSxdit1FRU0XSLnOd4=; b=bSdurQYXhWWRKOQ3FBgOu6oNmoWwoxwXiG12SbnGuRLTQRINAYB7+G1CAGyLIxHSJqhGKjRE3mjnDVtOSOc7mFxjielfTOgEv0gSszpIkV0g/sWOrGvaFStAh8BgV1X8Qd9Eu9QUjk7XYLVGTA4AZRkeOXaoQMYGcvpiogCzlDs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555933184815178.7315053919507; Mon, 22 Apr 2019 04:39:44 -0700 (PDT) Received: from localhost ([127.0.0.1]:36044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIXIL-00089V-Sq for importer@patchew.org; Mon, 22 Apr 2019 07:39:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIX1R-0001RR-9b for qemu-devel@nongnu.org; Mon, 22 Apr 2019 07:22:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIX1O-0002gC-LR for qemu-devel@nongnu.org; Mon, 22 Apr 2019 07:22:04 -0400 Received: from mail.ispras.ru ([83.149.199.45]:47408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIX1M-0002dX-EW for qemu-devel@nongnu.org; Mon, 22 Apr 2019 07:22:01 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 961595400A9; Mon, 22 Apr 2019 14:21:55 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Mon, 22 Apr 2019 14:21:55 +0300 Message-ID: <155593211539.21079.18009501411293484959.stgit@pasha-Precision-3630-Tower> In-Reply-To: <155593197705.21079.8238359471765771689.stgit@pasha-Precision-3630-Tower> References: <155593197705.21079.8238359471765771689.stgit@pasha-Precision-3630-Tower> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH for-4.1 24/24] icount: clean up cpu_can_io before jumping to the next block X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, crosthwaite.peter@gmail.com, ciro.santilli@gmail.com, jasowang@redhat.com, quintela@redhat.com, armbru@redhat.com, mreitz@redhat.com, alex.bennee@linaro.org, maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com, boost.lists@gmail.com, thomas.dullien@googlemail.com, dovgaluk@ispras.ru, artem.k.pisarenko@gmail.com, dgilbert@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Pavel Dovgalyuk Most of IO instructions can be executed only at the end of the block in icount mode. Therefore translator can set cpu_can_io flag when translating the last instruction. But when the blocks are chained, then this flag is not reset and may remain set at the beginning of the next block. This patch resets the flag before "chaining" the translation blocks. Signed-off-by: Pavel Dovgalyuk --- accel/tcg/tcg-runtime.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runtime.c index d0d4484406..5871f5aba2 100644 --- a/accel/tcg/tcg-runtime.c +++ b/accel/tcg/tcg-runtime.c @@ -151,6 +151,8 @@ void *HELPER(lookup_tb_ptr)(CPUArchState *env) target_ulong cs_base, pc; uint32_t flags; =20 + /* We are going to jump to the next block. can_do_io should be reset */ + cpu->can_do_io =3D !use_icount; tb =3D tb_lookup__cpu_state(cpu, &pc, &cs_base, &flags, curr_cflags()); if (tb =3D=3D NULL) { return tcg_ctx->code_gen_epilogue;