From nobody Mon Nov 10 11:23:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1555932433; cv=none; d=zoho.com; s=zohoarc; b=jId3HP8kwVvcifEV4AsloG+13ey7PoP6KWP88IpN2L7gMzy888hOkAVjXSIR7ab4Sl6DebTkZRNd6K786xasSRvK+JP7BddFlxMMlWLJeWmZNrJZGG/ggRkAXanOAHOb56SOlS0+EmLhk21VKh2sg2UAmqJYhc4qSLHiq9CPUVk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555932433; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=N6ven/w872l8lzjP5ek++TjFpSJeG4g07zjiYRz7wXU=; b=EzrXi3eSM8xZvl901AnvzUZ5xWeG0C5rEqT4+5h7ZZkniVkNBl2NN9fTD6FMNUzWXkW/QIXIrGV2F5UrBgXEirVetZHDRW6JjQBI/yG9lp7TDkK1/XvaA41NVx+9ml/GQgnMHH4GmN5LBMJ6wKrBmj9ZbEBlT8J6s3xQAiP3hUI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155593243334849.970364965817225; Mon, 22 Apr 2019 04:27:13 -0700 (PDT) Received: from localhost ([127.0.0.1]:35851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIX6L-0005Sd-0T for importer@patchew.org; Mon, 22 Apr 2019 07:27:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIWzl-0008BK-3D for qemu-devel@nongnu.org; Mon, 22 Apr 2019 07:20:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIWzh-0001ab-Bb for qemu-devel@nongnu.org; Mon, 22 Apr 2019 07:20:19 -0400 Received: from mail.ispras.ru ([83.149.199.45]:46940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIWzf-0001ZD-IU for qemu-devel@nongnu.org; Mon, 22 Apr 2019 07:20:15 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id A89F35400A9; Mon, 22 Apr 2019 14:20:13 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Mon, 22 Apr 2019 14:20:13 +0300 Message-ID: <155593201350.21079.3170788857286903934.stgit@pasha-Precision-3630-Tower> In-Reply-To: <155593197705.21079.8238359471765771689.stgit@pasha-Precision-3630-Tower> References: <155593197705.21079.8238359471765771689.stgit@pasha-Precision-3630-Tower> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH for-4.1 06/24] replay: finish record/replay before closing the disks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, crosthwaite.peter@gmail.com, ciro.santilli@gmail.com, jasowang@redhat.com, quintela@redhat.com, armbru@redhat.com, mreitz@redhat.com, alex.bennee@linaro.org, maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com, boost.lists@gmail.com, thomas.dullien@googlemail.com, dovgaluk@ispras.ru, artem.k.pisarenko@gmail.com, dgilbert@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Pavel Dovgalyuk After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c | 2 ++ vl.c | 1 + 2 files changed, 3 insertions(+) diff --git a/replay/replay.c b/replay/replay.c index 8b172b2d1b..b75820a1c1 100644 --- a/replay/replay.c +++ b/replay/replay.c @@ -385,6 +385,8 @@ void replay_finish(void) g_free(replay_snapshot); replay_snapshot =3D NULL; =20 + replay_mode =3D REPLAY_MODE_NONE; + replay_finish_events(); } =20 diff --git a/vl.c b/vl.c index cfb60b8455..492095bc58 100644 --- a/vl.c +++ b/vl.c @@ -4619,6 +4619,7 @@ int main(int argc, char **argv, char **envp) =20 /* No more vcpu or device emulation activity beyond this point */ vm_shutdown(); + replay_finish(); =20 job_cancel_sync_all(); bdrv_close_all();