From nobody Mon Nov 10 11:24:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1555932505; cv=none; d=zoho.com; s=zohoarc; b=TyT6mcMlXjdLE3MVzna6i9poUiPC+Ia9XDhAODtUgPqoiFyt/NhoKJb0YVz9RSiPSmI+ovWvlWJnVD3u25cYGwUelnuyONfPKDoA12BloZBSmuqeVH9esuGeeTXfgV2yKw8edXrM1/7ghhNgRbu/Q382VclYBy8YxefMaUW9VyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555932505; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=CkuHATfMfWtr8MgGUs91intQ+mZ5Ev6jUmxmSXpvBfA=; b=FSL06jpSJU3cPD0clDSySPQpFWsKQ7sL6ti+lf24vUID4syLxbTp9u4nGlaEqmom0+JtH4vbegMe8RpjAQMDSjQNw9GtysteUl2NXqYomu8/C+6G8YmnZio21U+0+SMNh0oRzHNCSi3MKx0vhuKQwl8UdoGGTzhak/nOwNe9+zs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555932505864482.31071754125026; Mon, 22 Apr 2019 04:28:25 -0700 (PDT) Received: from localhost ([127.0.0.1]:35857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIX7M-0006OS-Q9 for importer@patchew.org; Mon, 22 Apr 2019 07:28:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIWzO-0007xC-LG for qemu-devel@nongnu.org; Mon, 22 Apr 2019 07:19:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIWzN-0001T7-Pg for qemu-devel@nongnu.org; Mon, 22 Apr 2019 07:19:58 -0400 Received: from mail.ispras.ru ([83.149.199.45]:46846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIWzN-0001Sr-Ix for qemu-devel@nongnu.org; Mon, 22 Apr 2019 07:19:57 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id B26A75400A9; Mon, 22 Apr 2019 14:19:56 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Mon, 22 Apr 2019 14:19:56 +0300 Message-ID: <155593199653.21079.2530903379467355249.stgit@pasha-Precision-3630-Tower> In-Reply-To: <155593197705.21079.8238359471765771689.stgit@pasha-Precision-3630-Tower> References: <155593197705.21079.8238359471765771689.stgit@pasha-Precision-3630-Tower> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH for-4.1 03/24] replay: disable default snapshot for record/replay X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, crosthwaite.peter@gmail.com, ciro.santilli@gmail.com, jasowang@redhat.com, quintela@redhat.com, armbru@redhat.com, mreitz@redhat.com, alex.bennee@linaro.org, maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com, boost.lists@gmail.com, thomas.dullien@googlemail.com, dovgaluk@ispras.ru, artem.k.pisarenko@gmail.com, dgilbert@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf --- vl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index c696ad2a13..cfb60b8455 100644 --- a/vl.c +++ b/vl.c @@ -1223,7 +1223,7 @@ static void configure_blockdev(BlockdevOptionsQueue *= bdo_queue, qapi_free_BlockdevOptions(bdo->bdo); g_free(bdo); } - if (snapshot || replay_mode !=3D REPLAY_MODE_NONE) { + if (snapshot) { qemu_opts_foreach(qemu_find_opts("drive"), drive_enable_snapshot, NULL, NULL); } @@ -3181,7 +3181,13 @@ int main(int argc, char **argv, char **envp) drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS); break; case QEMU_OPTION_snapshot: - snapshot =3D 1; + { + Error *blocker =3D NULL; + snapshot =3D 1; + error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED, + "-snapshot"); + replay_add_blocker(blocker); + } break; case QEMU_OPTION_numa: opts =3D qemu_opts_parse_noisily(qemu_find_opts("numa"),